Skip to content

Rename from "Mach" to "MISO" - #64

Merged
jehicken merged 1 commit into
devfrom
miso-dev
Aug 1, 2023
Merged

Rename from "Mach" to "MISO"#64
jehicken merged 1 commit into
devfrom
miso-dev

Conversation

@tuckerbabcock

@tuckerbabcocktuckerbabcock commented Jul 31, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This PR renames all types, files, etc. from "mach" to the new name, "MISO".

@tuckerbabcocktuckerbabcock changed the title Rename everything from "Mach" to "MISORename from "Mach" to "MISO"Jul 31, 2023
@tuckerbabcock
tuckerbabcock changed the base branch from master to devJuly 31, 2023 18:59
@Aerokaur

Aerokaur commented Jul 31, 2023

Copy link
Copy Markdown
Member

What is MISO ?

@tuckerbabcock

tuckerbabcock commented Jul 31, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

It's our Multi-physics Integrated Simulations and Optimization (MISO) library 🙂. Renamed in part to avoid confusion with https://github.com/mdolab/MACH-Aero when we release this open-source.

@jehicken

jehicken commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @tuckerbabcock. Does this include the flow residual code (the stuff we used for Luiz's work)? I am having trouble finding it. (Was I supposed to merge that?)

@jehicken

jehicken commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

I just saw #63. This might demand a meeting to understand where things stand.

@tuckerbabcock

tuckerbabcock commented Aug 1, 2023

Copy link
Copy Markdown
MemberAuthor

I don't think this explicitly included the solver we used for Luiz's work. My intention was to change the dev branch, and then before any other branches are merged into dev, we would merge dev into them and the renamed would propagate through. #63 is somewhat of a work in progress PR to remind me to eventually merge it. I think too much has changed since I opened it to merge it right away. Happy to meet to further discuss this though.

@jehicken

jehicken commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

Ok, if you think merging the flow-residual branch(es) will be relatively straightforward, then let's proceed.

@jehickenjehicken closed this Aug 1, 2023
@jehickenjehicken reopened this Aug 1, 2023
jehicken
jehicken approved these changes Aug 1, 2023
View reviewed changes

@jehickenjehicken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much to review thoroughly, I am just going to assume our tests will catch any issues.

@jehicken
jehicken merged commit d42dcf1 into devAug 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jehickenjehickenjehicken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tuckerbabcock@Aerokaur@jehicken