fix: rename misleading USD Equivalent column in CSV exports - #21
Merged
ibrahimmosouf-png merged 1 commit intoJun 18, 2026
Merged
Conversation
The 'USD Equivalent' column in donation CSV exports was hardcoded to '0.00' with a comment indicating it would be fetched from a price cache in production. This is misleading for users who may trust the value for tax/accounting purposes. Changes: - Renamed column to 'USD Equivalent (pending)' to clearly indicate the value is not yet available - Changed hardcoded '0.00' to 'N/A' with explanatory comment - Applied to all three export locations: - src/users/users.service.ts - src/users/export.processor.ts - src/donations/donations.service.ts Closes OrbitChainLabs#15
ibrahimmosouf-png
approved these changes
Jun 18, 2026
ibrahimmosouf-png
left a comment
Contributor
There was a problem hiding this comment.
Nice honest fix, @postqcoin 👏
Renaming the column to "USD Equivalent (pending)" and replacing the placeholder 0.00 with N/A plus a short comment is exactly the right call until the price oracle lands — much better than shipping misleading zeros. Small, scoped, and closes #15 cleanly.
Merging now. Thanks for taking this on!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 'USD Equivalent' column in donation CSV exports is hardcoded to '0.00' with a comment indicating it would be fetched from a price cache in production. This is misleading for users who may trust the value for tax/accounting purposes.
Fix
Closes #15