Skip to content

Buying NFT from launchpad and depositing it to Safe - #270

Merged
porkbrain merged 4 commits into
developfrom
feature/create-safe-and-buy-launchpad-nft
Feb 21, 2023
Merged

Buying NFT from launchpad and depositing it to Safe#270
porkbrain merged 4 commits into
developfrom
feature/create-safe-and-buy-launchpad-nft

Conversation

@porkbrain

Copy link
Copy Markdown
Contributor

No description provided.

@porkbrainporkbrain self-assigned this Feb 21, 2023

@SuficioSuficio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also replicate these endpoints for the LimitedFixedPriceMarket

Comment threadsources/launchpad/market/fixed_price.move
///
/// Panics if `Venue` does not exist, is not live, or is whitelisted or
/// wallet does not have the necessary funds.
public entry fun create_safe_and_buy_nft<C, FT>(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could also add an endpoint buy_nft_into_safe (or something like that) that takes a reference to a safe that already exists.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sort of leads into a question: how can a collection owner say they want the NFTs to be deposited into safe only. Because that is the royalty guarantee. Would they have to whitelist and build their own endpoint?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, could you create an issue so we make sure to go back to this?

@porkbrain
porkbrain merged commit 81699fd into developFeb 21, 2023
@porkbrain
porkbrain deleted the feature/create-safe-and-buy-launchpad-nft branch February 21, 2023 21:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@porkbrain@Suficio