Uh oh!
There was an error while loading. Please reload this page.
fix(metadata): prevent table page offset overflow - #2824
Open
HandSonic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
Cached relational table pagination calculated
(pageNo - 1) * pageSizewithintarithmetic. Accepted maximum-bound requests wrapped to negative indexes and reachedsubList, raisingIndexOutOfBoundsException. This change derives the offset and end withlong, returns an empty out-of-range page, and only converts indexes after proving they fit the table list.Affected surfaces
Verification
DbMetadataAccessPolicyTest: 3 tests passed.git diff --check origin/main...HEAD: passed.Integer.MAX_VALUE/100000boundary without an external database.Risk and compatibility
Reviewer map
DbTableServiceImpl.pageQueryand the maximum-bound case inDbMetadataAccessPolicyTest.d41de444748362d7b7fefe339ac95afab66be423; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, deterministic tests, verification, and adversarial review.