Uh oh!
There was an error while loading. Please reload this page.
fix(h2): bind routine details to schema - #2825
Open
HandSonic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
H2 function, procedure, and trigger detail queries placed the catalog name into
ROUTINE_SCHEMA/TRIGGER_SCHEMApredicates. In ordinary catalog-plus-schema connections this returned no detail or the wrong schema. This change binds those predicates to the requested schema while preserving the catalog on the returned metadata objects.Affected surfaces
Verification
git diff --check origin/main...HEAD: passed.Risk and compatibility
Reviewer map
H2Meta.function,procedure,trigger, andH2MetaSchemaBindingTest.f33bb3a656f7c191cd69d6d83b43c65894050499; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, and adversarial review.