Uh oh!
There was an error while loading. Please reload this page.
fix(ai): keep latest mention table request - #2833
Open
HandSonic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
AI table/view mention requests had no context or search ownership. A slower response from an old datasource, page, or search could overwrite the latest list/cache, and an old error used the first-render page closure when clearing context. This change assigns every request a page/context/search generation, checks ownership after each table and view await, and invalidates in-flight work on context, trigger, or lifecycle changes.
Affected surfaces
Verification
Risk and compatibility
Reviewer map
mentionTableRequestCoordinator.ts, thenAIChatInput.fetchTableListand trigger/context effects.4da062b6ea80ab15694a87004a8ebaa20a0df5a3; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, and adversarial review.