Uh oh!
There was an error while loading. Please reload this page.
fix(ai): roll back failed history deletion - #2841
Open
HandSonic wants to merge 1 commit into
Open
Conversation
HandSonicforce-pushed
the
fix/ai-history-delete-rollback
branch
from
August 31, 2026 05:10
3455524 to
c2cbae9Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
AI history deletion persisted removal from the owner session index before deleting the message file. If message deletion failed, the owner record was lost; a retry then saw no owned session and silently left the orphaned message path forever. This change restores the original session snapshot on deletion failure and preserves rollback failures as suppressed diagnostics.
Affected surfaces
Verification
Risk and compatibility
Reviewer map
AiChatHistoryServiceImpl.deleteSessionLocalandAiChatHistoryDeleteRollbackTest.c2cbae9b48ec1ce4dc14a82bdcba2dc7dbea53bf; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, deterministic tests, verification, and adversarial review.