Uh oh!
There was an error while loading. Please reload this page.
Add Semgrep configuration and ignore file; update CONTRIBUTING.md and README.md - #17
Conversation
… README.md - Introduced `.semgrepignore` to specify paths for Semgrep to skip. - Added Semgrep GitHub Actions workflow for security and code quality checks. - Updated `CONTRIBUTING.md` to include details about automated checks on PRs. - Enhanced `README.md` with additional badges for CI, Semgrep, and Socket.
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
✅ I finished the code review, and didn't find any security or code quality issues. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds Semgrep SAST scanning to CI and updates repository documentation to reflect security/trust signals and contributor expectations.
Changes:
- Introduce a Semgrep GitHub Actions workflow with secrets + JS/TS rules and SARIF artifact upload.
- Add
.semgrepignoreto exclude generated/build/vendor paths from scans. - Update README badges/docs link and expand CONTRIBUTING with PR check expectations + a scanners table.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Adds trust/status badges and adjusts documentation link. |
| CONTRIBUTING.md | Documents expected PR checks and adds maintainers’ scanner matrix. |
| .semgrepignore | Defines Semgrep ignore paths for generated/build/vendor artifacts. |
| .github/workflows/semgrep.yml | Adds Semgrep CI workflow for PRs + scheduled scans with SARIF artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Added `node_modules/` to `.semgrepignore` to reduce noise in scans. - Updated README.md to link directly to the LICENSE file in the repository. - Pinned the Semgrep CLI image version in the GitHub Actions workflow for reproducibility.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
GIV-9546: Add Semgrep SAST and README trust badges for the loader
What is the feature/bug?
The public
payment-elementsloader had CI, Inspector, CodeQL, and Socket, but no Semgrep SAST. The README also lacked an honest trust strip; the Socket badge story was pinned to the bootstraplatestpackage rather than the live package page.What is the solution?
p/secrets(repo-wide) andp/typescript+p/javascript(src/,test/) on PRs tomain, plus weekly cron andworkflow_dispatch; SARIF artifacts retained 90 daystypes/, build output, andnode_modules/next, CI, Semgrep, Socket (package-level), license, and Node badges; docs link pointed at/payment-elementsWhat areas of the application does it impact?
Overflow-App/payment-elementsonly (CI/docs). No runtime loader or CDN SDK changes.Testing
semgrep/semgrepDocker image onsrc/+test/: 0 findingsNotes
Semgrepcheck required onmain.