Uh oh!
There was an error while loading. Please reload this page.
Cleanup command line builder - #5
Conversation
Hey @TMiguelT, just FYI for this PR and v0.3.0 release. Specifically removing the interpolation options for these reasons:
I'll attach the code I now use for quoting the command line. I use the updated Edit: Fixed a few things with my binding (optional arrays, arrays of optional types, prefix generation for arrays) |
illusional
commented
Jul 13, 2020
The OpenWDL PR has been merged, including implementations in Cromwell and MiniWDL - so this will merge. |
I've never really been happy with the command line builder - this has sort of led me to half-implement building the command line with wdlgen, and half in an external project.
I guess it depends what you want from this project, but I don't believe the core should be taking care of that for you - I believe it should be a more faithful representation of WDL.
For this reason, in v0.3.0 I've removed the option to provide components to the
Task.Command.CommandInput(which would construct the workflow for you). This behaviour will still exist temporarily in inTask.Command.CommandInput.from_fields, but with a number of PRs coming to cleanup these string interpolation options and provide a quoting mechanic, I don't think we need to do this.