Uh oh!
There was an error while loading. Please reload this page.
Added new tests vacancy - #219
Open
denkoten wants to merge 4 commits into
Open
Conversation
yakser
requested changes
Oct 29, 2023
yakser
left a comment
Member
There was a problem hiding this comment.
переименуй функции и вынеси в test_utils, много копипаста, объясни зачем ты разделил все на несколько тесткейсов
| user.save() | ||
| return user | ||
| def second_user_create(self): |
Member
There was a problem hiding this comment.
можешь в user_create добавить аргументом user_create_data и удалить вторую функцию
меньше копипаста
Member
There was a problem hiding this comment.
переименовать бы в create_user
хз почему у нас такое название завелось но это неправильно)
CollaboratorAuthor
There was a problem hiding this comment.
поправил названия функций + вынес в TestUtils.
| user.save() | ||
| return user | ||
| def project_create(self, user): |
Member
There was a problem hiding this comment.
лучше переименовать в create_project
во вторых эти utils функции нужно куда то вынести из тест кейса, по хорошему user_create тоже вынести
| ) | ||
| return project | ||
| def vacancy_create(self, project): |
yakser
self-requested a review
December 12, 2023 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Краткое название
new tests for vacancy
Описание изменений
Добавил тесты на отклик на вакансию/ принятие отклика/ отклонение отклика/ удаление вакансии от владельца проекта/ пользователя/неавторизованного пользователя