Uh oh!
There was an error while loading. Please reload this page.
chore(test): set MySQL's secure-file-priv="" option in the command instead of conf file - #2359
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
eitsupi
marked this pull request as ready for review
March 31, 2023 13:46
secure-file-priv="" option in the command instead of conf filemax-sixty
commented
Mar 31, 2023
Member
Nice! |
max-sixty pushed a commit
to max-sixty/prql
that referenced
this pull request
Apr 2, 2023
…instead of conf file (PRQL#2359) * chore(test): remove unused mysql conf file * fix: pass `--secure-file-priv=""` via compose file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
secure-file-priv=""needs to be set in the mysql container, but since it can be set with the command used when the container is created without using the configuration file, so remove the configuration file and the command is specified in the compose file.