Skip to content

chore: bump sqlparser from 0.60.0 to 0.62.0 - #5921

Merged
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0
May 19, 2026
Merged

chore: bump sqlparser from 0.60.0 to 0.62.0#5921
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMay 19, 2026

Copy link
Copy Markdown
Contributor

Bumps sqlparser from 0.60.0 to 0.62.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabotdependabotBot added dependencies rust Pull requests that update Rust code labels May 19, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails — cargo check/cargo build reports 9 errors in prqlc against sqlparser 0.62 (build-prqlc Windows log). The bump skips 0.61, so several upstream AST changes land at once. Summary so a maintainer can scope the follow-up:

WhereChange in 0.61/0.62
prqlc/prqlc/src/sql/gen_projection.rs:222ExcludeSelectItem::Multiple now takes Vec<ObjectName>, not Vec<Ident>.
prqlc/prqlc/src/sql/gen_query.rs:390, :712TableFactor::Derived gained a required sample field.
prqlc/prqlc/src/sql/gen_query.rs:643 (default_select)Select gained required optimizer_hints and select_modifiers fields.
prqlc/prqlc/src/sql/gen_query.rs:661connect_by is now Vec<ConnectByKind>, no longer Option<_>.
prqlc/prqlc/src/sql/gen_query.rs:670, :678 (simple_table_alias, cte_table_alias)TableAlias gained a required at field.
prqlc/prqlc/src/semantic/lowering.rs:1072, prqlc/prqlc/src/sql/gen_query.rs:743New SelectItem::ExprWithAliases variant — both matches are now non-exhaustive.

The structural additions (sample, at, optimizer_hints, select_modifiers, connect_by) look like mechanical defaults (None / vec![]). The remaining two need a small judgment call:

  • ExcludeSelectItem::Multiple wants ObjectNames — needs wrapping the existing Idents rather than just changing a type.
  • SelectItem::ExprWithAliases (introduced in apache/datafusion-sqlparser-rs#2295, SELECT x AS (a, b)) only comes from parsed SQL — not constructed by prqlc — so both call sites can reasonably reject it as unsupported, matching how lowering.rs:1077 already rejects non-Ident projection exprs.

test-msrv and the cross-binding failures (test-java, test-js, test-python, test-php, test-elixir) look like cascades from the same compile errors — sqlparser 0.62 doesn't declare an MSRV bump (rust-version: unknown on crates.io), so fixing the compile errors should unblock them. Worth re-checking after the fix lands.

Not approving — the version bump on its own won't compile and needs the prqlc-side updates above.

@max-sixty

Copy link
Copy Markdown
Member

@prql-bot Please implement the sqlparser 0.62 migration you scoped in your review and push it to this branch so CI goes green. For the two judgment calls: wrap the existing Idents in ObjectName for ExcludeSelectItem::Multiple, and reject SelectItem::ExprWithAliases as unsupported (matching how lowering.rs already rejects non-Ident projection exprs), as you suggested. Rebase onto the latest main first if the branch is behind.

This was written by Claude Code on behalf of Maximilian Roos

dependabotBotand others added 2 commits May 19, 2026 16:58
Bumps [sqlparser](https://github.com/apache/datafusion-sqlparser-rs) from 0.60.0 to 0.62.0.
- [Changelog](https://github.com/apache/datafusion-sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](apache/datafusion-sqlparser-rs@v0.60.0...v0.62.0)
---
updated-dependencies:
- dependency-name: sqlparser
dependency-version: 0.62.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Wrap excluded `Ident`s in `ObjectName` for the new
`ExcludeSelectItem::Multiple(Vec<ObjectName>)` shape, populate the new
required fields on `Select` (`optimizer_hints`, `select_modifiers`),
`TableFactor::Derived` (`sample`), and `TableAlias` (`at`), switch
`Select::connect_by` from `Option` to `Vec`, and reject the new
`SelectItem::ExprWithAliases` variant — only produced by parsed SQL,
never constructed by prqlc — matching how `lowering.rs` already rejects
non-`Ident` projection exprs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@prql-bot
prql-botforce-pushed the dependabot/cargo/sqlparser-0.62.0 branch from 24360d0 to 762a460CompareMay 19, 2026 17:15

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the migration against the sqlparser 0.62 source — new Select (optimizer_hints, select_modifiers), TableFactor::Derived (sample), TableAlias (at), and Select::connect_by field/variant shapes all match, and the SelectItem::ExprWithAliases rejection in lowering.rs (reachable via parsed SQL in s-strings) and unreachable! in gen_query.rs (called only on prqlc-constructed projections) are both sound.

One small cleanup: sqlparser provides impl From<Ident> for ObjectName at ast/mod.rs:403, so the manual ObjectName(vec![ObjectNamePart::Identifier(ident)]) block can collapse via .map(ObjectName::from).

Leaving the verdict to CI / a human — this is a self-authored fix on top of a dependabot bump, so no auto-approval from me.

Comment threadprqlc/prqlc/src/sql/gen_projection.rs Outdated
sqlparser 0.62 uses `core::error::Error` (stabilized in Rust 1.81), so
the workspace MSRV must move from 1.75 to 1.81. Also collapse the
single-line closure that rustfmt expects on one line.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty

Copy link
Copy Markdown
Member

@prql-bot This is a Dependabot PR with no human author — please don't just re-review, implement the sqlparser 0.62 migration and push a commit to this branch. You already scoped it precisely: apply the 5 mechanical default fields, wrap the Idents in ObjectName for ExcludeSelectItem::Multiple, and add an Err(...) arm for the new SelectItem::ExprWithAliases variant (consistent with how the surrounding code already rejects unsupported projection exprs). Rebase onto the latest main first, then push so CI can go green.

This was written by Claude Code on behalf of Maximilian Roos

prql-botand others added 2 commits May 19, 2026 18:02
Rust 1.94's clippy enforces `manual_inspect`, which flagged a `.map`
that only side-effects (debug logging) and returns the same value.
Switch to `.inspect` to satisfy the lint with no behavior change.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sqlparser provides `impl From<Ident> for ObjectName` that constructs
exactly `ObjectName(vec![ObjectNamePart::Identifier(ident)])`, so the
manual wrap can collapse to `.map(ObjectName::from)`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty
max-sixty merged commit b11de3d into mainMay 19, 2026
80 of 81 checks passed
@max-sixty
max-sixty deleted the dependabot/cargo/sqlparser-0.62.0 branch May 19, 2026 19:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesrustPull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-sixty@prql-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore: bump sqlparser from 0.60.0 to 0.62.0 by dependabot[bot] · Pull Request #5921 · PRQL/prql · GitHub
Skip to content

chore: bump sqlparser from 0.60.0 to 0.62.0 - #5921

Merged
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0
May 19, 2026
Merged

chore: bump sqlparser from 0.60.0 to 0.62.0#5921
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMay 19, 2026

Copy link
Copy Markdown
Contributor

Bumps sqlparser from 0.60.0 to 0.62.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabotdependabotBot added dependencies rust Pull requests that update Rust code labels May 19, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails — cargo check/cargo build reports 9 errors in prqlc against sqlparser 0.62 (build-prqlc Windows log). The bump skips 0.61, so several upstream AST changes land at once. Summary so a maintainer can scope the follow-up:

WhereChange in 0.61/0.62
prqlc/prqlc/src/sql/gen_projection.rs:222ExcludeSelectItem::Multiple now takes Vec<ObjectName>, not Vec<Ident>.
prqlc/prqlc/src/sql/gen_query.rs:390, :712TableFactor::Derived gained a required sample field.
prqlc/prqlc/src/sql/gen_query.rs:643 (default_select)Select gained required optimizer_hints and select_modifiers fields.
prqlc/prqlc/src/sql/gen_query.rs:661connect_by is now Vec<ConnectByKind>, no longer Option<_>.
prqlc/prqlc/src/sql/gen_query.rs:670, :678 (simple_table_alias, cte_table_alias)TableAlias gained a required at field.
prqlc/prqlc/src/semantic/lowering.rs:1072, prqlc/prqlc/src/sql/gen_query.rs:743New SelectItem::ExprWithAliases variant — both matches are now non-exhaustive.

The structural additions (sample, at, optimizer_hints, select_modifiers, connect_by) look like mechanical defaults (None / vec![]). The remaining two need a small judgment call:

  • ExcludeSelectItem::Multiple wants ObjectNames — needs wrapping the existing Idents rather than just changing a type.
  • SelectItem::ExprWithAliases (introduced in apache/datafusion-sqlparser-rs#2295, SELECT x AS (a, b)) only comes from parsed SQL — not constructed by prqlc — so both call sites can reasonably reject it as unsupported, matching how lowering.rs:1077 already rejects non-Ident projection exprs.

test-msrv and the cross-binding failures (test-java, test-js, test-python, test-php, test-elixir) look like cascades from the same compile errors — sqlparser 0.62 doesn't declare an MSRV bump (rust-version: unknown on crates.io), so fixing the compile errors should unblock them. Worth re-checking after the fix lands.

Not approving — the version bump on its own won't compile and needs the prqlc-side updates above.

@max-sixty

Copy link
Copy Markdown
Member

@prql-bot Please implement the sqlparser 0.62 migration you scoped in your review and push it to this branch so CI goes green. For the two judgment calls: wrap the existing Idents in ObjectName for ExcludeSelectItem::Multiple, and reject SelectItem::ExprWithAliases as unsupported (matching how lowering.rs already rejects non-Ident projection exprs), as you suggested. Rebase onto the latest main first if the branch is behind.

This was written by Claude Code on behalf of Maximilian Roos

dependabotBotand others added 2 commits May 19, 2026 16:58
Bumps [sqlparser](https://github.com/apache/datafusion-sqlparser-rs) from 0.60.0 to 0.62.0.
- [Changelog](https://github.com/apache/datafusion-sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](apache/datafusion-sqlparser-rs@v0.60.0...v0.62.0)
---
updated-dependencies:
- dependency-name: sqlparser
dependency-version: 0.62.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Wrap excluded `Ident`s in `ObjectName` for the new
`ExcludeSelectItem::Multiple(Vec<ObjectName>)` shape, populate the new
required fields on `Select` (`optimizer_hints`, `select_modifiers`),
`TableFactor::Derived` (`sample`), and `TableAlias` (`at`), switch
`Select::connect_by` from `Option` to `Vec`, and reject the new
`SelectItem::ExprWithAliases` variant — only produced by parsed SQL,
never constructed by prqlc — matching how `lowering.rs` already rejects
non-`Ident` projection exprs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@prql-bot
prql-botforce-pushed the dependabot/cargo/sqlparser-0.62.0 branch from 24360d0 to 762a460CompareMay 19, 2026 17:15

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the migration against the sqlparser 0.62 source — new Select (optimizer_hints, select_modifiers), TableFactor::Derived (sample), TableAlias (at), and Select::connect_by field/variant shapes all match, and the SelectItem::ExprWithAliases rejection in lowering.rs (reachable via parsed SQL in s-strings) and unreachable! in gen_query.rs (called only on prqlc-constructed projections) are both sound.

One small cleanup: sqlparser provides impl From<Ident> for ObjectName at ast/mod.rs:403, so the manual ObjectName(vec![ObjectNamePart::Identifier(ident)]) block can collapse via .map(ObjectName::from).

Leaving the verdict to CI / a human — this is a self-authored fix on top of a dependabot bump, so no auto-approval from me.

Comment threadprqlc/prqlc/src/sql/gen_projection.rs Outdated
sqlparser 0.62 uses `core::error::Error` (stabilized in Rust 1.81), so
the workspace MSRV must move from 1.75 to 1.81. Also collapse the
single-line closure that rustfmt expects on one line.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty

Copy link
Copy Markdown
Member

@prql-bot This is a Dependabot PR with no human author — please don't just re-review, implement the sqlparser 0.62 migration and push a commit to this branch. You already scoped it precisely: apply the 5 mechanical default fields, wrap the Idents in ObjectName for ExcludeSelectItem::Multiple, and add an Err(...) arm for the new SelectItem::ExprWithAliases variant (consistent with how the surrounding code already rejects unsupported projection exprs). Rebase onto the latest main first, then push so CI can go green.

This was written by Claude Code on behalf of Maximilian Roos

prql-botand others added 2 commits May 19, 2026 18:02
Rust 1.94's clippy enforces `manual_inspect`, which flagged a `.map`
that only side-effects (debug logging) and returns the same value.
Switch to `.inspect` to satisfy the lint with no behavior change.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sqlparser provides `impl From<Ident> for ObjectName` that constructs
exactly `ObjectName(vec![ObjectNamePart::Identifier(ident)])`, so the
manual wrap can collapse to `.map(ObjectName::from)`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty
max-sixty merged commit b11de3d into mainMay 19, 2026
80 of 81 checks passed
@max-sixty
max-sixty deleted the dependabot/cargo/sqlparser-0.62.0 branch May 19, 2026 19:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesrustPull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-sixty@prql-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: bump sqlparser from 0.60.0 to 0.62.0 by dependabot[bot] · Pull Request #5921 · PRQL/prql · GitHub
Skip to content

chore: bump sqlparser from 0.60.0 to 0.62.0 - #5921

Merged
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0
May 19, 2026
Merged

chore: bump sqlparser from 0.60.0 to 0.62.0#5921
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMay 19, 2026

Copy link
Copy Markdown
Contributor

Bumps sqlparser from 0.60.0 to 0.62.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabotdependabotBot added dependencies rust Pull requests that update Rust code labels May 19, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails — cargo check/cargo build reports 9 errors in prqlc against sqlparser 0.62 (build-prqlc Windows log). The bump skips 0.61, so several upstream AST changes land at once. Summary so a maintainer can scope the follow-up:

WhereChange in 0.61/0.62
prqlc/prqlc/src/sql/gen_projection.rs:222ExcludeSelectItem::Multiple now takes Vec<ObjectName>, not Vec<Ident>.
prqlc/prqlc/src/sql/gen_query.rs:390, :712TableFactor::Derived gained a required sample field.
prqlc/prqlc/src/sql/gen_query.rs:643 (default_select)Select gained required optimizer_hints and select_modifiers fields.
prqlc/prqlc/src/sql/gen_query.rs:661connect_by is now Vec<ConnectByKind>, no longer Option<_>.
prqlc/prqlc/src/sql/gen_query.rs:670, :678 (simple_table_alias, cte_table_alias)TableAlias gained a required at field.
prqlc/prqlc/src/semantic/lowering.rs:1072, prqlc/prqlc/src/sql/gen_query.rs:743New SelectItem::ExprWithAliases variant — both matches are now non-exhaustive.

The structural additions (sample, at, optimizer_hints, select_modifiers, connect_by) look like mechanical defaults (None / vec![]). The remaining two need a small judgment call:

  • ExcludeSelectItem::Multiple wants ObjectNames — needs wrapping the existing Idents rather than just changing a type.
  • SelectItem::ExprWithAliases (introduced in apache/datafusion-sqlparser-rs#2295, SELECT x AS (a, b)) only comes from parsed SQL — not constructed by prqlc — so both call sites can reasonably reject it as unsupported, matching how lowering.rs:1077 already rejects non-Ident projection exprs.

test-msrv and the cross-binding failures (test-java, test-js, test-python, test-php, test-elixir) look like cascades from the same compile errors — sqlparser 0.62 doesn't declare an MSRV bump (rust-version: unknown on crates.io), so fixing the compile errors should unblock them. Worth re-checking after the fix lands.

Not approving — the version bump on its own won't compile and needs the prqlc-side updates above.

@max-sixty

Copy link
Copy Markdown
Member

@prql-bot Please implement the sqlparser 0.62 migration you scoped in your review and push it to this branch so CI goes green. For the two judgment calls: wrap the existing Idents in ObjectName for ExcludeSelectItem::Multiple, and reject SelectItem::ExprWithAliases as unsupported (matching how lowering.rs already rejects non-Ident projection exprs), as you suggested. Rebase onto the latest main first if the branch is behind.

This was written by Claude Code on behalf of Maximilian Roos

dependabotBotand others added 2 commits May 19, 2026 16:58
Bumps [sqlparser](https://github.com/apache/datafusion-sqlparser-rs) from 0.60.0 to 0.62.0.
- [Changelog](https://github.com/apache/datafusion-sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](apache/datafusion-sqlparser-rs@v0.60.0...v0.62.0)
---
updated-dependencies:
- dependency-name: sqlparser
dependency-version: 0.62.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Wrap excluded `Ident`s in `ObjectName` for the new
`ExcludeSelectItem::Multiple(Vec<ObjectName>)` shape, populate the new
required fields on `Select` (`optimizer_hints`, `select_modifiers`),
`TableFactor::Derived` (`sample`), and `TableAlias` (`at`), switch
`Select::connect_by` from `Option` to `Vec`, and reject the new
`SelectItem::ExprWithAliases` variant — only produced by parsed SQL,
never constructed by prqlc — matching how `lowering.rs` already rejects
non-`Ident` projection exprs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@prql-bot
prql-botforce-pushed the dependabot/cargo/sqlparser-0.62.0 branch from 24360d0 to 762a460CompareMay 19, 2026 17:15

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the migration against the sqlparser 0.62 source — new Select (optimizer_hints, select_modifiers), TableFactor::Derived (sample), TableAlias (at), and Select::connect_by field/variant shapes all match, and the SelectItem::ExprWithAliases rejection in lowering.rs (reachable via parsed SQL in s-strings) and unreachable! in gen_query.rs (called only on prqlc-constructed projections) are both sound.

One small cleanup: sqlparser provides impl From<Ident> for ObjectName at ast/mod.rs:403, so the manual ObjectName(vec![ObjectNamePart::Identifier(ident)]) block can collapse via .map(ObjectName::from).

Leaving the verdict to CI / a human — this is a self-authored fix on top of a dependabot bump, so no auto-approval from me.

Comment threadprqlc/prqlc/src/sql/gen_projection.rs Outdated
sqlparser 0.62 uses `core::error::Error` (stabilized in Rust 1.81), so
the workspace MSRV must move from 1.75 to 1.81. Also collapse the
single-line closure that rustfmt expects on one line.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty

Copy link
Copy Markdown
Member

@prql-bot This is a Dependabot PR with no human author — please don't just re-review, implement the sqlparser 0.62 migration and push a commit to this branch. You already scoped it precisely: apply the 5 mechanical default fields, wrap the Idents in ObjectName for ExcludeSelectItem::Multiple, and add an Err(...) arm for the new SelectItem::ExprWithAliases variant (consistent with how the surrounding code already rejects unsupported projection exprs). Rebase onto the latest main first, then push so CI can go green.

This was written by Claude Code on behalf of Maximilian Roos

prql-botand others added 2 commits May 19, 2026 18:02
Rust 1.94's clippy enforces `manual_inspect`, which flagged a `.map`
that only side-effects (debug logging) and returns the same value.
Switch to `.inspect` to satisfy the lint with no behavior change.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sqlparser provides `impl From<Ident> for ObjectName` that constructs
exactly `ObjectName(vec![ObjectNamePart::Identifier(ident)])`, so the
manual wrap can collapse to `.map(ObjectName::from)`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty
max-sixty merged commit b11de3d into mainMay 19, 2026
80 of 81 checks passed
@max-sixty
max-sixty deleted the dependabot/cargo/sqlparser-0.62.0 branch May 19, 2026 19:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesrustPull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-sixty@prql-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: bump sqlparser from 0.60.0 to 0.62.0 by dependabot[bot] · Pull Request #5921 · PRQL/prql · GitHub
Skip to content

chore: bump sqlparser from 0.60.0 to 0.62.0 - #5921

Merged
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0
May 19, 2026
Merged

chore: bump sqlparser from 0.60.0 to 0.62.0#5921
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMay 19, 2026

Copy link
Copy Markdown
Contributor

Bumps sqlparser from 0.60.0 to 0.62.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabotdependabotBot added dependencies rust Pull requests that update Rust code labels May 19, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails — cargo check/cargo build reports 9 errors in prqlc against sqlparser 0.62 (build-prqlc Windows log). The bump skips 0.61, so several upstream AST changes land at once. Summary so a maintainer can scope the follow-up:

WhereChange in 0.61/0.62
prqlc/prqlc/src/sql/gen_projection.rs:222ExcludeSelectItem::Multiple now takes Vec<ObjectName>, not Vec<Ident>.
prqlc/prqlc/src/sql/gen_query.rs:390, :712TableFactor::Derived gained a required sample field.
prqlc/prqlc/src/sql/gen_query.rs:643 (default_select)Select gained required optimizer_hints and select_modifiers fields.
prqlc/prqlc/src/sql/gen_query.rs:661connect_by is now Vec<ConnectByKind>, no longer Option<_>.
prqlc/prqlc/src/sql/gen_query.rs:670, :678 (simple_table_alias, cte_table_alias)TableAlias gained a required at field.
prqlc/prqlc/src/semantic/lowering.rs:1072, prqlc/prqlc/src/sql/gen_query.rs:743New SelectItem::ExprWithAliases variant — both matches are now non-exhaustive.

The structural additions (sample, at, optimizer_hints, select_modifiers, connect_by) look like mechanical defaults (None / vec![]). The remaining two need a small judgment call:

  • ExcludeSelectItem::Multiple wants ObjectNames — needs wrapping the existing Idents rather than just changing a type.
  • SelectItem::ExprWithAliases (introduced in apache/datafusion-sqlparser-rs#2295, SELECT x AS (a, b)) only comes from parsed SQL — not constructed by prqlc — so both call sites can reasonably reject it as unsupported, matching how lowering.rs:1077 already rejects non-Ident projection exprs.

test-msrv and the cross-binding failures (test-java, test-js, test-python, test-php, test-elixir) look like cascades from the same compile errors — sqlparser 0.62 doesn't declare an MSRV bump (rust-version: unknown on crates.io), so fixing the compile errors should unblock them. Worth re-checking after the fix lands.

Not approving — the version bump on its own won't compile and needs the prqlc-side updates above.

@max-sixty

Copy link
Copy Markdown
Member

@prql-bot Please implement the sqlparser 0.62 migration you scoped in your review and push it to this branch so CI goes green. For the two judgment calls: wrap the existing Idents in ObjectName for ExcludeSelectItem::Multiple, and reject SelectItem::ExprWithAliases as unsupported (matching how lowering.rs already rejects non-Ident projection exprs), as you suggested. Rebase onto the latest main first if the branch is behind.

This was written by Claude Code on behalf of Maximilian Roos

dependabotBotand others added 2 commits May 19, 2026 16:58
Bumps [sqlparser](https://github.com/apache/datafusion-sqlparser-rs) from 0.60.0 to 0.62.0.
- [Changelog](https://github.com/apache/datafusion-sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](apache/datafusion-sqlparser-rs@v0.60.0...v0.62.0)
---
updated-dependencies:
- dependency-name: sqlparser
dependency-version: 0.62.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Wrap excluded `Ident`s in `ObjectName` for the new
`ExcludeSelectItem::Multiple(Vec<ObjectName>)` shape, populate the new
required fields on `Select` (`optimizer_hints`, `select_modifiers`),
`TableFactor::Derived` (`sample`), and `TableAlias` (`at`), switch
`Select::connect_by` from `Option` to `Vec`, and reject the new
`SelectItem::ExprWithAliases` variant — only produced by parsed SQL,
never constructed by prqlc — matching how `lowering.rs` already rejects
non-`Ident` projection exprs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@prql-bot
prql-botforce-pushed the dependabot/cargo/sqlparser-0.62.0 branch from 24360d0 to 762a460CompareMay 19, 2026 17:15

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the migration against the sqlparser 0.62 source — new Select (optimizer_hints, select_modifiers), TableFactor::Derived (sample), TableAlias (at), and Select::connect_by field/variant shapes all match, and the SelectItem::ExprWithAliases rejection in lowering.rs (reachable via parsed SQL in s-strings) and unreachable! in gen_query.rs (called only on prqlc-constructed projections) are both sound.

One small cleanup: sqlparser provides impl From<Ident> for ObjectName at ast/mod.rs:403, so the manual ObjectName(vec![ObjectNamePart::Identifier(ident)]) block can collapse via .map(ObjectName::from).

Leaving the verdict to CI / a human — this is a self-authored fix on top of a dependabot bump, so no auto-approval from me.

Comment threadprqlc/prqlc/src/sql/gen_projection.rs Outdated
sqlparser 0.62 uses `core::error::Error` (stabilized in Rust 1.81), so
the workspace MSRV must move from 1.75 to 1.81. Also collapse the
single-line closure that rustfmt expects on one line.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty

Copy link
Copy Markdown
Member

@prql-bot This is a Dependabot PR with no human author — please don't just re-review, implement the sqlparser 0.62 migration and push a commit to this branch. You already scoped it precisely: apply the 5 mechanical default fields, wrap the Idents in ObjectName for ExcludeSelectItem::Multiple, and add an Err(...) arm for the new SelectItem::ExprWithAliases variant (consistent with how the surrounding code already rejects unsupported projection exprs). Rebase onto the latest main first, then push so CI can go green.

This was written by Claude Code on behalf of Maximilian Roos

prql-botand others added 2 commits May 19, 2026 18:02
Rust 1.94's clippy enforces `manual_inspect`, which flagged a `.map`
that only side-effects (debug logging) and returns the same value.
Switch to `.inspect` to satisfy the lint with no behavior change.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sqlparser provides `impl From<Ident> for ObjectName` that constructs
exactly `ObjectName(vec![ObjectNamePart::Identifier(ident)])`, so the
manual wrap can collapse to `.map(ObjectName::from)`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty
max-sixty merged commit b11de3d into mainMay 19, 2026
80 of 81 checks passed
@max-sixty
max-sixty deleted the dependabot/cargo/sqlparser-0.62.0 branch May 19, 2026 19:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesrustPull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-sixty@prql-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' chore: bump sqlparser from 0.60.0 to 0.62.0 by dependabot[bot] · Pull Request #5921 · PRQL/prql · GitHub
Skip to content

chore: bump sqlparser from 0.60.0 to 0.62.0 - #5921

Merged
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0
May 19, 2026
Merged

chore: bump sqlparser from 0.60.0 to 0.62.0#5921
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMay 19, 2026

Copy link
Copy Markdown
Contributor

Bumps sqlparser from 0.60.0 to 0.62.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabotdependabotBot added dependencies rust Pull requests that update Rust code labels May 19, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails — cargo check/cargo build reports 9 errors in prqlc against sqlparser 0.62 (build-prqlc Windows log). The bump skips 0.61, so several upstream AST changes land at once. Summary so a maintainer can scope the follow-up:

WhereChange in 0.61/0.62
prqlc/prqlc/src/sql/gen_projection.rs:222ExcludeSelectItem::Multiple now takes Vec<ObjectName>, not Vec<Ident>.
prqlc/prqlc/src/sql/gen_query.rs:390, :712TableFactor::Derived gained a required sample field.
prqlc/prqlc/src/sql/gen_query.rs:643 (default_select)Select gained required optimizer_hints and select_modifiers fields.
prqlc/prqlc/src/sql/gen_query.rs:661connect_by is now Vec<ConnectByKind>, no longer Option<_>.
prqlc/prqlc/src/sql/gen_query.rs:670, :678 (simple_table_alias, cte_table_alias)TableAlias gained a required at field.
prqlc/prqlc/src/semantic/lowering.rs:1072, prqlc/prqlc/src/sql/gen_query.rs:743New SelectItem::ExprWithAliases variant — both matches are now non-exhaustive.

The structural additions (sample, at, optimizer_hints, select_modifiers, connect_by) look like mechanical defaults (None / vec![]). The remaining two need a small judgment call:

  • ExcludeSelectItem::Multiple wants ObjectNames — needs wrapping the existing Idents rather than just changing a type.
  • SelectItem::ExprWithAliases (introduced in apache/datafusion-sqlparser-rs#2295, SELECT x AS (a, b)) only comes from parsed SQL — not constructed by prqlc — so both call sites can reasonably reject it as unsupported, matching how lowering.rs:1077 already rejects non-Ident projection exprs.

test-msrv and the cross-binding failures (test-java, test-js, test-python, test-php, test-elixir) look like cascades from the same compile errors — sqlparser 0.62 doesn't declare an MSRV bump (rust-version: unknown on crates.io), so fixing the compile errors should unblock them. Worth re-checking after the fix lands.

Not approving — the version bump on its own won't compile and needs the prqlc-side updates above.

@max-sixty

Copy link
Copy Markdown
Member

@prql-bot Please implement the sqlparser 0.62 migration you scoped in your review and push it to this branch so CI goes green. For the two judgment calls: wrap the existing Idents in ObjectName for ExcludeSelectItem::Multiple, and reject SelectItem::ExprWithAliases as unsupported (matching how lowering.rs already rejects non-Ident projection exprs), as you suggested. Rebase onto the latest main first if the branch is behind.

This was written by Claude Code on behalf of Maximilian Roos

dependabotBotand others added 2 commits May 19, 2026 16:58
Bumps [sqlparser](https://github.com/apache/datafusion-sqlparser-rs) from 0.60.0 to 0.62.0.
- [Changelog](https://github.com/apache/datafusion-sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](apache/datafusion-sqlparser-rs@v0.60.0...v0.62.0)
---
updated-dependencies:
- dependency-name: sqlparser
dependency-version: 0.62.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Wrap excluded `Ident`s in `ObjectName` for the new
`ExcludeSelectItem::Multiple(Vec<ObjectName>)` shape, populate the new
required fields on `Select` (`optimizer_hints`, `select_modifiers`),
`TableFactor::Derived` (`sample`), and `TableAlias` (`at`), switch
`Select::connect_by` from `Option` to `Vec`, and reject the new
`SelectItem::ExprWithAliases` variant — only produced by parsed SQL,
never constructed by prqlc — matching how `lowering.rs` already rejects
non-`Ident` projection exprs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@prql-bot
prql-botforce-pushed the dependabot/cargo/sqlparser-0.62.0 branch from 24360d0 to 762a460CompareMay 19, 2026 17:15

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the migration against the sqlparser 0.62 source — new Select (optimizer_hints, select_modifiers), TableFactor::Derived (sample), TableAlias (at), and Select::connect_by field/variant shapes all match, and the SelectItem::ExprWithAliases rejection in lowering.rs (reachable via parsed SQL in s-strings) and unreachable! in gen_query.rs (called only on prqlc-constructed projections) are both sound.

One small cleanup: sqlparser provides impl From<Ident> for ObjectName at ast/mod.rs:403, so the manual ObjectName(vec![ObjectNamePart::Identifier(ident)]) block can collapse via .map(ObjectName::from).

Leaving the verdict to CI / a human — this is a self-authored fix on top of a dependabot bump, so no auto-approval from me.

Comment threadprqlc/prqlc/src/sql/gen_projection.rs Outdated
sqlparser 0.62 uses `core::error::Error` (stabilized in Rust 1.81), so
the workspace MSRV must move from 1.75 to 1.81. Also collapse the
single-line closure that rustfmt expects on one line.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty

Copy link
Copy Markdown
Member

@prql-bot This is a Dependabot PR with no human author — please don't just re-review, implement the sqlparser 0.62 migration and push a commit to this branch. You already scoped it precisely: apply the 5 mechanical default fields, wrap the Idents in ObjectName for ExcludeSelectItem::Multiple, and add an Err(...) arm for the new SelectItem::ExprWithAliases variant (consistent with how the surrounding code already rejects unsupported projection exprs). Rebase onto the latest main first, then push so CI can go green.

This was written by Claude Code on behalf of Maximilian Roos

prql-botand others added 2 commits May 19, 2026 18:02
Rust 1.94's clippy enforces `manual_inspect`, which flagged a `.map`
that only side-effects (debug logging) and returns the same value.
Switch to `.inspect` to satisfy the lint with no behavior change.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sqlparser provides `impl From<Ident> for ObjectName` that constructs
exactly `ObjectName(vec![ObjectNamePart::Identifier(ident)])`, so the
manual wrap can collapse to `.map(ObjectName::from)`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty
max-sixty merged commit b11de3d into mainMay 19, 2026
80 of 81 checks passed
@max-sixty
max-sixty deleted the dependabot/cargo/sqlparser-0.62.0 branch May 19, 2026 19:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesrustPull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-sixty@prql-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: bump sqlparser from 0.60.0 to 0.62.0 by dependabot[bot] · Pull Request #5921 · PRQL/prql · GitHub
Skip to content

chore: bump sqlparser from 0.60.0 to 0.62.0 - #5921

Merged
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0
May 19, 2026
Merged

chore: bump sqlparser from 0.60.0 to 0.62.0#5921
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMay 19, 2026

Copy link
Copy Markdown
Contributor

Bumps sqlparser from 0.60.0 to 0.62.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabotdependabotBot added dependencies rust Pull requests that update Rust code labels May 19, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails — cargo check/cargo build reports 9 errors in prqlc against sqlparser 0.62 (build-prqlc Windows log). The bump skips 0.61, so several upstream AST changes land at once. Summary so a maintainer can scope the follow-up:

WhereChange in 0.61/0.62
prqlc/prqlc/src/sql/gen_projection.rs:222ExcludeSelectItem::Multiple now takes Vec<ObjectName>, not Vec<Ident>.
prqlc/prqlc/src/sql/gen_query.rs:390, :712TableFactor::Derived gained a required sample field.
prqlc/prqlc/src/sql/gen_query.rs:643 (default_select)Select gained required optimizer_hints and select_modifiers fields.
prqlc/prqlc/src/sql/gen_query.rs:661connect_by is now Vec<ConnectByKind>, no longer Option<_>.
prqlc/prqlc/src/sql/gen_query.rs:670, :678 (simple_table_alias, cte_table_alias)TableAlias gained a required at field.
prqlc/prqlc/src/semantic/lowering.rs:1072, prqlc/prqlc/src/sql/gen_query.rs:743New SelectItem::ExprWithAliases variant — both matches are now non-exhaustive.

The structural additions (sample, at, optimizer_hints, select_modifiers, connect_by) look like mechanical defaults (None / vec![]). The remaining two need a small judgment call:

  • ExcludeSelectItem::Multiple wants ObjectNames — needs wrapping the existing Idents rather than just changing a type.
  • SelectItem::ExprWithAliases (introduced in apache/datafusion-sqlparser-rs#2295, SELECT x AS (a, b)) only comes from parsed SQL — not constructed by prqlc — so both call sites can reasonably reject it as unsupported, matching how lowering.rs:1077 already rejects non-Ident projection exprs.

test-msrv and the cross-binding failures (test-java, test-js, test-python, test-php, test-elixir) look like cascades from the same compile errors — sqlparser 0.62 doesn't declare an MSRV bump (rust-version: unknown on crates.io), so fixing the compile errors should unblock them. Worth re-checking after the fix lands.

Not approving — the version bump on its own won't compile and needs the prqlc-side updates above.

@max-sixty

Copy link
Copy Markdown
Member

@prql-bot Please implement the sqlparser 0.62 migration you scoped in your review and push it to this branch so CI goes green. For the two judgment calls: wrap the existing Idents in ObjectName for ExcludeSelectItem::Multiple, and reject SelectItem::ExprWithAliases as unsupported (matching how lowering.rs already rejects non-Ident projection exprs), as you suggested. Rebase onto the latest main first if the branch is behind.

This was written by Claude Code on behalf of Maximilian Roos

dependabotBotand others added 2 commits May 19, 2026 16:58
Bumps [sqlparser](https://github.com/apache/datafusion-sqlparser-rs) from 0.60.0 to 0.62.0.
- [Changelog](https://github.com/apache/datafusion-sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](apache/datafusion-sqlparser-rs@v0.60.0...v0.62.0)
---
updated-dependencies:
- dependency-name: sqlparser
dependency-version: 0.62.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Wrap excluded `Ident`s in `ObjectName` for the new
`ExcludeSelectItem::Multiple(Vec<ObjectName>)` shape, populate the new
required fields on `Select` (`optimizer_hints`, `select_modifiers`),
`TableFactor::Derived` (`sample`), and `TableAlias` (`at`), switch
`Select::connect_by` from `Option` to `Vec`, and reject the new
`SelectItem::ExprWithAliases` variant — only produced by parsed SQL,
never constructed by prqlc — matching how `lowering.rs` already rejects
non-`Ident` projection exprs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@prql-bot
prql-botforce-pushed the dependabot/cargo/sqlparser-0.62.0 branch from 24360d0 to 762a460CompareMay 19, 2026 17:15

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the migration against the sqlparser 0.62 source — new Select (optimizer_hints, select_modifiers), TableFactor::Derived (sample), TableAlias (at), and Select::connect_by field/variant shapes all match, and the SelectItem::ExprWithAliases rejection in lowering.rs (reachable via parsed SQL in s-strings) and unreachable! in gen_query.rs (called only on prqlc-constructed projections) are both sound.

One small cleanup: sqlparser provides impl From<Ident> for ObjectName at ast/mod.rs:403, so the manual ObjectName(vec![ObjectNamePart::Identifier(ident)]) block can collapse via .map(ObjectName::from).

Leaving the verdict to CI / a human — this is a self-authored fix on top of a dependabot bump, so no auto-approval from me.

Comment threadprqlc/prqlc/src/sql/gen_projection.rs Outdated
sqlparser 0.62 uses `core::error::Error` (stabilized in Rust 1.81), so
the workspace MSRV must move from 1.75 to 1.81. Also collapse the
single-line closure that rustfmt expects on one line.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty

Copy link
Copy Markdown
Member

@prql-bot This is a Dependabot PR with no human author — please don't just re-review, implement the sqlparser 0.62 migration and push a commit to this branch. You already scoped it precisely: apply the 5 mechanical default fields, wrap the Idents in ObjectName for ExcludeSelectItem::Multiple, and add an Err(...) arm for the new SelectItem::ExprWithAliases variant (consistent with how the surrounding code already rejects unsupported projection exprs). Rebase onto the latest main first, then push so CI can go green.

This was written by Claude Code on behalf of Maximilian Roos

prql-botand others added 2 commits May 19, 2026 18:02
Rust 1.94's clippy enforces `manual_inspect`, which flagged a `.map`
that only side-effects (debug logging) and returns the same value.
Switch to `.inspect` to satisfy the lint with no behavior change.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sqlparser provides `impl From<Ident> for ObjectName` that constructs
exactly `ObjectName(vec![ObjectNamePart::Identifier(ident)])`, so the
manual wrap can collapse to `.map(ObjectName::from)`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty
max-sixty merged commit b11de3d into mainMay 19, 2026
80 of 81 checks passed
@max-sixty
max-sixty deleted the dependabot/cargo/sqlparser-0.62.0 branch May 19, 2026 19:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesrustPull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-sixty@prql-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: bump sqlparser from 0.60.0 to 0.62.0 by dependabot[bot] · Pull Request #5921 · PRQL/prql · GitHub
Skip to content

chore: bump sqlparser from 0.60.0 to 0.62.0 - #5921

Merged
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0
May 19, 2026
Merged

chore: bump sqlparser from 0.60.0 to 0.62.0#5921
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMay 19, 2026

Copy link
Copy Markdown
Contributor

Bumps sqlparser from 0.60.0 to 0.62.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabotdependabotBot added dependencies rust Pull requests that update Rust code labels May 19, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails — cargo check/cargo build reports 9 errors in prqlc against sqlparser 0.62 (build-prqlc Windows log). The bump skips 0.61, so several upstream AST changes land at once. Summary so a maintainer can scope the follow-up:

WhereChange in 0.61/0.62
prqlc/prqlc/src/sql/gen_projection.rs:222ExcludeSelectItem::Multiple now takes Vec<ObjectName>, not Vec<Ident>.
prqlc/prqlc/src/sql/gen_query.rs:390, :712TableFactor::Derived gained a required sample field.
prqlc/prqlc/src/sql/gen_query.rs:643 (default_select)Select gained required optimizer_hints and select_modifiers fields.
prqlc/prqlc/src/sql/gen_query.rs:661connect_by is now Vec<ConnectByKind>, no longer Option<_>.
prqlc/prqlc/src/sql/gen_query.rs:670, :678 (simple_table_alias, cte_table_alias)TableAlias gained a required at field.
prqlc/prqlc/src/semantic/lowering.rs:1072, prqlc/prqlc/src/sql/gen_query.rs:743New SelectItem::ExprWithAliases variant — both matches are now non-exhaustive.

The structural additions (sample, at, optimizer_hints, select_modifiers, connect_by) look like mechanical defaults (None / vec![]). The remaining two need a small judgment call:

  • ExcludeSelectItem::Multiple wants ObjectNames — needs wrapping the existing Idents rather than just changing a type.
  • SelectItem::ExprWithAliases (introduced in apache/datafusion-sqlparser-rs#2295, SELECT x AS (a, b)) only comes from parsed SQL — not constructed by prqlc — so both call sites can reasonably reject it as unsupported, matching how lowering.rs:1077 already rejects non-Ident projection exprs.

test-msrv and the cross-binding failures (test-java, test-js, test-python, test-php, test-elixir) look like cascades from the same compile errors — sqlparser 0.62 doesn't declare an MSRV bump (rust-version: unknown on crates.io), so fixing the compile errors should unblock them. Worth re-checking after the fix lands.

Not approving — the version bump on its own won't compile and needs the prqlc-side updates above.

@max-sixty

Copy link
Copy Markdown
Member

@prql-bot Please implement the sqlparser 0.62 migration you scoped in your review and push it to this branch so CI goes green. For the two judgment calls: wrap the existing Idents in ObjectName for ExcludeSelectItem::Multiple, and reject SelectItem::ExprWithAliases as unsupported (matching how lowering.rs already rejects non-Ident projection exprs), as you suggested. Rebase onto the latest main first if the branch is behind.

This was written by Claude Code on behalf of Maximilian Roos

dependabotBotand others added 2 commits May 19, 2026 16:58
Bumps [sqlparser](https://github.com/apache/datafusion-sqlparser-rs) from 0.60.0 to 0.62.0.
- [Changelog](https://github.com/apache/datafusion-sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](apache/datafusion-sqlparser-rs@v0.60.0...v0.62.0)
---
updated-dependencies:
- dependency-name: sqlparser
dependency-version: 0.62.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Wrap excluded `Ident`s in `ObjectName` for the new
`ExcludeSelectItem::Multiple(Vec<ObjectName>)` shape, populate the new
required fields on `Select` (`optimizer_hints`, `select_modifiers`),
`TableFactor::Derived` (`sample`), and `TableAlias` (`at`), switch
`Select::connect_by` from `Option` to `Vec`, and reject the new
`SelectItem::ExprWithAliases` variant — only produced by parsed SQL,
never constructed by prqlc — matching how `lowering.rs` already rejects
non-`Ident` projection exprs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@prql-bot
prql-botforce-pushed the dependabot/cargo/sqlparser-0.62.0 branch from 24360d0 to 762a460CompareMay 19, 2026 17:15

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the migration against the sqlparser 0.62 source — new Select (optimizer_hints, select_modifiers), TableFactor::Derived (sample), TableAlias (at), and Select::connect_by field/variant shapes all match, and the SelectItem::ExprWithAliases rejection in lowering.rs (reachable via parsed SQL in s-strings) and unreachable! in gen_query.rs (called only on prqlc-constructed projections) are both sound.

One small cleanup: sqlparser provides impl From<Ident> for ObjectName at ast/mod.rs:403, so the manual ObjectName(vec![ObjectNamePart::Identifier(ident)]) block can collapse via .map(ObjectName::from).

Leaving the verdict to CI / a human — this is a self-authored fix on top of a dependabot bump, so no auto-approval from me.

Comment threadprqlc/prqlc/src/sql/gen_projection.rs Outdated
sqlparser 0.62 uses `core::error::Error` (stabilized in Rust 1.81), so
the workspace MSRV must move from 1.75 to 1.81. Also collapse the
single-line closure that rustfmt expects on one line.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty

Copy link
Copy Markdown
Member

@prql-bot This is a Dependabot PR with no human author — please don't just re-review, implement the sqlparser 0.62 migration and push a commit to this branch. You already scoped it precisely: apply the 5 mechanical default fields, wrap the Idents in ObjectName for ExcludeSelectItem::Multiple, and add an Err(...) arm for the new SelectItem::ExprWithAliases variant (consistent with how the surrounding code already rejects unsupported projection exprs). Rebase onto the latest main first, then push so CI can go green.

This was written by Claude Code on behalf of Maximilian Roos

prql-botand others added 2 commits May 19, 2026 18:02
Rust 1.94's clippy enforces `manual_inspect`, which flagged a `.map`
that only side-effects (debug logging) and returns the same value.
Switch to `.inspect` to satisfy the lint with no behavior change.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sqlparser provides `impl From<Ident> for ObjectName` that constructs
exactly `ObjectName(vec![ObjectNamePart::Identifier(ident)])`, so the
manual wrap can collapse to `.map(ObjectName::from)`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty
max-sixty merged commit b11de3d into mainMay 19, 2026
80 of 81 checks passed
@max-sixty
max-sixty deleted the dependabot/cargo/sqlparser-0.62.0 branch May 19, 2026 19:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesrustPull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-sixty@prql-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); chore: bump sqlparser from 0.60.0 to 0.62.0 by dependabot[bot] · Pull Request #5921 · PRQL/prql · GitHub
Skip to content

chore: bump sqlparser from 0.60.0 to 0.62.0 - #5921

Merged
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0
May 19, 2026
Merged

chore: bump sqlparser from 0.60.0 to 0.62.0#5921
max-sixty merged 5 commits into
mainfrom
dependabot/cargo/sqlparser-0.62.0

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubMay 19, 2026

Copy link
Copy Markdown
Contributor

Bumps sqlparser from 0.60.0 to 0.62.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabotdependabotBot added dependencies rust Pull requests that update Rust code labels May 19, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails — cargo check/cargo build reports 9 errors in prqlc against sqlparser 0.62 (build-prqlc Windows log). The bump skips 0.61, so several upstream AST changes land at once. Summary so a maintainer can scope the follow-up:

WhereChange in 0.61/0.62
prqlc/prqlc/src/sql/gen_projection.rs:222ExcludeSelectItem::Multiple now takes Vec<ObjectName>, not Vec<Ident>.
prqlc/prqlc/src/sql/gen_query.rs:390, :712TableFactor::Derived gained a required sample field.
prqlc/prqlc/src/sql/gen_query.rs:643 (default_select)Select gained required optimizer_hints and select_modifiers fields.
prqlc/prqlc/src/sql/gen_query.rs:661connect_by is now Vec<ConnectByKind>, no longer Option<_>.
prqlc/prqlc/src/sql/gen_query.rs:670, :678 (simple_table_alias, cte_table_alias)TableAlias gained a required at field.
prqlc/prqlc/src/semantic/lowering.rs:1072, prqlc/prqlc/src/sql/gen_query.rs:743New SelectItem::ExprWithAliases variant — both matches are now non-exhaustive.

The structural additions (sample, at, optimizer_hints, select_modifiers, connect_by) look like mechanical defaults (None / vec![]). The remaining two need a small judgment call:

  • ExcludeSelectItem::Multiple wants ObjectNames — needs wrapping the existing Idents rather than just changing a type.
  • SelectItem::ExprWithAliases (introduced in apache/datafusion-sqlparser-rs#2295, SELECT x AS (a, b)) only comes from parsed SQL — not constructed by prqlc — so both call sites can reasonably reject it as unsupported, matching how lowering.rs:1077 already rejects non-Ident projection exprs.

test-msrv and the cross-binding failures (test-java, test-js, test-python, test-php, test-elixir) look like cascades from the same compile errors — sqlparser 0.62 doesn't declare an MSRV bump (rust-version: unknown on crates.io), so fixing the compile errors should unblock them. Worth re-checking after the fix lands.

Not approving — the version bump on its own won't compile and needs the prqlc-side updates above.

@max-sixty

Copy link
Copy Markdown
Member

@prql-bot Please implement the sqlparser 0.62 migration you scoped in your review and push it to this branch so CI goes green. For the two judgment calls: wrap the existing Idents in ObjectName for ExcludeSelectItem::Multiple, and reject SelectItem::ExprWithAliases as unsupported (matching how lowering.rs already rejects non-Ident projection exprs), as you suggested. Rebase onto the latest main first if the branch is behind.

This was written by Claude Code on behalf of Maximilian Roos

dependabotBotand others added 2 commits May 19, 2026 16:58
Bumps [sqlparser](https://github.com/apache/datafusion-sqlparser-rs) from 0.60.0 to 0.62.0.
- [Changelog](https://github.com/apache/datafusion-sqlparser-rs/blob/main/CHANGELOG.md)
- [Commits](apache/datafusion-sqlparser-rs@v0.60.0...v0.62.0)
---
updated-dependencies:
- dependency-name: sqlparser
dependency-version: 0.62.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Wrap excluded `Ident`s in `ObjectName` for the new
`ExcludeSelectItem::Multiple(Vec<ObjectName>)` shape, populate the new
required fields on `Select` (`optimizer_hints`, `select_modifiers`),
`TableFactor::Derived` (`sample`), and `TableAlias` (`at`), switch
`Select::connect_by` from `Option` to `Vec`, and reject the new
`SelectItem::ExprWithAliases` variant — only produced by parsed SQL,
never constructed by prqlc — matching how `lowering.rs` already rejects
non-`Ident` projection exprs.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@prql-bot
prql-botforce-pushed the dependabot/cargo/sqlparser-0.62.0 branch from 24360d0 to 762a460CompareMay 19, 2026 17:15

@prql-botprql-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the migration against the sqlparser 0.62 source — new Select (optimizer_hints, select_modifiers), TableFactor::Derived (sample), TableAlias (at), and Select::connect_by field/variant shapes all match, and the SelectItem::ExprWithAliases rejection in lowering.rs (reachable via parsed SQL in s-strings) and unreachable! in gen_query.rs (called only on prqlc-constructed projections) are both sound.

One small cleanup: sqlparser provides impl From<Ident> for ObjectName at ast/mod.rs:403, so the manual ObjectName(vec![ObjectNamePart::Identifier(ident)]) block can collapse via .map(ObjectName::from).

Leaving the verdict to CI / a human — this is a self-authored fix on top of a dependabot bump, so no auto-approval from me.

Comment threadprqlc/prqlc/src/sql/gen_projection.rs Outdated
sqlparser 0.62 uses `core::error::Error` (stabilized in Rust 1.81), so
the workspace MSRV must move from 1.75 to 1.81. Also collapse the
single-line closure that rustfmt expects on one line.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty

Copy link
Copy Markdown
Member

@prql-bot This is a Dependabot PR with no human author — please don't just re-review, implement the sqlparser 0.62 migration and push a commit to this branch. You already scoped it precisely: apply the 5 mechanical default fields, wrap the Idents in ObjectName for ExcludeSelectItem::Multiple, and add an Err(...) arm for the new SelectItem::ExprWithAliases variant (consistent with how the surrounding code already rejects unsupported projection exprs). Rebase onto the latest main first, then push so CI can go green.

This was written by Claude Code on behalf of Maximilian Roos

prql-botand others added 2 commits May 19, 2026 18:02
Rust 1.94's clippy enforces `manual_inspect`, which flagged a `.map`
that only side-effects (debug logging) and returns the same value.
Switch to `.inspect` to satisfy the lint with no behavior change.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
sqlparser provides `impl From<Ident> for ObjectName` that constructs
exactly `ObjectName(vec![ObjectNamePart::Identifier(ident)])`, so the
manual wrap can collapse to `.map(ObjectName::from)`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty
max-sixty merged commit b11de3d into mainMay 19, 2026
80 of 81 checks passed
@max-sixty
max-sixty deleted the dependabot/cargo/sqlparser-0.62.0 branch May 19, 2026 19:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesrustPull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-sixty@prql-bot