internal: stop re-polling QUEUED checks during the Dependabot batch - #6141

Merged
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261
Aug 12, 2026
Merged

internal: stop re-polling QUEUED checks during the Dependabot batch#6141
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261

Conversation

@prql-bot

@prql-botprql-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Daily review of the previous night's tend runs surfaced one finding that clears both gates: tend-review sessions on the daily Dependabot batch spend 20–45 minutes re-entering the CI poll loop against checks that structurally cannot settle inside the session.

What happens

Five Dependabot PRs (#6130, #6132#6135) plus pre-commit-ci's #6131 opened over 2m13s — 17:14:32 to 17:16:45 — on 2026-08-03. On #6130's branch alone, five tests runs were created at 17:14:37; the cancel-in-progress concurrency group culled four, and the survivor — run 30835855220 — took 73 minutes end to end (17:14:3718:27:46), most of it QUEUED behind the five sibling matrices.

The poll loop under CI Monitoring in the bundled running-in-ci skill caps at 9 minutes per invocation, so each review re-entered it repeatedly and still ended unverified:

ReviewJob durationPoll roundsOutcome
#6130 (run)41 min4replacement run still queued at exit
#6131 (run)21 min2two checks still QUEUED at exit
#6133 (run)40 min4"the Rust matrix hadn't finished"
#6135 (run)41 min4did settle
#6134 (run)45 min3did settle (after a legitimate rerun of a flaked Windows job)

The reviews themselves were good — each one diagnosed the stale check-ok-to-merge red as a cancellation-cascade artifact rather than treating it as real, and each named the checks it had not observed reach terminal rather than implying coverage. The waste is purely the extra rounds. In #6130's own words: "Polling has run ~29 minutes; the replacement tests run is still queued (concurrency-queued) … It won't settle in this session." — three rounds after that observation, it still hadn't.

The rule

The two runs that did settle (#6134, #6135) were watching checks that were progressing; the three that wasted rounds were watching checks stuck in QUEUED. That distinction is the discriminator, so the rule keys on it rather than banning re-entry outright: stop after one round when pending checks are still QUEUED, keep going while they are IN_PROGRESS.

Gate assessment

  • Evidence level: High — structural. Runner saturation during the daily batch is deterministic, not a model choice. 3 clear occurrences this window, plus 3 historical entries in the tracking issue (chore: bump minijinja from 2.20.0 to 2.21.0 #6063 at 24 min on 2026-07-07, chore: bump tokio from 1.52.3 to 1.53.1 #6111 at 42 min on 2026-07-28, chore: bump github/codeql-action from 4 to 4.37.3 #6120 at 36 min on 2026-07-31). High needs 2–3; this is 6.
  • Change type: new short section in an existing repo overlay — the "new paragraph" bar of 3+ occurrences is met.
  • Not a bundled defect: the generic guidance is already correct (poll once, then report unverified). What the model lacks is the repo-specific fact that a QUEUED PRQL matrix during the batch means 40–75 minutes, which only an overlay can supply.
Session evidence

Runs analyzed: 30835853083, 30835879825, 30835900705, 30835922625, 30836026660, 30838560578, 30846380951, 30852089164, 30858704413, 30886931468, 30887510480, 30887553479, 30887961990, 30887996356, 30888281468, 30888469905, 30888779216, 30888815275.

Poll-round counts come from counting seq 1 9 loop invocations in each session's JSONL. The five concurrent tests runs on #6130's branch: 30835854409, 30835854490, 30835854594, 30835854618 (all cancelled) and 30835855220 (success).

@prql-botprql-bot added the review-runs Findings from tend-review-runs daily analysis label Aug 4, 2026
@prql-botprql-bot mentioned this pull request Aug 4, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes on the new section — both about making the rule unambiguous for a future run that has only this text to go on.

One gap without an obvious fix: applying the rule requires seeing which states are pending, but the pending() helper in CI Monitoring collapses the states inside jq and returns only a count, so a run following that recipe verbatim never observes QUEUED vs IN_PROGRESS. Naming the query in this section (gh pr view <n> --json statusCheckRollup and reading .status // .state) would make the rule mechanically applicable rather than dependent on the model deciding to look.

(Skipped /code-review here: .claude/ is bind-mounted read-only in the sandbox, so the working tree shows the base version of the file and the pass would have seen an empty diff. Reviewed against git show HEAD:.claude/skills/running-tend/SKILL.md instead.)

Comment thread.claude/skills/running-tend/SKILL.md Outdated
Comment thread.claude/skills/running-tend/SKILL.md Outdated
@max-sixty
max-sixty merged commit 1a82da5 into mainAug 12, 2026
41 checks passed
@max-sixty
max-sixty deleted the daily/review-runs-30893175261 branch August 12, 2026 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runsFindings from tend-review-runs daily analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

internal: stop re-polling QUEUED checks during the Dependabot batch - #6141

Merged
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261
Aug 12, 2026
Merged

internal: stop re-polling QUEUED checks during the Dependabot batch#6141
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261

Conversation

@prql-bot

@prql-botprql-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Daily review of the previous night's tend runs surfaced one finding that clears both gates: tend-review sessions on the daily Dependabot batch spend 20–45 minutes re-entering the CI poll loop against checks that structurally cannot settle inside the session.

What happens

Five Dependabot PRs (#6130, #6132#6135) plus pre-commit-ci's #6131 opened over 2m13s — 17:14:32 to 17:16:45 — on 2026-08-03. On #6130's branch alone, five tests runs were created at 17:14:37; the cancel-in-progress concurrency group culled four, and the survivor — run 30835855220 — took 73 minutes end to end (17:14:3718:27:46), most of it QUEUED behind the five sibling matrices.

The poll loop under CI Monitoring in the bundled running-in-ci skill caps at 9 minutes per invocation, so each review re-entered it repeatedly and still ended unverified:

ReviewJob durationPoll roundsOutcome
#6130 (run)41 min4replacement run still queued at exit
#6131 (run)21 min2two checks still QUEUED at exit
#6133 (run)40 min4"the Rust matrix hadn't finished"
#6135 (run)41 min4did settle
#6134 (run)45 min3did settle (after a legitimate rerun of a flaked Windows job)

The reviews themselves were good — each one diagnosed the stale check-ok-to-merge red as a cancellation-cascade artifact rather than treating it as real, and each named the checks it had not observed reach terminal rather than implying coverage. The waste is purely the extra rounds. In #6130's own words: "Polling has run ~29 minutes; the replacement tests run is still queued (concurrency-queued) … It won't settle in this session." — three rounds after that observation, it still hadn't.

The rule

The two runs that did settle (#6134, #6135) were watching checks that were progressing; the three that wasted rounds were watching checks stuck in QUEUED. That distinction is the discriminator, so the rule keys on it rather than banning re-entry outright: stop after one round when pending checks are still QUEUED, keep going while they are IN_PROGRESS.

Gate assessment

  • Evidence level: High — structural. Runner saturation during the daily batch is deterministic, not a model choice. 3 clear occurrences this window, plus 3 historical entries in the tracking issue (chore: bump minijinja from 2.20.0 to 2.21.0 #6063 at 24 min on 2026-07-07, chore: bump tokio from 1.52.3 to 1.53.1 #6111 at 42 min on 2026-07-28, chore: bump github/codeql-action from 4 to 4.37.3 #6120 at 36 min on 2026-07-31). High needs 2–3; this is 6.
  • Change type: new short section in an existing repo overlay — the "new paragraph" bar of 3+ occurrences is met.
  • Not a bundled defect: the generic guidance is already correct (poll once, then report unverified). What the model lacks is the repo-specific fact that a QUEUED PRQL matrix during the batch means 40–75 minutes, which only an overlay can supply.
Session evidence

Runs analyzed: 30835853083, 30835879825, 30835900705, 30835922625, 30836026660, 30838560578, 30846380951, 30852089164, 30858704413, 30886931468, 30887510480, 30887553479, 30887961990, 30887996356, 30888281468, 30888469905, 30888779216, 30888815275.

Poll-round counts come from counting seq 1 9 loop invocations in each session's JSONL. The five concurrent tests runs on #6130's branch: 30835854409, 30835854490, 30835854594, 30835854618 (all cancelled) and 30835855220 (success).

@prql-botprql-bot added the review-runs Findings from tend-review-runs daily analysis label Aug 4, 2026
@prql-botprql-bot mentioned this pull request Aug 4, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes on the new section — both about making the rule unambiguous for a future run that has only this text to go on.

One gap without an obvious fix: applying the rule requires seeing which states are pending, but the pending() helper in CI Monitoring collapses the states inside jq and returns only a count, so a run following that recipe verbatim never observes QUEUED vs IN_PROGRESS. Naming the query in this section (gh pr view <n> --json statusCheckRollup and reading .status // .state) would make the rule mechanically applicable rather than dependent on the model deciding to look.

(Skipped /code-review here: .claude/ is bind-mounted read-only in the sandbox, so the working tree shows the base version of the file and the pass would have seen an empty diff. Reviewed against git show HEAD:.claude/skills/running-tend/SKILL.md instead.)

Comment thread.claude/skills/running-tend/SKILL.md Outdated
Comment thread.claude/skills/running-tend/SKILL.md Outdated
@max-sixty
max-sixty merged commit 1a82da5 into mainAug 12, 2026
41 checks passed
@max-sixty
max-sixty deleted the daily/review-runs-30893175261 branch August 12, 2026 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runsFindings from tend-review-runs daily analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

internal: stop re-polling QUEUED checks during the Dependabot batch - #6141

Merged
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261
Aug 12, 2026
Merged

internal: stop re-polling QUEUED checks during the Dependabot batch#6141
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261

Conversation

@prql-bot

@prql-botprql-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Daily review of the previous night's tend runs surfaced one finding that clears both gates: tend-review sessions on the daily Dependabot batch spend 20–45 minutes re-entering the CI poll loop against checks that structurally cannot settle inside the session.

What happens

Five Dependabot PRs (#6130, #6132#6135) plus pre-commit-ci's #6131 opened over 2m13s — 17:14:32 to 17:16:45 — on 2026-08-03. On #6130's branch alone, five tests runs were created at 17:14:37; the cancel-in-progress concurrency group culled four, and the survivor — run 30835855220 — took 73 minutes end to end (17:14:3718:27:46), most of it QUEUED behind the five sibling matrices.

The poll loop under CI Monitoring in the bundled running-in-ci skill caps at 9 minutes per invocation, so each review re-entered it repeatedly and still ended unverified:

ReviewJob durationPoll roundsOutcome
#6130 (run)41 min4replacement run still queued at exit
#6131 (run)21 min2two checks still QUEUED at exit
#6133 (run)40 min4"the Rust matrix hadn't finished"
#6135 (run)41 min4did settle
#6134 (run)45 min3did settle (after a legitimate rerun of a flaked Windows job)

The reviews themselves were good — each one diagnosed the stale check-ok-to-merge red as a cancellation-cascade artifact rather than treating it as real, and each named the checks it had not observed reach terminal rather than implying coverage. The waste is purely the extra rounds. In #6130's own words: "Polling has run ~29 minutes; the replacement tests run is still queued (concurrency-queued) … It won't settle in this session." — three rounds after that observation, it still hadn't.

The rule

The two runs that did settle (#6134, #6135) were watching checks that were progressing; the three that wasted rounds were watching checks stuck in QUEUED. That distinction is the discriminator, so the rule keys on it rather than banning re-entry outright: stop after one round when pending checks are still QUEUED, keep going while they are IN_PROGRESS.

Gate assessment

  • Evidence level: High — structural. Runner saturation during the daily batch is deterministic, not a model choice. 3 clear occurrences this window, plus 3 historical entries in the tracking issue (chore: bump minijinja from 2.20.0 to 2.21.0 #6063 at 24 min on 2026-07-07, chore: bump tokio from 1.52.3 to 1.53.1 #6111 at 42 min on 2026-07-28, chore: bump github/codeql-action from 4 to 4.37.3 #6120 at 36 min on 2026-07-31). High needs 2–3; this is 6.
  • Change type: new short section in an existing repo overlay — the "new paragraph" bar of 3+ occurrences is met.
  • Not a bundled defect: the generic guidance is already correct (poll once, then report unverified). What the model lacks is the repo-specific fact that a QUEUED PRQL matrix during the batch means 40–75 minutes, which only an overlay can supply.
Session evidence

Runs analyzed: 30835853083, 30835879825, 30835900705, 30835922625, 30836026660, 30838560578, 30846380951, 30852089164, 30858704413, 30886931468, 30887510480, 30887553479, 30887961990, 30887996356, 30888281468, 30888469905, 30888779216, 30888815275.

Poll-round counts come from counting seq 1 9 loop invocations in each session's JSONL. The five concurrent tests runs on #6130's branch: 30835854409, 30835854490, 30835854594, 30835854618 (all cancelled) and 30835855220 (success).

@prql-botprql-bot added the review-runs Findings from tend-review-runs daily analysis label Aug 4, 2026
@prql-botprql-bot mentioned this pull request Aug 4, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes on the new section — both about making the rule unambiguous for a future run that has only this text to go on.

One gap without an obvious fix: applying the rule requires seeing which states are pending, but the pending() helper in CI Monitoring collapses the states inside jq and returns only a count, so a run following that recipe verbatim never observes QUEUED vs IN_PROGRESS. Naming the query in this section (gh pr view <n> --json statusCheckRollup and reading .status // .state) would make the rule mechanically applicable rather than dependent on the model deciding to look.

(Skipped /code-review here: .claude/ is bind-mounted read-only in the sandbox, so the working tree shows the base version of the file and the pass would have seen an empty diff. Reviewed against git show HEAD:.claude/skills/running-tend/SKILL.md instead.)

Comment thread.claude/skills/running-tend/SKILL.md Outdated
Comment thread.claude/skills/running-tend/SKILL.md Outdated
@max-sixty
max-sixty merged commit 1a82da5 into mainAug 12, 2026
41 checks passed
@max-sixty
max-sixty deleted the daily/review-runs-30893175261 branch August 12, 2026 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runsFindings from tend-review-runs daily analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

internal: stop re-polling QUEUED checks during the Dependabot batch - #6141

Merged
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261
Aug 12, 2026
Merged

internal: stop re-polling QUEUED checks during the Dependabot batch#6141
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261

Conversation

@prql-bot

@prql-botprql-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Daily review of the previous night's tend runs surfaced one finding that clears both gates: tend-review sessions on the daily Dependabot batch spend 20–45 minutes re-entering the CI poll loop against checks that structurally cannot settle inside the session.

What happens

Five Dependabot PRs (#6130, #6132#6135) plus pre-commit-ci's #6131 opened over 2m13s — 17:14:32 to 17:16:45 — on 2026-08-03. On #6130's branch alone, five tests runs were created at 17:14:37; the cancel-in-progress concurrency group culled four, and the survivor — run 30835855220 — took 73 minutes end to end (17:14:3718:27:46), most of it QUEUED behind the five sibling matrices.

The poll loop under CI Monitoring in the bundled running-in-ci skill caps at 9 minutes per invocation, so each review re-entered it repeatedly and still ended unverified:

ReviewJob durationPoll roundsOutcome
#6130 (run)41 min4replacement run still queued at exit
#6131 (run)21 min2two checks still QUEUED at exit
#6133 (run)40 min4"the Rust matrix hadn't finished"
#6135 (run)41 min4did settle
#6134 (run)45 min3did settle (after a legitimate rerun of a flaked Windows job)

The reviews themselves were good — each one diagnosed the stale check-ok-to-merge red as a cancellation-cascade artifact rather than treating it as real, and each named the checks it had not observed reach terminal rather than implying coverage. The waste is purely the extra rounds. In #6130's own words: "Polling has run ~29 minutes; the replacement tests run is still queued (concurrency-queued) … It won't settle in this session." — three rounds after that observation, it still hadn't.

The rule

The two runs that did settle (#6134, #6135) were watching checks that were progressing; the three that wasted rounds were watching checks stuck in QUEUED. That distinction is the discriminator, so the rule keys on it rather than banning re-entry outright: stop after one round when pending checks are still QUEUED, keep going while they are IN_PROGRESS.

Gate assessment

  • Evidence level: High — structural. Runner saturation during the daily batch is deterministic, not a model choice. 3 clear occurrences this window, plus 3 historical entries in the tracking issue (chore: bump minijinja from 2.20.0 to 2.21.0 #6063 at 24 min on 2026-07-07, chore: bump tokio from 1.52.3 to 1.53.1 #6111 at 42 min on 2026-07-28, chore: bump github/codeql-action from 4 to 4.37.3 #6120 at 36 min on 2026-07-31). High needs 2–3; this is 6.
  • Change type: new short section in an existing repo overlay — the "new paragraph" bar of 3+ occurrences is met.
  • Not a bundled defect: the generic guidance is already correct (poll once, then report unverified). What the model lacks is the repo-specific fact that a QUEUED PRQL matrix during the batch means 40–75 minutes, which only an overlay can supply.
Session evidence

Runs analyzed: 30835853083, 30835879825, 30835900705, 30835922625, 30836026660, 30838560578, 30846380951, 30852089164, 30858704413, 30886931468, 30887510480, 30887553479, 30887961990, 30887996356, 30888281468, 30888469905, 30888779216, 30888815275.

Poll-round counts come from counting seq 1 9 loop invocations in each session's JSONL. The five concurrent tests runs on #6130's branch: 30835854409, 30835854490, 30835854594, 30835854618 (all cancelled) and 30835855220 (success).

@prql-botprql-bot added the review-runs Findings from tend-review-runs daily analysis label Aug 4, 2026
@prql-botprql-bot mentioned this pull request Aug 4, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes on the new section — both about making the rule unambiguous for a future run that has only this text to go on.

One gap without an obvious fix: applying the rule requires seeing which states are pending, but the pending() helper in CI Monitoring collapses the states inside jq and returns only a count, so a run following that recipe verbatim never observes QUEUED vs IN_PROGRESS. Naming the query in this section (gh pr view <n> --json statusCheckRollup and reading .status // .state) would make the rule mechanically applicable rather than dependent on the model deciding to look.

(Skipped /code-review here: .claude/ is bind-mounted read-only in the sandbox, so the working tree shows the base version of the file and the pass would have seen an empty diff. Reviewed against git show HEAD:.claude/skills/running-tend/SKILL.md instead.)

Comment thread.claude/skills/running-tend/SKILL.md Outdated
Comment thread.claude/skills/running-tend/SKILL.md Outdated
@max-sixty
max-sixty merged commit 1a82da5 into mainAug 12, 2026
41 checks passed
@max-sixty
max-sixty deleted the daily/review-runs-30893175261 branch August 12, 2026 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runsFindings from tend-review-runs daily analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

internal: stop re-polling QUEUED checks during the Dependabot batch - #6141

Merged
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261
Aug 12, 2026
Merged

internal: stop re-polling QUEUED checks during the Dependabot batch#6141
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261

Conversation

@prql-bot

@prql-botprql-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Daily review of the previous night's tend runs surfaced one finding that clears both gates: tend-review sessions on the daily Dependabot batch spend 20–45 minutes re-entering the CI poll loop against checks that structurally cannot settle inside the session.

What happens

Five Dependabot PRs (#6130, #6132#6135) plus pre-commit-ci's #6131 opened over 2m13s — 17:14:32 to 17:16:45 — on 2026-08-03. On #6130's branch alone, five tests runs were created at 17:14:37; the cancel-in-progress concurrency group culled four, and the survivor — run 30835855220 — took 73 minutes end to end (17:14:3718:27:46), most of it QUEUED behind the five sibling matrices.

The poll loop under CI Monitoring in the bundled running-in-ci skill caps at 9 minutes per invocation, so each review re-entered it repeatedly and still ended unverified:

ReviewJob durationPoll roundsOutcome
#6130 (run)41 min4replacement run still queued at exit
#6131 (run)21 min2two checks still QUEUED at exit
#6133 (run)40 min4"the Rust matrix hadn't finished"
#6135 (run)41 min4did settle
#6134 (run)45 min3did settle (after a legitimate rerun of a flaked Windows job)

The reviews themselves were good — each one diagnosed the stale check-ok-to-merge red as a cancellation-cascade artifact rather than treating it as real, and each named the checks it had not observed reach terminal rather than implying coverage. The waste is purely the extra rounds. In #6130's own words: "Polling has run ~29 minutes; the replacement tests run is still queued (concurrency-queued) … It won't settle in this session." — three rounds after that observation, it still hadn't.

The rule

The two runs that did settle (#6134, #6135) were watching checks that were progressing; the three that wasted rounds were watching checks stuck in QUEUED. That distinction is the discriminator, so the rule keys on it rather than banning re-entry outright: stop after one round when pending checks are still QUEUED, keep going while they are IN_PROGRESS.

Gate assessment

  • Evidence level: High — structural. Runner saturation during the daily batch is deterministic, not a model choice. 3 clear occurrences this window, plus 3 historical entries in the tracking issue (chore: bump minijinja from 2.20.0 to 2.21.0 #6063 at 24 min on 2026-07-07, chore: bump tokio from 1.52.3 to 1.53.1 #6111 at 42 min on 2026-07-28, chore: bump github/codeql-action from 4 to 4.37.3 #6120 at 36 min on 2026-07-31). High needs 2–3; this is 6.
  • Change type: new short section in an existing repo overlay — the "new paragraph" bar of 3+ occurrences is met.
  • Not a bundled defect: the generic guidance is already correct (poll once, then report unverified). What the model lacks is the repo-specific fact that a QUEUED PRQL matrix during the batch means 40–75 minutes, which only an overlay can supply.
Session evidence

Runs analyzed: 30835853083, 30835879825, 30835900705, 30835922625, 30836026660, 30838560578, 30846380951, 30852089164, 30858704413, 30886931468, 30887510480, 30887553479, 30887961990, 30887996356, 30888281468, 30888469905, 30888779216, 30888815275.

Poll-round counts come from counting seq 1 9 loop invocations in each session's JSONL. The five concurrent tests runs on #6130's branch: 30835854409, 30835854490, 30835854594, 30835854618 (all cancelled) and 30835855220 (success).

@prql-botprql-bot added the review-runs Findings from tend-review-runs daily analysis label Aug 4, 2026
@prql-botprql-bot mentioned this pull request Aug 4, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes on the new section — both about making the rule unambiguous for a future run that has only this text to go on.

One gap without an obvious fix: applying the rule requires seeing which states are pending, but the pending() helper in CI Monitoring collapses the states inside jq and returns only a count, so a run following that recipe verbatim never observes QUEUED vs IN_PROGRESS. Naming the query in this section (gh pr view <n> --json statusCheckRollup and reading .status // .state) would make the rule mechanically applicable rather than dependent on the model deciding to look.

(Skipped /code-review here: .claude/ is bind-mounted read-only in the sandbox, so the working tree shows the base version of the file and the pass would have seen an empty diff. Reviewed against git show HEAD:.claude/skills/running-tend/SKILL.md instead.)

Comment thread.claude/skills/running-tend/SKILL.md Outdated
Comment thread.claude/skills/running-tend/SKILL.md Outdated
@max-sixty
max-sixty merged commit 1a82da5 into mainAug 12, 2026
41 checks passed
@max-sixty
max-sixty deleted the daily/review-runs-30893175261 branch August 12, 2026 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runsFindings from tend-review-runs daily analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

internal: stop re-polling QUEUED checks during the Dependabot batch - #6141

Merged
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261
Aug 12, 2026
Merged

internal: stop re-polling QUEUED checks during the Dependabot batch#6141
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261

Conversation

@prql-bot

@prql-botprql-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Daily review of the previous night's tend runs surfaced one finding that clears both gates: tend-review sessions on the daily Dependabot batch spend 20–45 minutes re-entering the CI poll loop against checks that structurally cannot settle inside the session.

What happens

Five Dependabot PRs (#6130, #6132#6135) plus pre-commit-ci's #6131 opened over 2m13s — 17:14:32 to 17:16:45 — on 2026-08-03. On #6130's branch alone, five tests runs were created at 17:14:37; the cancel-in-progress concurrency group culled four, and the survivor — run 30835855220 — took 73 minutes end to end (17:14:3718:27:46), most of it QUEUED behind the five sibling matrices.

The poll loop under CI Monitoring in the bundled running-in-ci skill caps at 9 minutes per invocation, so each review re-entered it repeatedly and still ended unverified:

ReviewJob durationPoll roundsOutcome
#6130 (run)41 min4replacement run still queued at exit
#6131 (run)21 min2two checks still QUEUED at exit
#6133 (run)40 min4"the Rust matrix hadn't finished"
#6135 (run)41 min4did settle
#6134 (run)45 min3did settle (after a legitimate rerun of a flaked Windows job)

The reviews themselves were good — each one diagnosed the stale check-ok-to-merge red as a cancellation-cascade artifact rather than treating it as real, and each named the checks it had not observed reach terminal rather than implying coverage. The waste is purely the extra rounds. In #6130's own words: "Polling has run ~29 minutes; the replacement tests run is still queued (concurrency-queued) … It won't settle in this session." — three rounds after that observation, it still hadn't.

The rule

The two runs that did settle (#6134, #6135) were watching checks that were progressing; the three that wasted rounds were watching checks stuck in QUEUED. That distinction is the discriminator, so the rule keys on it rather than banning re-entry outright: stop after one round when pending checks are still QUEUED, keep going while they are IN_PROGRESS.

Gate assessment

  • Evidence level: High — structural. Runner saturation during the daily batch is deterministic, not a model choice. 3 clear occurrences this window, plus 3 historical entries in the tracking issue (chore: bump minijinja from 2.20.0 to 2.21.0 #6063 at 24 min on 2026-07-07, chore: bump tokio from 1.52.3 to 1.53.1 #6111 at 42 min on 2026-07-28, chore: bump github/codeql-action from 4 to 4.37.3 #6120 at 36 min on 2026-07-31). High needs 2–3; this is 6.
  • Change type: new short section in an existing repo overlay — the "new paragraph" bar of 3+ occurrences is met.
  • Not a bundled defect: the generic guidance is already correct (poll once, then report unverified). What the model lacks is the repo-specific fact that a QUEUED PRQL matrix during the batch means 40–75 minutes, which only an overlay can supply.
Session evidence

Runs analyzed: 30835853083, 30835879825, 30835900705, 30835922625, 30836026660, 30838560578, 30846380951, 30852089164, 30858704413, 30886931468, 30887510480, 30887553479, 30887961990, 30887996356, 30888281468, 30888469905, 30888779216, 30888815275.

Poll-round counts come from counting seq 1 9 loop invocations in each session's JSONL. The five concurrent tests runs on #6130's branch: 30835854409, 30835854490, 30835854594, 30835854618 (all cancelled) and 30835855220 (success).

@prql-botprql-bot added the review-runs Findings from tend-review-runs daily analysis label Aug 4, 2026
@prql-botprql-bot mentioned this pull request Aug 4, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes on the new section — both about making the rule unambiguous for a future run that has only this text to go on.

One gap without an obvious fix: applying the rule requires seeing which states are pending, but the pending() helper in CI Monitoring collapses the states inside jq and returns only a count, so a run following that recipe verbatim never observes QUEUED vs IN_PROGRESS. Naming the query in this section (gh pr view <n> --json statusCheckRollup and reading .status // .state) would make the rule mechanically applicable rather than dependent on the model deciding to look.

(Skipped /code-review here: .claude/ is bind-mounted read-only in the sandbox, so the working tree shows the base version of the file and the pass would have seen an empty diff. Reviewed against git show HEAD:.claude/skills/running-tend/SKILL.md instead.)

Comment thread.claude/skills/running-tend/SKILL.md Outdated
Comment thread.claude/skills/running-tend/SKILL.md Outdated
@max-sixty
max-sixty merged commit 1a82da5 into mainAug 12, 2026
41 checks passed
@max-sixty
max-sixty deleted the daily/review-runs-30893175261 branch August 12, 2026 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runsFindings from tend-review-runs daily analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

internal: stop re-polling QUEUED checks during the Dependabot batch - #6141

Merged
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261
Aug 12, 2026
Merged

internal: stop re-polling QUEUED checks during the Dependabot batch#6141
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261

Conversation

@prql-bot

@prql-botprql-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Daily review of the previous night's tend runs surfaced one finding that clears both gates: tend-review sessions on the daily Dependabot batch spend 20–45 minutes re-entering the CI poll loop against checks that structurally cannot settle inside the session.

What happens

Five Dependabot PRs (#6130, #6132#6135) plus pre-commit-ci's #6131 opened over 2m13s — 17:14:32 to 17:16:45 — on 2026-08-03. On #6130's branch alone, five tests runs were created at 17:14:37; the cancel-in-progress concurrency group culled four, and the survivor — run 30835855220 — took 73 minutes end to end (17:14:3718:27:46), most of it QUEUED behind the five sibling matrices.

The poll loop under CI Monitoring in the bundled running-in-ci skill caps at 9 minutes per invocation, so each review re-entered it repeatedly and still ended unverified:

ReviewJob durationPoll roundsOutcome
#6130 (run)41 min4replacement run still queued at exit
#6131 (run)21 min2two checks still QUEUED at exit
#6133 (run)40 min4"the Rust matrix hadn't finished"
#6135 (run)41 min4did settle
#6134 (run)45 min3did settle (after a legitimate rerun of a flaked Windows job)

The reviews themselves were good — each one diagnosed the stale check-ok-to-merge red as a cancellation-cascade artifact rather than treating it as real, and each named the checks it had not observed reach terminal rather than implying coverage. The waste is purely the extra rounds. In #6130's own words: "Polling has run ~29 minutes; the replacement tests run is still queued (concurrency-queued) … It won't settle in this session." — three rounds after that observation, it still hadn't.

The rule

The two runs that did settle (#6134, #6135) were watching checks that were progressing; the three that wasted rounds were watching checks stuck in QUEUED. That distinction is the discriminator, so the rule keys on it rather than banning re-entry outright: stop after one round when pending checks are still QUEUED, keep going while they are IN_PROGRESS.

Gate assessment

  • Evidence level: High — structural. Runner saturation during the daily batch is deterministic, not a model choice. 3 clear occurrences this window, plus 3 historical entries in the tracking issue (chore: bump minijinja from 2.20.0 to 2.21.0 #6063 at 24 min on 2026-07-07, chore: bump tokio from 1.52.3 to 1.53.1 #6111 at 42 min on 2026-07-28, chore: bump github/codeql-action from 4 to 4.37.3 #6120 at 36 min on 2026-07-31). High needs 2–3; this is 6.
  • Change type: new short section in an existing repo overlay — the "new paragraph" bar of 3+ occurrences is met.
  • Not a bundled defect: the generic guidance is already correct (poll once, then report unverified). What the model lacks is the repo-specific fact that a QUEUED PRQL matrix during the batch means 40–75 minutes, which only an overlay can supply.
Session evidence

Runs analyzed: 30835853083, 30835879825, 30835900705, 30835922625, 30836026660, 30838560578, 30846380951, 30852089164, 30858704413, 30886931468, 30887510480, 30887553479, 30887961990, 30887996356, 30888281468, 30888469905, 30888779216, 30888815275.

Poll-round counts come from counting seq 1 9 loop invocations in each session's JSONL. The five concurrent tests runs on #6130's branch: 30835854409, 30835854490, 30835854594, 30835854618 (all cancelled) and 30835855220 (success).

@prql-botprql-bot added the review-runs Findings from tend-review-runs daily analysis label Aug 4, 2026
@prql-botprql-bot mentioned this pull request Aug 4, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes on the new section — both about making the rule unambiguous for a future run that has only this text to go on.

One gap without an obvious fix: applying the rule requires seeing which states are pending, but the pending() helper in CI Monitoring collapses the states inside jq and returns only a count, so a run following that recipe verbatim never observes QUEUED vs IN_PROGRESS. Naming the query in this section (gh pr view <n> --json statusCheckRollup and reading .status // .state) would make the rule mechanically applicable rather than dependent on the model deciding to look.

(Skipped /code-review here: .claude/ is bind-mounted read-only in the sandbox, so the working tree shows the base version of the file and the pass would have seen an empty diff. Reviewed against git show HEAD:.claude/skills/running-tend/SKILL.md instead.)

Comment thread.claude/skills/running-tend/SKILL.md Outdated
Comment thread.claude/skills/running-tend/SKILL.md Outdated
@max-sixty
max-sixty merged commit 1a82da5 into mainAug 12, 2026
41 checks passed
@max-sixty
max-sixty deleted the daily/review-runs-30893175261 branch August 12, 2026 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runsFindings from tend-review-runs daily analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

internal: stop re-polling QUEUED checks during the Dependabot batch - #6141

Merged
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261
Aug 12, 2026
Merged

internal: stop re-polling QUEUED checks during the Dependabot batch#6141
max-sixty merged 2 commits into
mainfrom
daily/review-runs-30893175261

Conversation

@prql-bot

@prql-botprql-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Daily review of the previous night's tend runs surfaced one finding that clears both gates: tend-review sessions on the daily Dependabot batch spend 20–45 minutes re-entering the CI poll loop against checks that structurally cannot settle inside the session.

What happens

Five Dependabot PRs (#6130, #6132#6135) plus pre-commit-ci's #6131 opened over 2m13s — 17:14:32 to 17:16:45 — on 2026-08-03. On #6130's branch alone, five tests runs were created at 17:14:37; the cancel-in-progress concurrency group culled four, and the survivor — run 30835855220 — took 73 minutes end to end (17:14:3718:27:46), most of it QUEUED behind the five sibling matrices.

The poll loop under CI Monitoring in the bundled running-in-ci skill caps at 9 minutes per invocation, so each review re-entered it repeatedly and still ended unverified:

ReviewJob durationPoll roundsOutcome
#6130 (run)41 min4replacement run still queued at exit
#6131 (run)21 min2two checks still QUEUED at exit
#6133 (run)40 min4"the Rust matrix hadn't finished"
#6135 (run)41 min4did settle
#6134 (run)45 min3did settle (after a legitimate rerun of a flaked Windows job)

The reviews themselves were good — each one diagnosed the stale check-ok-to-merge red as a cancellation-cascade artifact rather than treating it as real, and each named the checks it had not observed reach terminal rather than implying coverage. The waste is purely the extra rounds. In #6130's own words: "Polling has run ~29 minutes; the replacement tests run is still queued (concurrency-queued) … It won't settle in this session." — three rounds after that observation, it still hadn't.

The rule

The two runs that did settle (#6134, #6135) were watching checks that were progressing; the three that wasted rounds were watching checks stuck in QUEUED. That distinction is the discriminator, so the rule keys on it rather than banning re-entry outright: stop after one round when pending checks are still QUEUED, keep going while they are IN_PROGRESS.

Gate assessment

  • Evidence level: High — structural. Runner saturation during the daily batch is deterministic, not a model choice. 3 clear occurrences this window, plus 3 historical entries in the tracking issue (chore: bump minijinja from 2.20.0 to 2.21.0 #6063 at 24 min on 2026-07-07, chore: bump tokio from 1.52.3 to 1.53.1 #6111 at 42 min on 2026-07-28, chore: bump github/codeql-action from 4 to 4.37.3 #6120 at 36 min on 2026-07-31). High needs 2–3; this is 6.
  • Change type: new short section in an existing repo overlay — the "new paragraph" bar of 3+ occurrences is met.
  • Not a bundled defect: the generic guidance is already correct (poll once, then report unverified). What the model lacks is the repo-specific fact that a QUEUED PRQL matrix during the batch means 40–75 minutes, which only an overlay can supply.
Session evidence

Runs analyzed: 30835853083, 30835879825, 30835900705, 30835922625, 30836026660, 30838560578, 30846380951, 30852089164, 30858704413, 30886931468, 30887510480, 30887553479, 30887961990, 30887996356, 30888281468, 30888469905, 30888779216, 30888815275.

Poll-round counts come from counting seq 1 9 loop invocations in each session's JSONL. The five concurrent tests runs on #6130's branch: 30835854409, 30835854490, 30835854594, 30835854618 (all cancelled) and 30835855220 (success).

@prql-botprql-bot added the review-runs Findings from tend-review-runs daily analysis label Aug 4, 2026
@prql-botprql-bot mentioned this pull request Aug 4, 2026

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes on the new section — both about making the rule unambiguous for a future run that has only this text to go on.

One gap without an obvious fix: applying the rule requires seeing which states are pending, but the pending() helper in CI Monitoring collapses the states inside jq and returns only a count, so a run following that recipe verbatim never observes QUEUED vs IN_PROGRESS. Naming the query in this section (gh pr view <n> --json statusCheckRollup and reading .status // .state) would make the rule mechanically applicable rather than dependent on the model deciding to look.

(Skipped /code-review here: .claude/ is bind-mounted read-only in the sandbox, so the working tree shows the base version of the file and the pass would have seen an empty diff. Reviewed against git show HEAD:.claude/skills/running-tend/SKILL.md instead.)

Comment thread.claude/skills/running-tend/SKILL.md Outdated
Comment thread.claude/skills/running-tend/SKILL.md Outdated
@max-sixty
max-sixty merged commit 1a82da5 into mainAug 12, 2026
41 checks passed
@max-sixty
max-sixty deleted the daily/review-runs-30893175261 branch August 12, 2026 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-runsFindings from tend-review-runs daily analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty