fix: quote reserved words in fmt

[prql-bot]

fmt emitted source that no longer round-trips for names that collide with reserved words. Two distinct causes, both now fixed: the codegen kept its own hand-written copy of the keyword list (two entries behind the lexer's, missing import and enum), and expression-position identifiers bypassed the quoting logic entirely by going through pr::Ident's Display impl — a fifth copy of the "needs backticks" rule that knows nothing about reserved words.

#6200 fixed this class of bug for names that aren't valid bare idents; these slipped through because the lists and code paths write_ident_part sits behind were already inconsistent. #6210 gave the grammars/ files and the playground a "keep in sync with the lexer" comment for the same reason — this removes the need for one on the codegen side by deleting the duplicate.

Details

Three bugs, in ascending order of nastiness:

1. Declaration names collide with a keyword — loud failure, output doesn't lex.

$ printf'let `import` = 5\n'| prqlc fmtlet import = 5
$ printf'let import = 5\n'| prqlc fmtError: ╭─[ :1:5 ] │ 1 │ let import = 5 │ ───┬── │ ╰──── expected something else, but found keyword import───╯

Same for enum. Cause: write_ident_part consulted a local keywords() copy of the list that had drifted.

2. Reserved literals — true / false / null are reserved just as firmly (boolean() and null() both end with end_expr()), but lex as TokenKind::Literal rather than TokenKind::Keyword, so they were absent from the keyword list entirely.

3. Expression position — silent change of meaning, since the output still parses:

$ printf'from t\nselect {`true`, `null`}\n'| prqlc fmtfrom tselect {true, null}

SELECT "true", "null" before the round-trip, SELECT true, NULL after. This one affected every reserved word, including let and the others already in the list — ExprKind::Ident wrote via ident.to_string(), and pr::Ident's Display has its own quoting rule that only checks character validity.

Changes:

• prqlc/prqlc-parser/src/lexer/mod.rs — extract pub const KEYWORDS: [&str; 10], add the sibling pub const RESERVED_LITERALS: [&str; 3]; keyword() now builds its parser from the former via choice(KEYWORDS.map(just)).
• prqlc/prqlc/src/codegen/ast.rs — delete the local keywords()OnceLock<HashSet>, read both lexer lists directly. A linear scan of 13 &str beats hashing, so this drops the HashSet import along with the duplication. ExprKind::Ident now goes through a shared write_ident helper instead of Display.
• web/book/src/reference/syntax/keywords.md — the documented list had drifted the same two entries; adds enum and import. (It already listed true/false/null correctly — the docs were ahead of the code there.)

Tests:test_every_reserved_word_is_quoted iterates KEYWORDS.iter().chain(RESERVED_LITERALS.iter()) and checks both declaration and expression position, so a word added to either lexer list in future is covered without touching the test. test_reserved_literals_lex_as_literals in the parser pins RESERVED_LITERALS to actual lexer behaviour, since it's hand-written next to boolean()/null() rather than derived.

Snapshot changes: two fmt integration snapshots change from tracks. + backtick-star to tracks.*. That's the same Display-vs-write_ident_part divergence in the other direction — Display was over-quoting *, which valid_prql_ident() explicitly allows. Both forms compile to identical SQL, and the new output matches the .prql source.

Verification:cargo test -p prqlc -p prqlc-parser passes; cargo clippy --all-targets and cargo fmt --check are clean. task prqlc:pull-request couldn't run locally — cargo-insta isn't on the sandbox's PATH, which is what #6144 addresses — so CI is the first full-matrix run.

[prql-bot]

fmt still drops backticks on true / false / null. It's the same round-trip break as import/enum, but a worse failure mode — the output parses, as a different query — and test_every_keyword_is_quoted can't catch it, since those three lex as Literals rather than TokenKind::Keyword and so aren't in lexer::KEYWORDS. Details inline, plus a suggestion on the doc comment.

The choice(KEYWORDS.map(just)) rewrite preserves the original alternation order, and cargo test -p prqlc -p prqlc-parser passes locally on the merged tree.

[prql-bot]

cargo doc fails on this branch. The RESERVED_LITERALS doc comment links three private items — boolean, null, end_expr — from a pub const, which rustdoc::private_intra_doc_links denies under the workflow-level RUSTDOCFLAGS: -Dwarnings. Reproduced on the merged tree:

$ RUSTDOCFLAGS="-Dwarnings" cargo doc -p prqlc-parser --no-depserror: public documentation for `RESERVED_LITERALS` links to private item `boolean` --> prqlc/prqlc-parser/src/lexer/mod.rs:206:36 |206 | /// [`TokenKind::Keyword`] — see [`boolean`] and [`null`]. They're reserved just | ^^^^^^^ this item is private...error: could not document `prqlc-parser`

This PR's own CI won't catch it: the 🗒️ Doc step in test-rust.yaml is gated on inputs.nightly == 'true', which rules resolved to false here — so test-rust is green while cargo doc is broken, and it would surface on the nightly run after merge instead. The suggestion inline drops the link brackets; with it, RUSTDOCFLAGS="-Dwarnings" cargo doc -p prqlc-parser --no-deps is clean. (KEYWORDS's own doc comment above is fine — TokenKind::Keyword and RESERVED_LITERALS are both public.)

Nothing else outstanding. cargo test -p prqlc-parser --lib, cargo test -p prqlc --lib -- codegen and cargo test -p prqlc --test integration -- fmt all pass on the merged tree, and the two tracks.* snapshot changes are covered by the idempotence assertion in the fmt harness — pl_to_prql output is re-parsed and re-formatted — so the unquoted wildcard is verified to round-trip rather than just asserted to.

[prql-bot]

b932806 applies the suggestion verbatim, and RUSTDOCFLAGS="-Dwarnings" cargo doc -p prqlc-parser --no-deps now exits clean on the merged tree — the private_intra_doc_links error from my previous review is gone. Nothing else outstanding from either review; I can't approve my own PR, so this comment is the close-out.