Uh oh!
There was an error while loading. Please reload this page.
chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps - #6240
Conversation
mdbook-core/mdbook-preprocessor 0.5.3+ require toml ^1.1.2, which pulls indexmap >= 2.13; every indexmap from 2.12 on declares rust-version >= 1.82, above the project's declared 1.81.0 MSRV. The bump therefore lands in the workspace lockfile and fails test-msrv. It has recurred in four weekly patch-group PRs (#6035, #6062, #6132, #6203), each closed unmerged. Ignore >= 0.5.3 for both crates so the rest of the patch group still flows; remove the entries when the MSRV is raised.
prql-bot
left a comment
There was a problem hiding this comment.
Verified the version claims against the crates.io sparse index — mdbook-core 0.5.2 → 0.5.3 does switch toml from ^0.9.8 to ^1.1.2, indexmap 2.12.0 is the first to declare rust-version = "1.82" (2.14.0 declares 1.85), and the lockfile currently sits on indexmap 2.11.4, which declares 1.63. The >= x form in versions: is the syntax GitHub's own docs use, and prettier reports the file unchanged. The scoping to two crates rather than the whole patch group is right, and it matches the decision max-sixty recorded on #6203.
One correction to the rationale comment inline — it's the text a future maintainer reads when deciding whether the entry can go, so worth getting exact.
Uh oh!
There was an error while loading. Please reload this page.
Closing #6203 doesn't stop the bump coming back — Dependabot said so on that thread ("Closing it will not ignore any of these versions in future pull requests"), and the history bears it out: the same mdbook bump has arrived in four consecutive weekly patch-group PRs (#6035, #6062, #6132, #6203) since late June, each failing
test-msrvand each closed unmerged. This adds anignoreentry formdbook-core/mdbook-preprocessorat>= 0.5.3, so the decision recorded on #6203 — stay on 0.5.2 until the MSRV question is settled — actually holds.The entry is scoped to those two crates rather than the whole patch group, so the rest of the group still flows normally, and the inline comment names the two files to edit when the MSRV is raised so the entry gets removed with it.
Verified:
.github/dependabot.yamlparses and the cargo entry resolves to the two ignore rules; prettier reports the file unchanged.Why 0.5.3 is the boundary
The break is transitive, not in mdbook's own code. From the crates.io sparse index:
toml1.1.x requiresindexmap ^2.13.0, and everyindexmapfrom 2.12 on declaresrust-version≥ 1.82 (2.14.0, which the lock selected on #6203, declares 1.85).indexmapreachesprqlcas a normal dependency viaserde_yaml, so it sits in the graphcargo msrv verifychecks againstmetadata.msrv = "1.81.0"inprqlc/prqlc/Cargo.toml. That's why no pin inside theindexmap ^2.13.0range restores 1.81 compatibility — the full chain is worked through in the review on #6203.One correction to that review while I'm here: it implied
mdbook-corepicked uprust-version = "1.88.0"at 0.5.4. The index shows every 0.5.x release declares 1.88.0, including the 0.5.2 currently in the lockfile —mdbook-prqldoesn't setrust-version.workspace = true, so nothing has ever gated it. That's an independent question from this bump and I haven't touched it.