Skip to content

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps - #6240

Merged
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv
Aug 29, 2026
Merged

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps#6240
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv

Conversation

@prql-bot

Copy link
Copy Markdown
Collaborator

Closing #6203 doesn't stop the bump coming back — Dependabot said so on that thread ("Closing it will not ignore any of these versions in future pull requests"), and the history bears it out: the same mdbook bump has arrived in four consecutive weekly patch-group PRs (#6035, #6062, #6132, #6203) since late June, each failing test-msrv and each closed unmerged. This adds an ignore entry for mdbook-core/mdbook-preprocessor at >= 0.5.3, so the decision recorded on #6203 — stay on 0.5.2 until the MSRV question is settled — actually holds.

The entry is scoped to those two crates rather than the whole patch group, so the rest of the group still flows normally, and the inline comment names the two files to edit when the MSRV is raised so the entry gets removed with it.

Verified: .github/dependabot.yaml parses and the cargo entry resolves to the two ignore rules; prettier reports the file unchanged.

Why 0.5.3 is the boundary

The break is transitive, not in mdbook's own code. From the crates.io sparse index:

mdbook-core 0.5.2: toml ^0.9.8
mdbook-core 0.5.3: toml ^1.1.2
mdbook-core 0.5.4: toml ^1.1.2

toml 1.1.x requires indexmap ^2.13.0, and every indexmap from 2.12 on declares rust-version ≥ 1.82 (2.14.0, which the lock selected on #6203, declares 1.85). indexmap reaches prqlc as a normal dependency via serde_yaml, so it sits in the graph cargo msrv verify checks against metadata.msrv = "1.81.0" in prqlc/prqlc/Cargo.toml. That's why no pin inside the indexmap ^2.13.0 range restores 1.81 compatibility — the full chain is worked through in the review on #6203.

One correction to that review while I'm here: it implied mdbook-core picked up rust-version = "1.88.0" at 0.5.4. The index shows every 0.5.x release declares 1.88.0, including the 0.5.2 currently in the lockfile — mdbook-prql doesn't set rust-version.workspace = true, so nothing has ever gated it. That's an independent question from this bump and I haven't touched it.

mdbook-core/mdbook-preprocessor 0.5.3+ require toml ^1.1.2, which pulls
indexmap >= 2.13; every indexmap from 2.12 on declares rust-version >= 1.82,
above the project's declared 1.81.0 MSRV. The bump therefore lands in the
workspace lockfile and fails test-msrv.
It has recurred in four weekly patch-group PRs (#6035, #6062, #6132, #6203),
each closed unmerged. Ignore >= 0.5.3 for both crates so the rest of the patch
group still flows; remove the entries when the MSRV is raised.

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the version claims against the crates.io sparse index — mdbook-core 0.5.2 → 0.5.3 does switch toml from ^0.9.8 to ^1.1.2, indexmap 2.12.0 is the first to declare rust-version = "1.82" (2.14.0 declares 1.85), and the lockfile currently sits on indexmap 2.11.4, which declares 1.63. The >= x form in versions: is the syntax GitHub's own docs use, and prettier reports the file unchanged. The scoping to two crates rather than the whole patch group is right, and it matches the decision max-sixty recorded on #6203.

One correction to the rationale comment inline — it's the text a future maintainer reads when deciding whether the entry can go, so worth getting exact.

Comment thread.github/dependabot.yaml Outdated
@max-sixty
max-sixty merged commit 5eaca05 into mainAug 29, 2026
45 checks passed
@max-sixty
max-sixty deleted the chore/dependabot-ignore-mdbook-msrv branch August 29, 2026 00:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps by prql-bot · Pull Request #6240 · PRQL/prql · GitHub
Skip to content

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps - #6240

Merged
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv
Aug 29, 2026
Merged

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps#6240
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv

Conversation

@prql-bot

Copy link
Copy Markdown
Collaborator

Closing #6203 doesn't stop the bump coming back — Dependabot said so on that thread ("Closing it will not ignore any of these versions in future pull requests"), and the history bears it out: the same mdbook bump has arrived in four consecutive weekly patch-group PRs (#6035, #6062, #6132, #6203) since late June, each failing test-msrv and each closed unmerged. This adds an ignore entry for mdbook-core/mdbook-preprocessor at >= 0.5.3, so the decision recorded on #6203 — stay on 0.5.2 until the MSRV question is settled — actually holds.

The entry is scoped to those two crates rather than the whole patch group, so the rest of the group still flows normally, and the inline comment names the two files to edit when the MSRV is raised so the entry gets removed with it.

Verified: .github/dependabot.yaml parses and the cargo entry resolves to the two ignore rules; prettier reports the file unchanged.

Why 0.5.3 is the boundary

The break is transitive, not in mdbook's own code. From the crates.io sparse index:

mdbook-core 0.5.2: toml ^0.9.8
mdbook-core 0.5.3: toml ^1.1.2
mdbook-core 0.5.4: toml ^1.1.2

toml 1.1.x requires indexmap ^2.13.0, and every indexmap from 2.12 on declares rust-version ≥ 1.82 (2.14.0, which the lock selected on #6203, declares 1.85). indexmap reaches prqlc as a normal dependency via serde_yaml, so it sits in the graph cargo msrv verify checks against metadata.msrv = "1.81.0" in prqlc/prqlc/Cargo.toml. That's why no pin inside the indexmap ^2.13.0 range restores 1.81 compatibility — the full chain is worked through in the review on #6203.

One correction to that review while I'm here: it implied mdbook-core picked up rust-version = "1.88.0" at 0.5.4. The index shows every 0.5.x release declares 1.88.0, including the 0.5.2 currently in the lockfile — mdbook-prql doesn't set rust-version.workspace = true, so nothing has ever gated it. That's an independent question from this bump and I haven't touched it.

mdbook-core/mdbook-preprocessor 0.5.3+ require toml ^1.1.2, which pulls
indexmap >= 2.13; every indexmap from 2.12 on declares rust-version >= 1.82,
above the project's declared 1.81.0 MSRV. The bump therefore lands in the
workspace lockfile and fails test-msrv.
It has recurred in four weekly patch-group PRs (#6035, #6062, #6132, #6203),
each closed unmerged. Ignore >= 0.5.3 for both crates so the rest of the patch
group still flows; remove the entries when the MSRV is raised.

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the version claims against the crates.io sparse index — mdbook-core 0.5.2 → 0.5.3 does switch toml from ^0.9.8 to ^1.1.2, indexmap 2.12.0 is the first to declare rust-version = "1.82" (2.14.0 declares 1.85), and the lockfile currently sits on indexmap 2.11.4, which declares 1.63. The >= x form in versions: is the syntax GitHub's own docs use, and prettier reports the file unchanged. The scoping to two crates rather than the whole patch group is right, and it matches the decision max-sixty recorded on #6203.

One correction to the rationale comment inline — it's the text a future maintainer reads when deciding whether the entry can go, so worth getting exact.

Comment thread.github/dependabot.yaml Outdated
@max-sixty
max-sixty merged commit 5eaca05 into mainAug 29, 2026
45 checks passed
@max-sixty
max-sixty deleted the chore/dependabot-ignore-mdbook-msrv branch August 29, 2026 00:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps by prql-bot · Pull Request #6240 · PRQL/prql · GitHub
Skip to content

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps - #6240

Merged
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv
Aug 29, 2026
Merged

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps#6240
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv

Conversation

@prql-bot

Copy link
Copy Markdown
Collaborator

Closing #6203 doesn't stop the bump coming back — Dependabot said so on that thread ("Closing it will not ignore any of these versions in future pull requests"), and the history bears it out: the same mdbook bump has arrived in four consecutive weekly patch-group PRs (#6035, #6062, #6132, #6203) since late June, each failing test-msrv and each closed unmerged. This adds an ignore entry for mdbook-core/mdbook-preprocessor at >= 0.5.3, so the decision recorded on #6203 — stay on 0.5.2 until the MSRV question is settled — actually holds.

The entry is scoped to those two crates rather than the whole patch group, so the rest of the group still flows normally, and the inline comment names the two files to edit when the MSRV is raised so the entry gets removed with it.

Verified: .github/dependabot.yaml parses and the cargo entry resolves to the two ignore rules; prettier reports the file unchanged.

Why 0.5.3 is the boundary

The break is transitive, not in mdbook's own code. From the crates.io sparse index:

mdbook-core 0.5.2: toml ^0.9.8
mdbook-core 0.5.3: toml ^1.1.2
mdbook-core 0.5.4: toml ^1.1.2

toml 1.1.x requires indexmap ^2.13.0, and every indexmap from 2.12 on declares rust-version ≥ 1.82 (2.14.0, which the lock selected on #6203, declares 1.85). indexmap reaches prqlc as a normal dependency via serde_yaml, so it sits in the graph cargo msrv verify checks against metadata.msrv = "1.81.0" in prqlc/prqlc/Cargo.toml. That's why no pin inside the indexmap ^2.13.0 range restores 1.81 compatibility — the full chain is worked through in the review on #6203.

One correction to that review while I'm here: it implied mdbook-core picked up rust-version = "1.88.0" at 0.5.4. The index shows every 0.5.x release declares 1.88.0, including the 0.5.2 currently in the lockfile — mdbook-prql doesn't set rust-version.workspace = true, so nothing has ever gated it. That's an independent question from this bump and I haven't touched it.

mdbook-core/mdbook-preprocessor 0.5.3+ require toml ^1.1.2, which pulls
indexmap >= 2.13; every indexmap from 2.12 on declares rust-version >= 1.82,
above the project's declared 1.81.0 MSRV. The bump therefore lands in the
workspace lockfile and fails test-msrv.
It has recurred in four weekly patch-group PRs (#6035, #6062, #6132, #6203),
each closed unmerged. Ignore >= 0.5.3 for both crates so the rest of the patch
group still flows; remove the entries when the MSRV is raised.

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the version claims against the crates.io sparse index — mdbook-core 0.5.2 → 0.5.3 does switch toml from ^0.9.8 to ^1.1.2, indexmap 2.12.0 is the first to declare rust-version = "1.82" (2.14.0 declares 1.85), and the lockfile currently sits on indexmap 2.11.4, which declares 1.63. The >= x form in versions: is the syntax GitHub's own docs use, and prettier reports the file unchanged. The scoping to two crates rather than the whole patch group is right, and it matches the decision max-sixty recorded on #6203.

One correction to the rationale comment inline — it's the text a future maintainer reads when deciding whether the entry can go, so worth getting exact.

Comment thread.github/dependabot.yaml Outdated
@max-sixty
max-sixty merged commit 5eaca05 into mainAug 29, 2026
45 checks passed
@max-sixty
max-sixty deleted the chore/dependabot-ignore-mdbook-msrv branch August 29, 2026 00:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps by prql-bot · Pull Request #6240 · PRQL/prql · GitHub
Skip to content

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps - #6240

Merged
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv
Aug 29, 2026
Merged

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps#6240
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv

Conversation

@prql-bot

Copy link
Copy Markdown
Collaborator

Closing #6203 doesn't stop the bump coming back — Dependabot said so on that thread ("Closing it will not ignore any of these versions in future pull requests"), and the history bears it out: the same mdbook bump has arrived in four consecutive weekly patch-group PRs (#6035, #6062, #6132, #6203) since late June, each failing test-msrv and each closed unmerged. This adds an ignore entry for mdbook-core/mdbook-preprocessor at >= 0.5.3, so the decision recorded on #6203 — stay on 0.5.2 until the MSRV question is settled — actually holds.

The entry is scoped to those two crates rather than the whole patch group, so the rest of the group still flows normally, and the inline comment names the two files to edit when the MSRV is raised so the entry gets removed with it.

Verified: .github/dependabot.yaml parses and the cargo entry resolves to the two ignore rules; prettier reports the file unchanged.

Why 0.5.3 is the boundary

The break is transitive, not in mdbook's own code. From the crates.io sparse index:

mdbook-core 0.5.2: toml ^0.9.8
mdbook-core 0.5.3: toml ^1.1.2
mdbook-core 0.5.4: toml ^1.1.2

toml 1.1.x requires indexmap ^2.13.0, and every indexmap from 2.12 on declares rust-version ≥ 1.82 (2.14.0, which the lock selected on #6203, declares 1.85). indexmap reaches prqlc as a normal dependency via serde_yaml, so it sits in the graph cargo msrv verify checks against metadata.msrv = "1.81.0" in prqlc/prqlc/Cargo.toml. That's why no pin inside the indexmap ^2.13.0 range restores 1.81 compatibility — the full chain is worked through in the review on #6203.

One correction to that review while I'm here: it implied mdbook-core picked up rust-version = "1.88.0" at 0.5.4. The index shows every 0.5.x release declares 1.88.0, including the 0.5.2 currently in the lockfile — mdbook-prql doesn't set rust-version.workspace = true, so nothing has ever gated it. That's an independent question from this bump and I haven't touched it.

mdbook-core/mdbook-preprocessor 0.5.3+ require toml ^1.1.2, which pulls
indexmap >= 2.13; every indexmap from 2.12 on declares rust-version >= 1.82,
above the project's declared 1.81.0 MSRV. The bump therefore lands in the
workspace lockfile and fails test-msrv.
It has recurred in four weekly patch-group PRs (#6035, #6062, #6132, #6203),
each closed unmerged. Ignore >= 0.5.3 for both crates so the rest of the patch
group still flows; remove the entries when the MSRV is raised.

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the version claims against the crates.io sparse index — mdbook-core 0.5.2 → 0.5.3 does switch toml from ^0.9.8 to ^1.1.2, indexmap 2.12.0 is the first to declare rust-version = "1.82" (2.14.0 declares 1.85), and the lockfile currently sits on indexmap 2.11.4, which declares 1.63. The >= x form in versions: is the syntax GitHub's own docs use, and prettier reports the file unchanged. The scoping to two crates rather than the whole patch group is right, and it matches the decision max-sixty recorded on #6203.

One correction to the rationale comment inline — it's the text a future maintainer reads when deciding whether the entry can go, so worth getting exact.

Comment thread.github/dependabot.yaml Outdated
@max-sixty
max-sixty merged commit 5eaca05 into mainAug 29, 2026
45 checks passed
@max-sixty
max-sixty deleted the chore/dependabot-ignore-mdbook-msrv branch August 29, 2026 00:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps by prql-bot · Pull Request #6240 · PRQL/prql · GitHub
Skip to content

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps - #6240

Merged
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv
Aug 29, 2026
Merged

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps#6240
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv

Conversation

@prql-bot

Copy link
Copy Markdown
Collaborator

Closing #6203 doesn't stop the bump coming back — Dependabot said so on that thread ("Closing it will not ignore any of these versions in future pull requests"), and the history bears it out: the same mdbook bump has arrived in four consecutive weekly patch-group PRs (#6035, #6062, #6132, #6203) since late June, each failing test-msrv and each closed unmerged. This adds an ignore entry for mdbook-core/mdbook-preprocessor at >= 0.5.3, so the decision recorded on #6203 — stay on 0.5.2 until the MSRV question is settled — actually holds.

The entry is scoped to those two crates rather than the whole patch group, so the rest of the group still flows normally, and the inline comment names the two files to edit when the MSRV is raised so the entry gets removed with it.

Verified: .github/dependabot.yaml parses and the cargo entry resolves to the two ignore rules; prettier reports the file unchanged.

Why 0.5.3 is the boundary

The break is transitive, not in mdbook's own code. From the crates.io sparse index:

mdbook-core 0.5.2: toml ^0.9.8
mdbook-core 0.5.3: toml ^1.1.2
mdbook-core 0.5.4: toml ^1.1.2

toml 1.1.x requires indexmap ^2.13.0, and every indexmap from 2.12 on declares rust-version ≥ 1.82 (2.14.0, which the lock selected on #6203, declares 1.85). indexmap reaches prqlc as a normal dependency via serde_yaml, so it sits in the graph cargo msrv verify checks against metadata.msrv = "1.81.0" in prqlc/prqlc/Cargo.toml. That's why no pin inside the indexmap ^2.13.0 range restores 1.81 compatibility — the full chain is worked through in the review on #6203.

One correction to that review while I'm here: it implied mdbook-core picked up rust-version = "1.88.0" at 0.5.4. The index shows every 0.5.x release declares 1.88.0, including the 0.5.2 currently in the lockfile — mdbook-prql doesn't set rust-version.workspace = true, so nothing has ever gated it. That's an independent question from this bump and I haven't touched it.

mdbook-core/mdbook-preprocessor 0.5.3+ require toml ^1.1.2, which pulls
indexmap >= 2.13; every indexmap from 2.12 on declares rust-version >= 1.82,
above the project's declared 1.81.0 MSRV. The bump therefore lands in the
workspace lockfile and fails test-msrv.
It has recurred in four weekly patch-group PRs (#6035, #6062, #6132, #6203),
each closed unmerged. Ignore >= 0.5.3 for both crates so the rest of the patch
group still flows; remove the entries when the MSRV is raised.

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the version claims against the crates.io sparse index — mdbook-core 0.5.2 → 0.5.3 does switch toml from ^0.9.8 to ^1.1.2, indexmap 2.12.0 is the first to declare rust-version = "1.82" (2.14.0 declares 1.85), and the lockfile currently sits on indexmap 2.11.4, which declares 1.63. The >= x form in versions: is the syntax GitHub's own docs use, and prettier reports the file unchanged. The scoping to two crates rather than the whole patch group is right, and it matches the decision max-sixty recorded on #6203.

One correction to the rationale comment inline — it's the text a future maintainer reads when deciding whether the entry can go, so worth getting exact.

Comment thread.github/dependabot.yaml Outdated
@max-sixty
max-sixty merged commit 5eaca05 into mainAug 29, 2026
45 checks passed
@max-sixty
max-sixty deleted the chore/dependabot-ignore-mdbook-msrv branch August 29, 2026 00:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps by prql-bot · Pull Request #6240 · PRQL/prql · GitHub
Skip to content

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps - #6240

Merged
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv
Aug 29, 2026
Merged

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps#6240
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv

Conversation

@prql-bot

Copy link
Copy Markdown
Collaborator

Closing #6203 doesn't stop the bump coming back — Dependabot said so on that thread ("Closing it will not ignore any of these versions in future pull requests"), and the history bears it out: the same mdbook bump has arrived in four consecutive weekly patch-group PRs (#6035, #6062, #6132, #6203) since late June, each failing test-msrv and each closed unmerged. This adds an ignore entry for mdbook-core/mdbook-preprocessor at >= 0.5.3, so the decision recorded on #6203 — stay on 0.5.2 until the MSRV question is settled — actually holds.

The entry is scoped to those two crates rather than the whole patch group, so the rest of the group still flows normally, and the inline comment names the two files to edit when the MSRV is raised so the entry gets removed with it.

Verified: .github/dependabot.yaml parses and the cargo entry resolves to the two ignore rules; prettier reports the file unchanged.

Why 0.5.3 is the boundary

The break is transitive, not in mdbook's own code. From the crates.io sparse index:

mdbook-core 0.5.2: toml ^0.9.8
mdbook-core 0.5.3: toml ^1.1.2
mdbook-core 0.5.4: toml ^1.1.2

toml 1.1.x requires indexmap ^2.13.0, and every indexmap from 2.12 on declares rust-version ≥ 1.82 (2.14.0, which the lock selected on #6203, declares 1.85). indexmap reaches prqlc as a normal dependency via serde_yaml, so it sits in the graph cargo msrv verify checks against metadata.msrv = "1.81.0" in prqlc/prqlc/Cargo.toml. That's why no pin inside the indexmap ^2.13.0 range restores 1.81 compatibility — the full chain is worked through in the review on #6203.

One correction to that review while I'm here: it implied mdbook-core picked up rust-version = "1.88.0" at 0.5.4. The index shows every 0.5.x release declares 1.88.0, including the 0.5.2 currently in the lockfile — mdbook-prql doesn't set rust-version.workspace = true, so nothing has ever gated it. That's an independent question from this bump and I haven't touched it.

mdbook-core/mdbook-preprocessor 0.5.3+ require toml ^1.1.2, which pulls
indexmap >= 2.13; every indexmap from 2.12 on declares rust-version >= 1.82,
above the project's declared 1.81.0 MSRV. The bump therefore lands in the
workspace lockfile and fails test-msrv.
It has recurred in four weekly patch-group PRs (#6035, #6062, #6132, #6203),
each closed unmerged. Ignore >= 0.5.3 for both crates so the rest of the patch
group still flows; remove the entries when the MSRV is raised.

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the version claims against the crates.io sparse index — mdbook-core 0.5.2 → 0.5.3 does switch toml from ^0.9.8 to ^1.1.2, indexmap 2.12.0 is the first to declare rust-version = "1.82" (2.14.0 declares 1.85), and the lockfile currently sits on indexmap 2.11.4, which declares 1.63. The >= x form in versions: is the syntax GitHub's own docs use, and prettier reports the file unchanged. The scoping to two crates rather than the whole patch group is right, and it matches the decision max-sixty recorded on #6203.

One correction to the rationale comment inline — it's the text a future maintainer reads when deciding whether the entry can go, so worth getting exact.

Comment thread.github/dependabot.yaml Outdated
@max-sixty
max-sixty merged commit 5eaca05 into mainAug 29, 2026
45 checks passed
@max-sixty
max-sixty deleted the chore/dependabot-ignore-mdbook-msrv branch August 29, 2026 00:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps by prql-bot · Pull Request #6240 · PRQL/prql · GitHub
Skip to content

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps - #6240

Merged
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv
Aug 29, 2026
Merged

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps#6240
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv

Conversation

@prql-bot

Copy link
Copy Markdown
Collaborator

Closing #6203 doesn't stop the bump coming back — Dependabot said so on that thread ("Closing it will not ignore any of these versions in future pull requests"), and the history bears it out: the same mdbook bump has arrived in four consecutive weekly patch-group PRs (#6035, #6062, #6132, #6203) since late June, each failing test-msrv and each closed unmerged. This adds an ignore entry for mdbook-core/mdbook-preprocessor at >= 0.5.3, so the decision recorded on #6203 — stay on 0.5.2 until the MSRV question is settled — actually holds.

The entry is scoped to those two crates rather than the whole patch group, so the rest of the group still flows normally, and the inline comment names the two files to edit when the MSRV is raised so the entry gets removed with it.

Verified: .github/dependabot.yaml parses and the cargo entry resolves to the two ignore rules; prettier reports the file unchanged.

Why 0.5.3 is the boundary

The break is transitive, not in mdbook's own code. From the crates.io sparse index:

mdbook-core 0.5.2: toml ^0.9.8
mdbook-core 0.5.3: toml ^1.1.2
mdbook-core 0.5.4: toml ^1.1.2

toml 1.1.x requires indexmap ^2.13.0, and every indexmap from 2.12 on declares rust-version ≥ 1.82 (2.14.0, which the lock selected on #6203, declares 1.85). indexmap reaches prqlc as a normal dependency via serde_yaml, so it sits in the graph cargo msrv verify checks against metadata.msrv = "1.81.0" in prqlc/prqlc/Cargo.toml. That's why no pin inside the indexmap ^2.13.0 range restores 1.81 compatibility — the full chain is worked through in the review on #6203.

One correction to that review while I'm here: it implied mdbook-core picked up rust-version = "1.88.0" at 0.5.4. The index shows every 0.5.x release declares 1.88.0, including the 0.5.2 currently in the lockfile — mdbook-prql doesn't set rust-version.workspace = true, so nothing has ever gated it. That's an independent question from this bump and I haven't touched it.

mdbook-core/mdbook-preprocessor 0.5.3+ require toml ^1.1.2, which pulls
indexmap >= 2.13; every indexmap from 2.12 on declares rust-version >= 1.82,
above the project's declared 1.81.0 MSRV. The bump therefore lands in the
workspace lockfile and fails test-msrv.
It has recurred in four weekly patch-group PRs (#6035, #6062, #6132, #6203),
each closed unmerged. Ignore >= 0.5.3 for both crates so the rest of the patch
group still flows; remove the entries when the MSRV is raised.

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the version claims against the crates.io sparse index — mdbook-core 0.5.2 → 0.5.3 does switch toml from ^0.9.8 to ^1.1.2, indexmap 2.12.0 is the first to declare rust-version = "1.82" (2.14.0 declares 1.85), and the lockfile currently sits on indexmap 2.11.4, which declares 1.63. The >= x form in versions: is the syntax GitHub's own docs use, and prettier reports the file unchanged. The scoping to two crates rather than the whole patch group is right, and it matches the decision max-sixty recorded on #6203.

One correction to the rationale comment inline — it's the text a future maintainer reads when deciding whether the entry can go, so worth getting exact.

Comment thread.github/dependabot.yaml Outdated
@max-sixty
max-sixty merged commit 5eaca05 into mainAug 29, 2026
45 checks passed
@max-sixty
max-sixty deleted the chore/dependabot-ignore-mdbook-msrv branch August 29, 2026 00:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps by prql-bot · Pull Request #6240 · PRQL/prql · GitHub
Skip to content

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps - #6240

Merged
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv
Aug 29, 2026
Merged

chore: stop Dependabot re-proposing MSRV-breaking mdbook bumps#6240
max-sixty merged 2 commits into
mainfrom
chore/dependabot-ignore-mdbook-msrv

Conversation

@prql-bot

Copy link
Copy Markdown
Collaborator

Closing #6203 doesn't stop the bump coming back — Dependabot said so on that thread ("Closing it will not ignore any of these versions in future pull requests"), and the history bears it out: the same mdbook bump has arrived in four consecutive weekly patch-group PRs (#6035, #6062, #6132, #6203) since late June, each failing test-msrv and each closed unmerged. This adds an ignore entry for mdbook-core/mdbook-preprocessor at >= 0.5.3, so the decision recorded on #6203 — stay on 0.5.2 until the MSRV question is settled — actually holds.

The entry is scoped to those two crates rather than the whole patch group, so the rest of the group still flows normally, and the inline comment names the two files to edit when the MSRV is raised so the entry gets removed with it.

Verified: .github/dependabot.yaml parses and the cargo entry resolves to the two ignore rules; prettier reports the file unchanged.

Why 0.5.3 is the boundary

The break is transitive, not in mdbook's own code. From the crates.io sparse index:

mdbook-core 0.5.2: toml ^0.9.8
mdbook-core 0.5.3: toml ^1.1.2
mdbook-core 0.5.4: toml ^1.1.2

toml 1.1.x requires indexmap ^2.13.0, and every indexmap from 2.12 on declares rust-version ≥ 1.82 (2.14.0, which the lock selected on #6203, declares 1.85). indexmap reaches prqlc as a normal dependency via serde_yaml, so it sits in the graph cargo msrv verify checks against metadata.msrv = "1.81.0" in prqlc/prqlc/Cargo.toml. That's why no pin inside the indexmap ^2.13.0 range restores 1.81 compatibility — the full chain is worked through in the review on #6203.

One correction to that review while I'm here: it implied mdbook-core picked up rust-version = "1.88.0" at 0.5.4. The index shows every 0.5.x release declares 1.88.0, including the 0.5.2 currently in the lockfile — mdbook-prql doesn't set rust-version.workspace = true, so nothing has ever gated it. That's an independent question from this bump and I haven't touched it.

mdbook-core/mdbook-preprocessor 0.5.3+ require toml ^1.1.2, which pulls
indexmap >= 2.13; every indexmap from 2.12 on declares rust-version >= 1.82,
above the project's declared 1.81.0 MSRV. The bump therefore lands in the
workspace lockfile and fails test-msrv.
It has recurred in four weekly patch-group PRs (#6035, #6062, #6132, #6203),
each closed unmerged. Ignore >= 0.5.3 for both crates so the rest of the patch
group still flows; remove the entries when the MSRV is raised.

@prql-botprql-bot left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the version claims against the crates.io sparse index — mdbook-core 0.5.2 → 0.5.3 does switch toml from ^0.9.8 to ^1.1.2, indexmap 2.12.0 is the first to declare rust-version = "1.82" (2.14.0 declares 1.85), and the lockfile currently sits on indexmap 2.11.4, which declares 1.63. The >= x form in versions: is the syntax GitHub's own docs use, and prettier reports the file unchanged. The scoping to two crates rather than the whole patch group is right, and it matches the decision max-sixty recorded on #6203.

One correction to the rationale comment inline — it's the text a future maintainer reads when deciding whether the entry can go, so worth getting exact.

Comment thread.github/dependabot.yaml Outdated
@max-sixty
max-sixty merged commit 5eaca05 into mainAug 29, 2026
45 checks passed
@max-sixty
max-sixty deleted the chore/dependabot-ignore-mdbook-msrv branch August 29, 2026 00:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prql-bot@max-sixty