Uh oh!
There was an error while loading. Please reload this page.
ci: remove the inert nox/uv cache step from test-python - #6253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Cache uv and Noxstep intest-pythonhas never cached anything: both paths it names are wrong, so every restore misses and every save is skipped with a path-validation warning. This removes that step and theCompute pyproject.toml hashstep that only fed its key.astral-sh/setup-uvalready caches uv's cache directory with a correct per-platform key, and nox recreates its virtualenvs on every run, so nothing is lost.Verified against the last two nightly runs: the
nox-uv-…key missed on all three OSes on both days, and the post step loggedPath(s) specified in the action for caching do(es) not exist.Evidence and mechanism
Both cached paths are wrong:
.nox— the run command isnox -s tests typing -f prqlc/bindings/prqlc-python/noxfile.py. nox chdirs to the noxfile's directory, so the env dir is created atprqlc/bindings/prqlc-python/.nox, not the repo-root.noxthe cache step names. The 2026-08-29 ubuntu job shows both:CWD /home/runner/work/prql/prql/prqlc/bindings/prqlc-pythonandnox > Creating virtual environment (uv) using python3.10 in .nox/tests-3-10.~/.cache/uv—astral-sh/setup-uv@v7setsUV_CACHE_DIR=/home/runner/work/_temp/setup-uv-cache, visible in that job's step env. uv never writes to~/.cache/uvhere.With neither path present, the post step logs:
so no cache is ever written, and the restore correspondingly misses every time. Across the two most recent scheduled 3-OS runs — 33248713260 (2026-08-29) and 33181607218 (2026-08-28) — all six jobs logged:
Note the key is byte-identical across ubuntu, macOS, and Windows: it has no
${{ runner.os }}component, unlike the repo's elixir cache keys. Rather than add the OS component, this removes the step, because neither path is worth caching once the paths are corrected:~/.cache/uvwould duplicate setup-uv's own cache, which is working — the same jobs logCache hit for: setup-uv-2-x86_64-unknown-linux-gnu-…anduv cache saved with key: setup-uv-2-…, keyed per platform, python version, and uv version..noxis recreated on every run regardless:noxfile.pysetsnox.options.reuse_existing_virtualenvs = False, and the logs confirm a freshCreating virtual environmentline for each of the four sessions.No regression test: this is a CI workflow change with no code under test. The check is the
test-python / testjob itself — it should keep passing, and its post step should no longer emit the path-validation warning.