Skip to content

[WIP] Dynamic Firms - #457

Closed
jdebacker wants to merge 88 commits into
PSLmodels:masterfrom
jdebacker:dyn_firm
Closed

[WIP] Dynamic Firms#457
jdebacker wants to merge 88 commits into
PSLmodels:masterfrom
jdebacker:dyn_firm

Conversation

@jdebacker

Copy link
Copy Markdown
Member

This PR replaces the static representative firm with a dynamic representative firm, that maximize the present discounted value of profits. This addition allows for modeling capital adjustment costs and better modeling of business tax policies.

@codecov-io

codecov-io commented Jul 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #457 into master will decrease coverage by 15.93%.
The diff coverage is 92.76%.

Impacted file tree graph

@@ Coverage Diff @@## master #457 +/- ##
===========================================
- Coverage 84.18% 68.25% -15.94% 
===========================================
Files 47 36 -11 Lines 6657 5304 -1353 ===========================================
- Hits 5604 3620 -1984 - Misses 1053 1684 +631 
Impacted FilesCoverage Δ
ogusa/firm.py88.88% <80.70%> (-11.12%)⬇️
ogusa/parameters.py77.81% <100.00%> (-6.94%)⬇️
ogusa/tests/test_firm.py100.00% <100.00%> (ø)
ogusa/get_micro_data.py33.33% <0.00%> (-64.89%)⬇️
ogusa/income.py50.00% <0.00%> (-50.00%)⬇️
ogusa/elliptical_u_est.py60.46% <0.00%> (-39.54%)⬇️
ogusa/utils.py69.62% <0.00%> (-30.38%)⬇️
ogusa/demographics.py54.42% <0.00%> (-28.66%)⬇️
ogusa/tests/test_TPI.py38.88% <0.00%> (-20.93%)⬇️
ogusa/household.py86.82% <0.00%> (-13.18%)⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9b897...e9f8f8d. Read the comment docs.

@rickecon

Copy link
Copy Markdown
Member

@jdebacker . I don't understand the Travis CI error messages for why this is not passing.

@jdebacker

Copy link
Copy Markdown
MemberAuthor

@rickecon This branch isn't up to date with the master. It's still a work in progress. I'll sync and then be moving forward with dynamic firms soon. I've got the theory down, but still testing some functions dealing with different business tax systems on the simpler code over in the OG textbook repo.

@codecov-io

codecov-io commented Oct 16, 2020

Copy link
Copy Markdown

Codecov Report

Merging #457 (ac4202a) into master (7816335) will increase coverage by 1.51%.
The diff coverage is 84.21%.

❗ Current head ac4202a differs from pull request most recent head 0386723. Consider uploading reports for the commit 0386723 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@## master #457 +/- ##
==========================================
+ Coverage 82.81% 84.32% +1.51% 
==========================================
Files 23 47 +24 Lines 3927 6941 +3014 ==========================================
+ Hits 3252 5853 +2601 - Misses 675 1088 +413 
FlagCoverage Δ
unittests?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
ogusa/firm.py79.47% <70.00%> (-20.53%)⬇️
ogusa/parameters.py84.81% <100.00%> (+0.06%)⬆️
ogusa/tests/test_firm.py100.00% <100.00%> (ø)
ogusa/txfunc.py26.87% <0.00%> (-15.48%)⬇️
ogusa/parameter_plots.py67.05% <0.00%> (-13.99%)⬇️
ogusa/output_tables.py88.94% <0.00%> (-7.80%)⬇️
regression/test_regression.py39.34% <0.00%> (-7.04%)⬇️
ogusa/aggregates.py96.09% <0.00%> (-3.91%)⬇️
ogusa/tax.py98.40% <0.00%> (-0.96%)⬇️
ogusa/demographics.py83.07% <0.00%> (-0.52%)⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7816335...0386723. Read the comment docs.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #457 (ac4202a) into master (5cdaad3) will increase coverage by 0.42%.
The diff coverage is 84.21%.

❗ Current head ac4202a differs from pull request most recent head 9c8dfe5. Consider uploading reports for the commit 9c8dfe5 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@## master #457 +/- ##
==========================================
+ Coverage 83.90% 84.32% +0.42% 
==========================================
Files 20 47 +27 Lines 3448 6941 +3493 ==========================================
+ Hits 2893 5853 +2960 - Misses 555 1088 +533 
FlagCoverage Δ
unittests?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
ogusa/firm.py79.47% <70.00%> (-20.53%)⬇️
ogusa/parameters.py84.81% <100.00%> (-2.98%)⬇️
ogusa/tests/test_firm.py100.00% <100.00%> (ø)
ogusa/TPI.py76.34% <0.00%> (-16.00%)⬇️
ogusa/txfunc.py26.87% <0.00%> (-15.33%)⬇️
ogusa/parameter_plots.py67.05% <0.00%> (-13.99%)⬇️
ogusa/output_tables.py88.94% <0.00%> (-7.80%)⬇️
regression/test_regression.py39.34% <0.00%> (-7.04%)⬇️
ogusa/aggregates.py96.09% <0.00%> (-3.91%)⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cdaad3...9c8dfe5. Read the comment docs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jdebacker@codecov-io@rickecon@codecov-commenter