Httpheader content disposition changed

[ravishanigarapu]

📋 Description

JIRA ID: AMM-1807

Active Signature per doctor

---

✅ Type of Change

• 🐞 Bug fix (non-breaking change which resolves an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 🛠 Refactor (change that is neither a fix nor a new feature)
• ⚙️ Config change (configuration file or build script updates)
• 📚 Documentation (updates to docs or readme)
• 🧪 Tests (adding new or updating existing tests)
• 🎨 UI/UX (changes that affect the user interface)
• 🚀 Performance (improves performance)
• 🧹 Chore (miscellaneous changes that don't modify src or test files)

---

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

• Bug Fixes

  • File downloads now use proper filename encoding, ensuring correct names across browsers and operating systems.
  • Downloads are served as attachments, preventing inline rendering issues.
  • Improved error handling for signature fetches to produce clearer failures.

• Refactor

  • Standardized API endpoints for uploading and downloading employee signatures to improve consistency and reliability.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/signaturerelease

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ravishanigarapu]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

src/main/java/com/iemr/admin/controller/employeemaster/EmployeeSignatureController.java (1)

62-63: Add consumes to POST mapping and reconsider header-based mapping.

• Specify consumes to avoid 415s and be explicit.
• Using headers="Authorization" can break CORS preflight and is redundant if Spring Security enforces auth; verify necessity.

Suggested change:

-	@PostMapping(value = "/upload", headers = "Authorization", produces = {- "application/json" })+	@PostMapping(+ value = "/upload",+ headers = "Authorization",+ consumes = MediaType.APPLICATION_JSON_VALUE,+ produces = MediaType.APPLICATION_JSON_VALUE+	)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 093ba26 and 8820fe2.

📒 Files selected for processing (1)

• src/main/java/com/iemr/admin/controller/employeemaster/EmployeeSignatureController.java (4 hunks)

🔇 Additional comments (2)

src/main/java/com/iemr/admin/controller/employeemaster/EmployeeSignatureController.java (2)

35-37: LGTM on switching to composed mapping annotations.

Clearer and more idiomatic than generic RequestMapping.

---

86-87: Confirm intentional behavior change: inline → attachment.

This forces download for all file types. If any consumers relied on inline preview (PDF/images), this is a breaking change—confirm client readiness or consider a query flag (e.g., ?disposition=inline).

[coderabbitai]

🛠️ Refactor suggestion

Don't use URLEncoder for Content-Disposition; use Spring's ContentDisposition (RFC 5987-compliant).

URLEncoder is for form bodies and turns spaces into '+', producing incorrect download filenames. Prefer ContentDisposition and drop the extra non-standard "filename" header.

Apply imports change:

-import java.net.URLEncoder;+import org.springframework.http.ContentDisposition;+import org.springframework.http.InvalidMediaTypeException;

📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	importjava.net.URLEncoder;
	importjava.nio.charset.StandardCharsets;
	importorg.springframework.http.ContentDisposition;
	importorg.springframework.http.InvalidMediaTypeException;
	importjava.nio.charset.StandardCharsets;

🤖 Prompt for AI Agents

In
src/main/java/com/iemr/admin/controller/employeemaster/EmployeeSignatureController.java
around lines 24-25, replace the URLEncoder import with Spring's
RFC5987-compliant ContentDisposition import and remove the
StandardCharsets/URLEncoder usage; construct the Content-Disposition header
using org.springframework.http.ContentDisposition (e.g.
ContentDisposition.attachment().filename(filename,
StandardCharsets.UTF_8).build().toString()) and set that single header on the
response, and drop the extra non-standard "filename" header so filenames with
spaces and non-ASCII characters are encoded correctly.

[coderabbitai]

⚠️ Potential issue

Bug: URLEncoder in Content-Disposition breaks filenames; also add safe media-type fallback and length.

Spaces become '+', non-ASCII mis-encoded, and an extra custom "filename" header is unnecessary. Use ContentDisposition with UTF-8, default media type to octet-stream on parse failure, and set Content-Length.

Apply this diff:

- String fileName = URLEncoder.encode(userSignID.getFileName(), StandardCharsets.UTF_8);- responseHeaders.set(HttpHeaders.CONTENT_DISPOSITION, "attachment; filename=\"" + fileName + "\"");- responseHeaders.set("filename", fileName);-- return ResponseEntity.ok()- .contentType(MediaType.parseMediaType(userSignID.getFileType())) // or MediaType.APPLICATION_PDF- .headers(responseHeaders)- .body(userSignID.getSignature());+ ContentDisposition contentDisposition = ContentDisposition.attachment()+ .filename(userSignID.getFileName(), StandardCharsets.UTF_8)+ .build();+ responseHeaders.setContentDisposition(contentDisposition);++ MediaType mediaType;+ try {+ mediaType = MediaType.parseMediaType(userSignID.getFileType());+ } catch (InvalidMediaTypeException | NullPointerException ex) {+ mediaType = MediaType.APPLICATION_OCTET_STREAM;+ }++ return ResponseEntity.ok()+ .contentType(mediaType)+ .headers(responseHeaders)+ .contentLength(userSignID.getSignature().length)+ .body(userSignID.getSignature());

📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	StringfileName = URLEncoder.encode(userSignID.getFileName(), StandardCharsets.UTF_8);
	responseHeaders.set(HttpHeaders.CONTENT_DISPOSITION, "attachment; filename=\"" + fileName + "\"");
	responseHeaders.set("filename", fileName);
	returnResponseEntity.ok()
	.contentType(MediaType.parseMediaType(userSignID.getFileType())) // or MediaType.APPLICATION_PDF
	.headers(responseHeaders)
	.body(userSignID.getSignature());
	ContentDispositioncontentDisposition = ContentDisposition.attachment()
	.filename(userSignID.getFileName(), StandardCharsets.UTF_8)
	.build();
	responseHeaders.setContentDisposition(contentDisposition);
	MediaTypemediaType;
	try {
	mediaType = MediaType.parseMediaType(userSignID.getFileType());
	} catch (InvalidMediaTypeException | NullPointerExceptionex) {
	mediaType = MediaType.APPLICATION_OCTET_STREAM;
	}
	returnResponseEntity.ok()
	.contentType(mediaType)
	.headers(responseHeaders)
	.contentLength(userSignID.getSignature().length)
	.body(userSignID.getSignature());

🤖 Prompt for AI Agents

In
src/main/java/com/iemr/admin/controller/employeemaster/EmployeeSignatureController.java
around lines 94-101, replace the URLEncoder usage and custom "filename" header
with Spring's ContentDisposition builder to correctly encode filenames
(including UTF-8 and non-ASCII) in the Content-Disposition header, remove the
extra "filename" header, parse the media type but fall back to
MediaType.APPLICATION_OCTET_STREAM if parsing fails, and set the Content-Length
header from userSignID.getSignature().length; construct ResponseEntity with
these corrected headers and body.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud