Skip to content

⚙️ [Maintenance]: Require Pester 6.x in test files - #35

Draft
Marius Storhaug (MariusStorhaug) wants to merge 3 commits into
mainfrom
maintenance/lock-pester-major-6
Draft

⚙️ [Maintenance]: Require Pester 6.x in test files#35
Marius Storhaug (MariusStorhaug) wants to merge 3 commits into
mainfrom
maintenance/lock-pester-major-6

Conversation

@MariusStorhaug

@MariusStorhaugMarius Storhaug (MariusStorhaug) commented Jul 7, 2026

Copy link
Copy Markdown
Member

Pester tests in this module now require the Pester 6.x major version, so every contributor and CI run resolves the same major and a new Pester major can't slip in and break the suite. The tests previously declared no framework requirement and ran on whatever Pester happened to be installed.

Changed: tests are locked to the Pester 6.x major

Every *.Tests.ps1 file now starts with a version-bounded requirement:

#Requires -Modules@{ ModuleName='Pester'; ModuleVersion='6.0.0'; MaximumVersion='6.*' }

Any Pester 6.x satisfies it, so minor and patch releases flow in automatically while moving to a new major stays a deliberate, reviewed change. No module source or behaviour changes.

Technical Details

CopilotAI review requested due to automatic review settings July 7, 2026 15:45
@github-actions

Copy link
Copy Markdown

No Significant Changes Detected

This PR does not contain changes to files that would trigger a new release:

PathDescription
src/**Module source code
README.mdDocumentation

Build, test, and publish stages will be skipped for this PR.

If you believe this is incorrect, please verify that your changes are in the correct locations.

@github-actions

Copy link
Copy Markdown

Super-linter summary

LanguageValidation result
CHECKOVPass ✅
GITHUB_ACTIONSPass ✅
GITLEAKSPass ✅
GIT_MERGE_CONFLICT_MARKERSPass ✅
MARKDOWNPass ✅
NATURAL_LANGUAGEPass ✅
POWERSHELLPass ✅
PRE_COMMITPass ✅
SPELL_CODESPELLFail ❌
TRIVYPass ✅
YAMLPass ✅

Super-linter detected linting errors

For more information, see the GitHub Actions workflow run

Powered by Super-linter

SPELL_CODESPELL
/github/workspace/src/functions/private/Core/Get-WoWCacheFolder.ps1:28: doen't ==> doesn't

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the module’s Pester test script to explicitly require Pester 6.x at discovery time, aligning test execution with the intended dependency constraints.

Changes:

  • Adds a #Requires -Modules directive to tests/WoW.Tests.ps1 to enforce a Pester version constraint (and GUID pin) before tests run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadtests/WoW.Tests.ps1 Outdated
The GUID pins module identity (precise pinning), a stricter control than the lock-to-major risk appetite. Keep only the version range.
@github-actions

Copy link
Copy Markdown

No Significant Changes Detected

This PR does not contain changes to files that would trigger a new release:

PathDescription
src/**Module source code
README.mdDocumentation

Build, test, and publish stages will be skipped for this PR.

If you believe this is incorrect, please verify that your changes are in the correct locations.

@github-actions

Copy link
Copy Markdown

Super-linter summary

LanguageValidation result
CHECKOVPass ✅
GITHUB_ACTIONSPass ✅
GITLEAKSPass ✅
GIT_MERGE_CONFLICT_MARKERSPass ✅
MARKDOWNPass ✅
NATURAL_LANGUAGEPass ✅
POWERSHELLPass ✅
PRE_COMMITPass ✅
SPELL_CODESPELLFail ❌
TRIVYPass ✅
YAMLPass ✅

Super-linter detected linting errors

For more information, see the GitHub Actions workflow run

Powered by Super-linter

SPELL_CODESPELL
/github/workspace/src/functions/private/Core/Get-WoWCacheFolder.ps1:28: doen't ==> doesn't

@MariusStorhaug
Marius Storhaug (MariusStorhaug) marked this pull request as draft July 12, 2026 09:58
CopilotAI review requested due to automatic review settings July 12, 2026 09:58
@github-actions

Copy link
Copy Markdown

No Significant Changes Detected

This PR does not contain changes to files that would trigger a new release:

PatternDescription
^src/Matches files where path matches this pattern
^README\.md$Matches files where path matches this pattern

Build, test, and publish stages will be skipped for this PR.

If you believe this is incorrect, please verify that your changes are in the correct locations.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread.github/workflows/Process-PSModule.yml
@github-actions

Copy link
Copy Markdown

Super-linter summary

LanguageValidation result
CHECKOVPass ✅
GITHUB_ACTIONSPass ✅
GITLEAKSPass ✅
GIT_MERGE_CONFLICT_MARKERSPass ✅
MARKDOWNPass ✅
NATURAL_LANGUAGEPass ✅
POWERSHELLPass ✅
PRE_COMMITPass ✅
SPELL_CODESPELLFail ❌
TRIVYPass ✅
YAMLPass ✅

Super-linter detected linting errors

For more information, see the GitHub Actions workflow run

Powered by Super-linter

SPELL_CODESPELL
/github/workspace/src/functions/private/Core/Get-WoWCacheFolder.ps1:28: doen't ==> doesn't

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MariusStorhaug