Uh oh!
There was an error while loading. Please reload this page.
Add character counter to most text input boxes - #34
Merged
maplethorpej merged 1 commit intoJan 14, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds character counters to the following text entry areas:
Pack View
Inventory Sidebar View
The character counter text color changes to red if the entered length is greater than the allowed length. The allowed length values were found in the database. It is certainly possible to set a "max length" where the user would not be able to enter more than the allowed length, but since users are very likely to be copy/pasting data, I don't think we'd want to automatically trim it. I think just showing that they are over the max is enough.
Along the same lines, I think it would be worth improving the error messages. If you try to save a pack or an item with text that is too long, it just shows a generic error. I think it would be nice to specify what field caused the error (if that could be determined). Or at the minimum, don't allow the user to click "Add Item" or "Save Pack" if any of the fields are over their allowed limit.