Uh oh!
There was an error while loading. Please reload this page.
Add unsaved changes alert for pack changes - #41
Merged
maplethorpej merged 4 commits intoFeb 13, 2021
Conversation
maplethorpej
commented
Jan 14, 2021
Collaborator
This is great 🎉 |
maplethorpej
commented
Jan 14, 2021
Collaborator
Looks like it will require the conflict to be resolved and then we can merge it. @darinalleman |
darinalleman
commented
Jan 14, 2021
ContributorAuthor
Conflicts resolved! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show a warning if there are pending unsaved changes in the pack edit view when trying to navigate away.
My screen recorder won't show it, but if you try to close the tab or refresh it will do a normal JS alert to prevent the page from closing. Closes#10.
10-show-unsaved-warning.mp4