Uh oh!
There was an error while loading. Please reload this page.
Add PersistentDataContainerView#getSize - #13157
Merged
Owen1212055 merged 3 commits intoOct 17, 2025
Merged
Conversation
Strokkur424
commented
Oct 8, 2025
Member
I wonder, what is the use case for such a method? |
ContributorAuthor
Need to cap the amount of tags in this case an entity can have (users can give it tags with a custom coding language) to 500, getting the size currently either clones the entire keyset (when using getKeys()) or (what we do atm) you use the underlying bukkit implementation and getRaw() to call .size() on that |
Warriorrrr
approved these changes
Oct 11, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Warrior <50800980+Warriorrrr@users.noreply.github.com>
Owen1212055
approved these changes
Oct 17, 2025
jpenilla
approved these changes
Oct 17, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the getSize method to the PersistentDataContainerView