Skip to content

[WIP] New Plugin Life-cycle API - #4319

Closed
JRoy wants to merge 4 commits into
PaperMC:masterfrom
JRoy:feature/plugin-cycle-api
Closed

[WIP] New Plugin Life-cycle API #4319
JRoy wants to merge 4 commits into
PaperMC:masterfrom
JRoy:feature/plugin-cycle-api

Conversation

@JRoy

@JRoyJRoy commented Sep 12, 2020

Copy link
Copy Markdown
Member

WIP PR for the new plugin life-cycle API.

See #4317 for a better description

@ProximystProximyst added the type: feature Request for a new Feature. label Oct 3, 2020
kashike
kashike requested changes Oct 5, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch Outdated
Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch Outdated
Proximyst
Proximyst suggested changes Nov 14, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch
Comment on lines +21 to +27
+ * <li>Reloads all configs
+ * <li>Reloads server icon
+ * <li>Reloads ban lists
+ * <li>Reloads all plugins that which both their dependencies and themselves meet one the following:
+ * <ul>
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#ALWAYS ALWAYS} reload policy.
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#SAME_HASH SAME_HASH} reload policy and the plugin's file is unmodified from startup.

@ProximystProximystNov 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cries in </li>

Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch
+ */
+ public static PluginReloadPolicy getByName(@NotNull String name) {
+ try {
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));

@ProximystProximystNov 14, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replace("-", "_"));

Don't correct the user; them entering e.g. 123 is not grounds for Paper to care as that's their fault. The replacing - -> _ is however alright as that's a very easy thing to fuck up (cough Bungee & depend/-s...).

@stale

staleBot commented Feb 18, 2021

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale

staleBot commented Feb 25, 2021

Copy link
Copy Markdown

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.

@stalestaleBot closed this Feb 25, 2021
@MiniDiggerMiniDigger reopened this Feb 25, 2021
@JRoyJRoy closed this Feb 25, 2021
@JRoy
JRoy deleted the feature/plugin-cycle-api branch February 25, 2021 14:33
@JRoy
JRoy restored the feature/plugin-cycle-api branch February 25, 2021 14:33
@JRoyJRoy reopened this Feb 25, 2021
@JRoy

JRoy commented Jul 29, 2022

Copy link
Copy Markdown
MemberAuthor

being continued by @Owen1212055 in #8108

@JRoyJRoy closed this Jul 29, 2022
@JRoy
JRoy deleted the feature/plugin-cycle-api branch July 29, 2022 15:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kashikekashikekashike requested changes
+1 more reviewer
@ProximystProximystProximyst requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: rebase requiredtype: featureRequest for a new Feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JRoy@kashike@Proximyst@MiniDigger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[WIP] New Plugin Life-cycle API by JRoy · Pull Request #4319 · PaperMC/Paper · GitHub
Skip to content
[WIP] New Plugin Life-cycle API  - #4319
Closed
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Closed
[WIP] New Plugin Life-cycle API #4319
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Conversation
@JRoy
@JRoyJRoy
commented
Sep 12, 2020

Copy link


Copy Markdown

Member
WIP PR for the new plugin life-cycle API.
See #4317 for a better description
@ProximystProximyst
added
the 
type: feature
Request for a new Feature.
label
Oct 3, 2020
kashike
kashike
requested changes
Oct 5, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Proximyst
Proximyst
suggested changes
Nov 14, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch

Comment on lines

+21
 to 
+27

+ * <li>Reloads all configs
+ * <li>Reloads server icon
+ * <li>Reloads ban lists
+ * <li>Reloads all plugins that which both their dependencies and themselves meet one the following:
+ * <ul>
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#ALWAYS ALWAYS} reload policy.
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#SAME_HASH SAME_HASH} reload policy and the plugin's file is unmodified from startup.
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cries in </li>
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch
+ */
+ public static PluginReloadPolicy getByName(@NotNull String name) {
+ try {
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replace("-", "_"));
Don't correct the user; them entering e.g. 123 is not grounds for Paper to care as that's their fault. The replacing - -> _ is however alright as that's a very easy thing to fuck up (cough Bungee & depend/-s...).
@stale
staleBot
commented
Feb 18, 2021

Copy link


Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale
staleBot
commented
Feb 25, 2021

Copy link


Copy Markdown

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.
@stalestaleBot
closed this
Feb 25, 2021
@MiniDiggerMiniDigger
reopened this
Feb 25, 2021
@JRoyJRoy
closed this
Feb 25, 2021
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoy
JRoy
restored the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoyJRoy
reopened this
Feb 25, 2021
@JRoy
JRoy
commented
Jul 29, 2022

Copy link


Copy Markdown

MemberAuthor
being continued by @Owen1212055 in #8108
@JRoyJRoy
closed this
Jul 29, 2022
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
July 29, 2022 15:51
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kashikekashikekashike requested changes

+1 more reviewer

@ProximystProximystProximyst requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: rebase requiredtype: featureRequest for a new Feature.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@JRoy@kashike@Proximyst@MiniDigger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[WIP] New Plugin Life-cycle API by JRoy · Pull Request #4319 · PaperMC/Paper · GitHub
Skip to content
[WIP] New Plugin Life-cycle API  - #4319
Closed
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Closed
[WIP] New Plugin Life-cycle API #4319
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Conversation
@JRoy
@JRoyJRoy
commented
Sep 12, 2020

Copy link


Copy Markdown

Member
WIP PR for the new plugin life-cycle API.
See #4317 for a better description
@ProximystProximyst
added
the 
type: feature
Request for a new Feature.
label
Oct 3, 2020
kashike
kashike
requested changes
Oct 5, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Proximyst
Proximyst
suggested changes
Nov 14, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch

Comment on lines

+21
 to 
+27

+ * <li>Reloads all configs
+ * <li>Reloads server icon
+ * <li>Reloads ban lists
+ * <li>Reloads all plugins that which both their dependencies and themselves meet one the following:
+ * <ul>
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#ALWAYS ALWAYS} reload policy.
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#SAME_HASH SAME_HASH} reload policy and the plugin's file is unmodified from startup.
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cries in </li>
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch
+ */
+ public static PluginReloadPolicy getByName(@NotNull String name) {
+ try {
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replace("-", "_"));
Don't correct the user; them entering e.g. 123 is not grounds for Paper to care as that's their fault. The replacing - -> _ is however alright as that's a very easy thing to fuck up (cough Bungee & depend/-s...).
@stale
staleBot
commented
Feb 18, 2021

Copy link


Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale
staleBot
commented
Feb 25, 2021

Copy link


Copy Markdown

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.
@stalestaleBot
closed this
Feb 25, 2021
@MiniDiggerMiniDigger
reopened this
Feb 25, 2021
@JRoyJRoy
closed this
Feb 25, 2021
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoy
JRoy
restored the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoyJRoy
reopened this
Feb 25, 2021
@JRoy
JRoy
commented
Jul 29, 2022

Copy link


Copy Markdown

MemberAuthor
being continued by @Owen1212055 in #8108
@JRoyJRoy
closed this
Jul 29, 2022
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
July 29, 2022 15:51
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kashikekashikekashike requested changes

+1 more reviewer

@ProximystProximystProximyst requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: rebase requiredtype: featureRequest for a new Feature.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@JRoy@kashike@Proximyst@MiniDigger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[WIP] New Plugin Life-cycle API by JRoy · Pull Request #4319 · PaperMC/Paper · GitHub
Skip to content
[WIP] New Plugin Life-cycle API  - #4319
Closed
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Closed
[WIP] New Plugin Life-cycle API #4319
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Conversation
@JRoy
@JRoyJRoy
commented
Sep 12, 2020

Copy link


Copy Markdown

Member
WIP PR for the new plugin life-cycle API.
See #4317 for a better description
@ProximystProximyst
added
the 
type: feature
Request for a new Feature.
label
Oct 3, 2020
kashike
kashike
requested changes
Oct 5, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Proximyst
Proximyst
suggested changes
Nov 14, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch

Comment on lines

+21
 to 
+27

+ * <li>Reloads all configs
+ * <li>Reloads server icon
+ * <li>Reloads ban lists
+ * <li>Reloads all plugins that which both their dependencies and themselves meet one the following:
+ * <ul>
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#ALWAYS ALWAYS} reload policy.
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#SAME_HASH SAME_HASH} reload policy and the plugin's file is unmodified from startup.
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cries in </li>
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch
+ */
+ public static PluginReloadPolicy getByName(@NotNull String name) {
+ try {
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replace("-", "_"));
Don't correct the user; them entering e.g. 123 is not grounds for Paper to care as that's their fault. The replacing - -> _ is however alright as that's a very easy thing to fuck up (cough Bungee & depend/-s...).
@stale
staleBot
commented
Feb 18, 2021

Copy link


Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale
staleBot
commented
Feb 25, 2021

Copy link


Copy Markdown

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.
@stalestaleBot
closed this
Feb 25, 2021
@MiniDiggerMiniDigger
reopened this
Feb 25, 2021
@JRoyJRoy
closed this
Feb 25, 2021
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoy
JRoy
restored the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoyJRoy
reopened this
Feb 25, 2021
@JRoy
JRoy
commented
Jul 29, 2022

Copy link


Copy Markdown

MemberAuthor
being continued by @Owen1212055 in #8108
@JRoyJRoy
closed this
Jul 29, 2022
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
July 29, 2022 15:51
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kashikekashikekashike requested changes

+1 more reviewer

@ProximystProximystProximyst requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: rebase requiredtype: featureRequest for a new Feature.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@JRoy@kashike@Proximyst@MiniDigger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[WIP] New Plugin Life-cycle API by JRoy · Pull Request #4319 · PaperMC/Paper · GitHub
Skip to content
[WIP] New Plugin Life-cycle API  - #4319
Closed
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Closed
[WIP] New Plugin Life-cycle API #4319
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Conversation
@JRoy
@JRoyJRoy
commented
Sep 12, 2020

Copy link


Copy Markdown

Member
WIP PR for the new plugin life-cycle API.
See #4317 for a better description
@ProximystProximyst
added
the 
type: feature
Request for a new Feature.
label
Oct 3, 2020
kashike
kashike
requested changes
Oct 5, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Proximyst
Proximyst
suggested changes
Nov 14, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch

Comment on lines

+21
 to 
+27

+ * <li>Reloads all configs
+ * <li>Reloads server icon
+ * <li>Reloads ban lists
+ * <li>Reloads all plugins that which both their dependencies and themselves meet one the following:
+ * <ul>
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#ALWAYS ALWAYS} reload policy.
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#SAME_HASH SAME_HASH} reload policy and the plugin's file is unmodified from startup.
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cries in </li>
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch
+ */
+ public static PluginReloadPolicy getByName(@NotNull String name) {
+ try {
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replace("-", "_"));
Don't correct the user; them entering e.g. 123 is not grounds for Paper to care as that's their fault. The replacing - -> _ is however alright as that's a very easy thing to fuck up (cough Bungee & depend/-s...).
@stale
staleBot
commented
Feb 18, 2021

Copy link


Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale
staleBot
commented
Feb 25, 2021

Copy link


Copy Markdown

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.
@stalestaleBot
closed this
Feb 25, 2021
@MiniDiggerMiniDigger
reopened this
Feb 25, 2021
@JRoyJRoy
closed this
Feb 25, 2021
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoy
JRoy
restored the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoyJRoy
reopened this
Feb 25, 2021
@JRoy
JRoy
commented
Jul 29, 2022

Copy link


Copy Markdown

MemberAuthor
being continued by @Owen1212055 in #8108
@JRoyJRoy
closed this
Jul 29, 2022
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
July 29, 2022 15:51
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kashikekashikekashike requested changes

+1 more reviewer

@ProximystProximystProximyst requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: rebase requiredtype: featureRequest for a new Feature.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@JRoy@kashike@Proximyst@MiniDigger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[WIP] New Plugin Life-cycle API by JRoy · Pull Request #4319 · PaperMC/Paper · GitHub
Skip to content
[WIP] New Plugin Life-cycle API  - #4319
Closed
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Closed
[WIP] New Plugin Life-cycle API #4319
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Conversation
@JRoy
@JRoyJRoy
commented
Sep 12, 2020

Copy link


Copy Markdown

Member
WIP PR for the new plugin life-cycle API.
See #4317 for a better description
@ProximystProximyst
added
the 
type: feature
Request for a new Feature.
label
Oct 3, 2020
kashike
kashike
requested changes
Oct 5, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Proximyst
Proximyst
suggested changes
Nov 14, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch

Comment on lines

+21
 to 
+27

+ * <li>Reloads all configs
+ * <li>Reloads server icon
+ * <li>Reloads ban lists
+ * <li>Reloads all plugins that which both their dependencies and themselves meet one the following:
+ * <ul>
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#ALWAYS ALWAYS} reload policy.
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#SAME_HASH SAME_HASH} reload policy and the plugin's file is unmodified from startup.
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cries in </li>
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch
+ */
+ public static PluginReloadPolicy getByName(@NotNull String name) {
+ try {
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replace("-", "_"));
Don't correct the user; them entering e.g. 123 is not grounds for Paper to care as that's their fault. The replacing - -> _ is however alright as that's a very easy thing to fuck up (cough Bungee & depend/-s...).
@stale
staleBot
commented
Feb 18, 2021

Copy link


Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale
staleBot
commented
Feb 25, 2021

Copy link


Copy Markdown

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.
@stalestaleBot
closed this
Feb 25, 2021
@MiniDiggerMiniDigger
reopened this
Feb 25, 2021
@JRoyJRoy
closed this
Feb 25, 2021
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoy
JRoy
restored the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoyJRoy
reopened this
Feb 25, 2021
@JRoy
JRoy
commented
Jul 29, 2022

Copy link


Copy Markdown

MemberAuthor
being continued by @Owen1212055 in #8108
@JRoyJRoy
closed this
Jul 29, 2022
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
July 29, 2022 15:51
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kashikekashikekashike requested changes

+1 more reviewer

@ProximystProximystProximyst requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: rebase requiredtype: featureRequest for a new Feature.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@JRoy@kashike@Proximyst@MiniDigger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[WIP] New Plugin Life-cycle API by JRoy · Pull Request #4319 · PaperMC/Paper · GitHub
Skip to content
[WIP] New Plugin Life-cycle API  - #4319
Closed
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Closed
[WIP] New Plugin Life-cycle API #4319
JRoy wants to merge 4 commits into
PaperMC:masterfrom 
JRoy:feature/plugin-cycle-api
Conversation
@JRoy
@JRoyJRoy
commented
Sep 12, 2020

Copy link


Copy Markdown

Member
WIP PR for the new plugin life-cycle API.
See #4317 for a better description
@ProximystProximyst
added
the 
type: feature
Request for a new Feature.
label
Oct 3, 2020
kashike
kashike
requested changes
Oct 5, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Comment threadSpigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated

Proximyst
Proximyst
suggested changes
Nov 14, 2020
View reviewed changes
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch

Comment on lines

+21
 to 
+27

+ * <li>Reloads all configs
+ * <li>Reloads server icon
+ * <li>Reloads ban lists
+ * <li>Reloads all plugins that which both their dependencies and themselves meet one the following:
+ * <ul>
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#ALWAYS ALWAYS} reload policy.
+ * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#SAME_HASH SAME_HASH} reload policy and the plugin's file is unmodified from startup.
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cries in </li>
Comment threadSpigot-API-Patches/0232-Add-plugin-reload-policy.patch
+ */
+ public static PluginReloadPolicy getByName(@NotNull String name) {
+ try {
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
@ProximystProximystNov 14, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

+ return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_"));
+ return valueOf(name.toUpperCase(Locale.ENGLISH).replace("-", "_"));
Don't correct the user; them entering e.g. 123 is not grounds for Paper to care as that's their fault. The replacing - -> _ is however alright as that's a very easy thing to fuck up (cough Bungee & depend/-s...).
@stale
staleBot
commented
Feb 18, 2021

Copy link


Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale
staleBot
commented
Feb 25, 2021

Copy link


Copy Markdown

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.
@stalestaleBot
closed this
Feb 25, 2021
@MiniDiggerMiniDigger
reopened this
Feb 25, 2021
@JRoyJRoy
closed this
Feb 25, 2021
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoy
JRoy
restored the

feature/plugin-cycle-api

branch
February 25, 2021 14:33
@JRoyJRoy
reopened this
Feb 25, 2021
@JRoy
JRoy
commented
Jul 29, 2022

Copy link


Copy Markdown

MemberAuthor
being continued by @Owen1212055 in #8108
@JRoyJRoy
closed this
Jul 29, 2022
@JRoy
JRoy
deleted the

feature/plugin-cycle-api

branch
July 29, 2022 15:51
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kashikekashikekashike requested changes

+1 more reviewer

@ProximystProximystProximyst requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: rebase requiredtype: featureRequest for a new Feature.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@JRoy@kashike@Proximyst@MiniDigger