Uh oh!
There was an error while loading. Please reload this page.
Fix Cost efficiency math and add mods to breakdown - #10004
Merged
Conversation
LocalIdentity
approved these changes
Jul 25, 2026
Uh oh!
There was an error while loading. Please reload this page.
vaisest added a commit
to vaisest/PathOfBuilding
that referenced
this pull request
Jul 26, 2026
…munity#10004) * Fix mana cost efficiency order of operations and add mods to breakdown * Add life and es cost tests * Fix RageCostNoMult mod name
DrakenKor pushed a commit
to DrakenKor/PathOfBuilding
that referenced
this pull request
Jul 27, 2026
…munity#10004) * Fix mana cost efficiency order of operations and add mods to breakdown * Add life and es cost tests * Fix RageCostNoMult mod name
vaisest added a commit
to vaisest/PathOfBuilding
that referenced
this pull request
Jul 28, 2026
…munity#10004) * Fix mana cost efficiency order of operations and add mods to breakdown * Add life and es cost tests * Fix RageCostNoMult mod name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#10003
Description of the problem being solved:
Math didn't line up with in-game where cost efficiency is added after other modifiers.
I also forgot to add the mods to the breakdown list, which I also fixed here.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/tr2e_xC5GInF
Before screenshot:
After screenshot: