Skip to content

Add gem quality for matching socket based on equipped item - #10022

Merged
LocalIdentity merged 12 commits into
PathOfBuildingCommunity:devfrom
vaisest:import-quality
Aug 4, 2026
Merged

Add gem quality for matching socket based on equipped item#10022
LocalIdentity merged 12 commits into
PathOfBuildingCommunity:devfrom
vaisest:import-quality

Conversation

@vaisest

@vaisestvaisest commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

3.29 added a mechanic where gems that are in the matching colour sockets adds +10% quality. This PR adds handling for that, and in general socket-related things which are actually relevant because of that change.

Steps taken to verify a working solution:

  • Matching gems tested
  • "White" gems tested -> no quality is added. In the future if GGG happens to add a bonus for these, it should be easy to add
  • On load, quality is added correctly. Skills are loaded before items, but the matching sockets are separately checked.
  • Quality is added when equipping or unequipping items
  • Quality is communicated through coloured gem quality edit boxes
  • Quality is separated by type in tooltips similar to the way they are in in-game tooltips
  • Split links (i.e., multiple groups per item) are handled by assuming that they are kept in the correct order
  • Dialla's malefaction always grants the bonus
  • Optimise sockets button makes the colours correct on an equipped item, and doesn't make the item have too many sockets

Currently this PR does NOT handle empty sockets at all. This is clearly problematic since the gems will not match the correct sockets if the gaps are missing, but solving this for sure requires changing the way socket groups are handled or saved, and so I think it's best done later in a separate PR. This PR intentionally makes no changes to the way gems are saved.

Link to a build that showcases this PR:

Nearly any character should work.

Dialla's: https://poe.ninja/poe1/builds/allflame?items=Dialla%27s+Malefaction

All 4 types of quality at once (ground slam group): https://poe.ninja/poe1/pob/9519e

Before screenshot:

imageimage

After screenshot:

image
Path.space.of.space.Building_2026-08-02_17-07-30.mp4
imageAwakened_PoE_Trade_2026-08-02_18-28-00image

@vaisestvaisest changed the title Add 10 quality for matching socket colour on importAdd quality bonus for matching socket based on equipped itemAug 2, 2026
@vaisestvaisest changed the title Add quality bonus for matching socket based on equipped itemAdd gem quality for matching socket based on equipped itemAug 2, 2026
@vaisestvaisest closed this Aug 2, 2026
@vaisestvaisest reopened this Aug 2, 2026
@vaisestvaisest added the enhancement New feature, calculation, or mod label Aug 2, 2026
LocalIdentity added 2 commits August 4, 2026 16:06
Clicking optimise socket now creates an undo state
Optimise now calls buildflag so the stats update on gems when clicking
Now resets the socket colours when changing the item the sockets use

@LocalIdentityLocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now. I'd like a better solution in the future but that requires a lot larger rework of gems and the items

@LocalIdentity
LocalIdentity merged commit e1d4836 into PathOfBuildingCommunity:devAug 4, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vaisest@LocalIdentity