Uh oh!
There was an error while loading. Please reload this page.
Add Talisman enchants to trader - #10078
Merged
LocalIdentity merged 2 commits intoAug 3, 2026
Merged
Conversation
Add talisman enchant modifiers to trade queries and only include them when the talisman option is enabled. Also fixes utility flask charge enchants and adds tests for the new behaviour.
LocalIdentity
approved these changes
Aug 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Talisman implicits became enchants and thus weren't included in QueryMods.lua. This exports the enchant mod ids and adds them to QueryMods.lua. I also changed the talisman checkbox to default to off, because otherwise the search is completely useless. It could also be a good idea to separate amulet and talisman completely so that the amulet implicits and talisman enchants never appear in the same search, but the explicit mods seem to be the same so I'm not sure that makes a lot of sense.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe1/pob/94aa6
Before screenshot:
After screenshot: