Uh oh!
There was an error while loading. Please reload this page.
Allow recursive build list search with class filtering - #10084
Merged
LocalIdentity merged 4 commits intoAug 3, 2026
Conversation
Wires77
reviewed
Aug 1, 2026
| if not fileHnd then return nil, nil, nil end | ||
| local headerText = fileHnd:read(2048) | ||
| fileHnd:close() | ||
| if not headerText then return nil, nil, nil end |
Member
There was a problem hiding this comment.
Can we keep using OpenCloudErrorPopup here? I believe we've mitigated many of the root causes, but I'd like to keep this error pop-up in case people run into Cloud syncing issues
Fix recursive build search safety and performance Cache the recursive build index so searches filter in memory instead of rescanning files on every keystroke. Prevent folders from being copied or moved into their own descendants, preserve selections using full paths, and restore cloud-read error reporting. Also fix folder copy paths and add regression tests for filtering, duplicate filenames, cloud failures, and unsafe folder targets.
LocalIdentity
approved these changes
Aug 3, 2026
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I fixed a few issues with my commit
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Like many others, I like to organize my past builds into folders, this however makes searching for specific builds very hard, because current control doesn't search recursively.
I solved both problems by making the search recursive, and allowing for some basic class filtering:
class:assassin poison.Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: