Skip to content

Fix being unable to set Enemy Resistance to 0 in config tab - #10091

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
cupkax:fix-zero-treated-as-nil
Aug 3, 2026
Merged

Fix being unable to set Enemy Resistance to 0 in config tab#10091
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
cupkax:fix-zero-treated-as-nil

Conversation

@cupkax

Copy link
Copy Markdown
Contributor

Fixes#10090 .

Description of the problem being solved:

Zero values for res in config tab were treated as nil. This MR uses countAllowZero to allow setting zero for res

Steps taken to verify a working solution:

  • Set zero values for each of the resistances to record change in DPS

Link to a build that showcases this PR:

eNrtPWlT48iSn4dfoWBjNvZFG9B99Ha_FwYMpofDbUPTzRdC2GWsRpaMDsDTwX_fzCqdti4fb2P27ZuOYKxSHlVZmVmZVaWqT_94m9rcC_F8y3U-7wr7_C5HnKE7spzHz7s31yd7-u4__r7zqWcGk6vxYWjZ-ObvO799or850x8SZ3Rkm75_aU7J592jiUXGgWk5u9wwLb0wPTMcEW-Xs8kLsYERD4xeLPJ64Y7g_dlF76p_vcs9mM7ICj7vXroO2eWmQGbgDp9IcOq54QywgOgESA0D4p0joXYYuIzC2LR9QJmZTjAhrnNhOa536o5iUkm5-TNXHpjeIwm-xe2X7vldaNxvn3q2OSfeIDAD7sW0Q2BgSIKh7kvKLudD6efdNgjNfCTH5hT-7h6shnUYen5QgyrtixKvqUb0N6YwmBEyKkXSYrCeRzrjMRkG1gs58qzgaGI6Q1KP1wBWyMJehHZgzWwL-rYUHvuaYXRriUu8wBvKvhFjXLuBaR_3BqUIfB7SDRqTvrWCyaEN0qwiL4rQhfuqISmaYghqjHv26FgBqUKURJkXtX2FYYpZpg2QC6racy3fddaoayyYRlI8Cm0bLLwRbJ_4xHsxA6u6WiWSOHKnD5ZTI_39RNnaHjGvxkyn--bICv0LEnjEL8XVY8wL0zGPXD-obxBC9ogHLi2oRBCVfV1WBUWif-UF9AEZuuATV-XYDFMGzpl_MZ1za0yacUTIJm0UlH1VlSVJoX_VBfRV2pjhuCJmZ9AUbmXC61WoDw67GeTADe1KSElMYYMK56lJqbk9V0KKiWkdk7eGBCshlYTgmVOhKIKQIVgFyaf1e3HRa1QYmC7w0r4gyKIgq2LOk3W6vXI8nZcSLr3J3LeGpn1hvlnTcApjz7X5RMqZGrquGqnSPk4CBzzhWtgnlkfWQjxy7VFTRFnSjHQsnpiu3xhTTXXlajzuQtTVHg5DCKzmpTiKxOecQIU-6JlYZfgRgc-cYWPCN45Hx5WKKGcRpQ8mjIHVg02aRCF5LpEnqNApcd_Ic3skTsSyXF6apO3ruiywEE7IEjgnZDg5heC2bwYVIZmQGyUauByUNoJWSTtj1AjaQNiisC_zuqzwGi-LolKMXSdEQdzPDZPNZKhqpeNsMxkKQuLsOg7xHucDSE_s0arwcUWPzFm5mPL9kEWv6g--mF8T6RSiNpNLgnpreuXSkHPjXrPRsVnVBVna59WFEJVmlMeIX6W9kBXpcg7vkgT9aizJ2NczWICQ2HEjjQWERGnrxQDQS51ZruKKlKrci-lXjYoLGsagq5RLTkhfEEh0AGNEavKvFKXnuT8xf7Sb4Smyxqex-tQNKyKVtONpSxh4VUOMpUGdJc99MgqHlZFEGjwk6fCh7Q6f6tJQdQkNqmrbTXBTMQSBOXw6dkePpCkKZdIEQ1GKKzgIZzNwyqgZNRT0XLQCuZxVEa2mfZsCX4GJV3lEPRfV1DCQCoCbM0iitcZcFjDqWGlKLtCqYaOqBdB1LIR9UV7q0wvwo1MYWOmsz4U7qor-NQlyNpFl2UlvQTq_xpQBRcvOGER0Bk-WbacseVnSpX3EAvsdQhH8Qoie6QGRQ2JOubPpzHapV4tIy2_csfUCiT93aJt-wLljDtP5jKoW8VquZ8SxlFa2JjHvQwJAbPaFazTD0XNfodMmOElYPtEgFUFDKF5P_sQjzp_zxvRz4FUMUt_gjCCqB3HU8SjFSNlcW1MYRHz_2AxMbhRlcN9MD8QdCHRWcKFQZFOFdAL3xLID4h2DGSBtJgJiesPJORSdmLb9AJ6SdlRSCk_I-NMBjQvwF-iS6wUcecP_Yc_O43lfCnjkOmPrkTPZnCd9GJAAK0Hrn5RwgRXYqDpkbIZ2sMtZoxgIeDizMOAcOmuN8wIWNghQ_XBKRkeuN_Mx2wCLtOe73IPr2sR0Pu8GXhhpb57CNJkdpREU54TTB-LBeGYUQROHTOcZZ5yA80XQSe06iHZMHizbgi6ESL6-XgnujU9GEAMOvfkKrRqGfuBOwRv5qDUeXSr4D-7UDIcTsrO3B-mnz03MF8JBzvU7zthDl3OBywUeAY2j1eUuQKSgEVzHpv7NtDnWaApLldLnTJ-zHPCa0Kadono8hOPx5SMEApPwxIYSvz16YbbfXAC0NswlrCQ4NB74nwlBbtJNQhFG6JMlKyzmA1Y5JBMY_UAsGYVgE_4JE43nyxF869Gyr8bUEUENKa-l2pXwSUbEaF0iQRRFuQIXnQKJDTvDTSlHmSWR5TKezNdUE-2jBwF1giHVtQsXilJwSAOq4emQvSgD3VBr0KKA1LXtvulkUbWKFqX-AWf4iUdGAwwZj9wQhnxij5vJk1UbSlaSS2alJ8FpwmQ19RgMXfDntFXr6GLTFqWCpAbdhRHFfQV86hea8y1yvkqdRkbZToKgCoZuNFGyRU5SBafBBMbRVcUYJ5QpAg-ZdxMp5gXI-PbJFKLR0eG8bdvzNfpyZcFm0obmSPkEsamaJr2_Bhoa0iJaVVcOWSACmW_gmfa19QhBIxr8khl-OkhiFhoIsSf8ee0R8s0ir9yfrjv98Xl3TzekfUmVRAEclWhgfDxxX3GMOrYglYC4cUj8aLShON9RF3QeImpVlw1Bx1lBLD9ny_NGHIgNAi-Ow2g87kOQR6OmUxLDOq43TSbZGeNz8mgO5wDiJwvzPoRsWHA4h8A7rgmtJCSs7N31fIaVbJ-f72a4fA1NiGvmbIKNxXa0JlFolyd8ghMu-aVFKsgYIxfqsQQDNxm0U7KUpuUM7XBEzpwoFYnruwB7ZNpDnyLY5gOKAvdO4CT0KEKgfH77BNWjXY9dXpWxPJLp2QjnagJzBEH2wVkA7TrAxh1QfvCLIVPcTIaTVoTxP7XdB9MWEzEjHFLOYLft4HseXIjBh6iMMBInmzVEfrFhEKHREL-QaCbxgho9x_2XmMSiQNDsOHD0BMyBzuVUCiJRlygQSLGq2x4hVmItikBoKIIy2s8Z3S1uexr-Mg_CvUIcwLGJI7-hIG6JOYNANqYUu6JG4ljAwigkYb5FyVSxqRfSiUlThdWkwpAYTlPdyKBst_0LlOubDK4e0zEP8zmOzQY1bHcWM0Zs1Po6xA1FUES-iRymD5BtNvcKLKK9dllK17jpKZc1mhwNcUVtTunWt_XM8WfWSi6QTn-TEV0ebNbSHI8t9m6O7ipub3W_n-Cu7vzrUTft8WIO9QLBHRGYQzSSQAzcqM1FwJu2Mqa5PLZ_YpFKNsCKZ2o7bzPbHS1HURBBWnZRzEWLi0Mu-ioKuq4c7g_kk8wovSUzzg2isSUpUtKJEGk2mdR8QYYUNBIhq1G0uXXJYEpCogqpbUFIK8alZw4kCg6Y5BHOaTWIRdsPc983bQperYox6SVQIQd6YTl0F-4gnE5dCN974MsD058W6alQ5ZRy_OoD0AsXAtDjcCUvdOYMPWL6kGOEK7kg5FWMUmGUQgMPnCfcyDK3bIiNtKxLIOcdYd7T9ieN1IxhXI0pfLWMS0HXHd1yBOsV6ZiAA5paTgNFivO5PEZN-lYOvG4DF0jWD1S90AMA7D_Mdhq1MZ1Ua4N-1jWSMbgaM_LbaGOe4l_WMtrgTH3fcv4Tsjn_v33uwvSeGskX559wxgvywCeH-H6dhGNGPuOwlcBggWa9HiEcB0N312qa2CDGlUPhm3naYvgNA90M1QaJq21OpyZdmGs2pOYRqptZDrt2L-ZJNnAGrjmcEG9ljY3wChSwwB-Uwq7tD3IUl1v5F_EHh7brjji2btxAphS832DmpwRwXWlmyP1viXLFwPbCtQPicIMJse1GomQIEXy1MEtB1xVnjmADN_qvF7quOn2M3wBOm0dcWfCacbIEct2uzdKr71ncoRqYs4Z9mkA36slC6A0HxoRmpReIfsYrWmxNie7twVZF6zv4O1neKV_HCn3Cvt1hE-AUg41plBNSYes90YJP38Q48CPXb_c7O3SzJDcYklngkZ0rfwgVgb5xHpOywcScEY9DMjtHnjkOyOgjh5x3eh4ZW28fuV8ervR_5PcNXngvnIW_clixr9wvY6my_p4uObLXMYJWAG-I6nu8utkejcio7SP6zQPxpJ1BOF6gbsjv5y6A0vVX9sVcO_3OI8XAD2HzD9GS20dO5HfY97f-R-5wD_7t0DW_Pnn-yKnyDu7ts4YWvhV2fgXmo_-RxO2_H9FWtaL_JeWtYRStvqdzgLgz0nbN0c6vGW3zuyH_jiMC81I00YiWR3Z--bSi74KRhWAKzMVtg0ETezIhh9vhoS2_Y9YSCzBebzF9rvMWeGYxFyXLhQqSY5JMaMu5ilQt53BM2alBXOCQCf3E0d76vMvvK_E2tMhkSiHEWgipFkKuhVBqIdR4jRoNJG9wRoG9sU0SHNsSv3Pk2i7OHXHXuFMpLmUwHzlJFI3o4RDEGn1bYtkE9azSFAWm8skIV7JbnOlHRBeMYhCEyTcL6jZo6vcbURH4ZXs2ZPkdrJ5uPjPtEnR5EU94jxbm0yRcKjN2PTX2_h78yxq7XmTsHmFzuy0bfP97UlPl_cN_CfyeyP8NN_1NGX8Ox4fEaj7IPI8vWScnxYIiZq0pfhtZ4wfp9yxBarDppsGUiJalgV3Lmc6Iozv3ubiXE6IAbCZSXfIOiWD_H1itVmC1l-SVDYBdE2ICECfY49BySJDYqiHopaYabT9iQNHDigYN45hqLJgOYwdmG5FUl5EUQ3xP4FHz9AQmN9wlCDovvcdLh_EnFDRE8OWCoVXUUurxoAOigkG-fhw93aP_Msal50ZSfueDIGZ3zcbV4VjIEg1RH2RJpBa0MObp2rIFUf2PhIXUpSW7_Otod5FmqlWaeeQ6zyHu6z-H0BliOC9RTcHQ5HrdpFDrKqemCjXKqRUopy7klVMQ6rTTEEq0swsxiXxfgKFJq4wWtepaq7JGvcoaeq1qqvqSav7fc9BFKqxUqfDtHIYkx4dmEdxF7wQ2iD5RY0XU6rVY5aVyJR4QEzfpQ6CLW_oYz46Ja6UQEN-6nj3yG6U5iqyu7opVSctru1aUCUVmhHWPSDF_BqQRR1zFJoo8NgwimS23SgE5xSjz6Wu5cXHnF6HiZtmHQCfyONeJk4GuFQAEdsI7vy_-Hi-oxHpNP-MleL5SFDjFMVCTsSEBltXCMSKJwiQZX0cCX3yrqzXmmpARJHU50ovrIBo0aqPSz4Zr_1oBVQWEVguhl_sNuanfOHTdjM8QdaneZyDQugOfrr_HnyZ-IxBZQ-2UAochCGW2v-pAt4pR__ODL4HXljS-VNMlPmtIsdg4-l3PX3zY0osy-WkI49POlTN_46LfNTn5SqmzVoGfGxoawLPIfyklbts2eGHPeggD4hv3hQBp__nqMkBG7dTaNNmMeS2lyIJKU2QTNCut0M4HSSkolQrc8ULhgiMHVTaWtVTQf4-pF317R9n_22OXGYRY5Y_bUxKAhgdcH8VflzroRl5RC2InXdIzyp85U0LgC4BlscRS1ILZJFFd0PICB4vT2jVRE6QZRVGTnLpfPmMfilZkH0Nk0fKSqiyYibYnSn8r1sgPkqQVBTgfBFkpiGw-yGLWHphA48nHD2qBSxfkWmPh_20sZcYiVRnLIJg_WqbDfbN8Ur--opdN5xSrYuVAU5CAGIr8fkjsICFwYpv-E9umLharfTqhqpVYTvL1WhGAor8vfBinZW0miVja2eFFzZtPF7IDgYu2YXIMBZRckTJTqx_05ZQaQKjSLs6gxuVY86LypMLZl1RSPmfO8LvBEYLN3ZB9_p1fGqHC_LddpB-gFdvFReiNiOeGPteZE-4LeSV2XXxFNYBC0mVB7GO5BAp6Kz37iLAld4opFYVBiHFM3iBJhYqeOQGEwNYjrsFSFKEEI_bGzNooqFIaJPGZ1JYuCST8aK6ZZZpZCIhWD8ryWpkvXXlIGk4gMaCvOFzl9elC8l83GsdvF8vXu_OfNdpufPYAA-REbvBqzhYcBScCGlDuPdz0z3EnDT7gen6yap8hRLPLRQLKCgQqayKtUhPw0pu0hLqr7VVdXZ2QUEhI2VAGQgm-UIDPsrYSBL0AoUvsaSmCVoqwSRtPbciT_RIEpUxFS-DlAniM0UulJpYhiCsgHLqjeTxv1rC3KvVvE6spr4q4jgZvorzlVZG2ZZVbqo9cS4bCnY3gfUSNjnacqAr4Db7jjghVDvaYpVVLQMOTNlMC9LGIQL2eiNtyUeoWNEXYAg1xC8azSluKnZmwMQVxYwrSygPfKrU-xahzvR77p8Qb6nasevOul1cex7ZiBkVClbflMuVt1UjaWDhrDmwlWGpjvpt36zphZQmK0dQqNvdDW4th19HqsrBVqGO-Ai8aua2aZJSAS6WOUtyWKW5jjJS2QEPe1GFvY6DehjDUlYdJcWNXoG4qvNXH9k3TaGUL3SWvXOvNve421GztCYENZb6xjckbVmBLQdWm0xc1ustmw9hXI3j6mTkiA3o-2S3BOWmfHRRLvyGhJ8Hid2Js7ixzEif9CuaenbG2dHxd_thWyx_e4-miF_TYh_iM087JSefo-uxbJ0IZELqqwA1d2zZnfuabSpyPiz50selJN3744DPoz7t4cBt9eUwC07L9RtS66RlzWVqUTvquCSV63KuFcytZQp034uEkavK2CSm8bWu5OqwuuM0ajwxuJit2xmmWFNsndWT6QeYmg2oq-CF0ngiWNGvK2XRm2gvCjcoadzYeYIffKvkFQgnwcLsZGVpja8hgGvZ6fERnTjb5y1qqadArzvL4rKgJMrt0LI8dlTWSanQKU06qrKyRfpGhOc9js6ImyMlNGHkCSbFLv-JuQqljk7Zl4-rvQs9eug5VdtyoGAM0IXgB_oWthy0QvMJDYOM3TSilG0SWrCcubyQrvNAnL6b0ip-attDDp7KomdtqauSavZIl742WL2updWoLJDI3m1SjxieMZpFZWcMuiLLPnPizF2DUCCE-ozXX_txNIDVGQt1t-8W1RsueYvHlxgTpZzRbqBdecbE5mcUrLxpRZCvWeUJRWSk6--K0DPsmoEcmbEYELW4zCmh4m1G4tpxhEHqkEYH-UjTSr4xBUszkHPTcWJ27omB1_OSU9bUpsPsV1kanp6439v_HZEy_Zi4YAJJXm9E6cSGig3DDDJpaRjkt_Iwu-US_gYBqWtjAITWnxUbelYTGnAq7JK_AX2Zvz9uEEMQF3aYBaCml5C6YLjFtvAbWtTcjWHxLYGUXlNLC7ynDmemMYmpXq4T95dKDTBeIpjeC-RvVMrohI6Hz6SDOEOlJ2vGx0vTchei2EHzghnaIRwp2TX9ygqdcpxdFi2xxzv-8q6iSYrREiRe1liwbothSZUXXWqqoGy3D0ISWrIuq1hJUXeBbgsDrOkDIotqSZAHfyoIhtERel8SWJmkyFCsG3xIVQGgpsoQ_Fb4lSaKODEQDSnnBAIKSoMrwWwaWwALeKoomSy1B5hWthfcASS1FhQJR0nXgoIoaDwQkGeqmCVBNSRMBQhIEvWXIPBIReAO5SQqQVQBa1HRehdqKUHNFh9a1VF7UsRYArqtCC6oAz4ZqKAArqGoL76QFLiIPlAwZmieJogzksMKaqCtAQNbEFtRNQn6G0QI0eNYkEAjIA5qoCZpC0QwkD5LDi4MBzzDElqBJKE8AaQGy3gICAlTKQPnKBsgK3mFNQAASSECE1hg69o6m8tAjID1oO0hNBIHJUE0VZAzssOskFQAlHcEVxTBAbIYAjRehptilooiMDSBgKILQEkDuIBkohQ7jJWizBJ0KLZCAgyKIIA9dFoASqgVAIYAgYI9gFyk6lECXqtABIFUAFHTQAABE6Um6IsFvEITaEnhkrIiiyLcMSccCXUH2qoRdqgABAORBDxRdkZE1ksFvGvEtttTgoZ8EEByPaqeiShmge6ohY1_rQAaKeSxXoXHQcuxgUBiopQidRNeusZLYEQoID_RG1EWUHao9Lky3gKCm72bvgmcz5dGuKtObt_OvorN90LbmUbbzefcX0zwJ6iu-t34xq1FFQYUHZjygNTx7hQogqyBVeGJCkxWePqDUVQBQ4IE1TBMkDR6YDEGvFHzFdMTQ6APTLVUyDBmeqNoqKigyssIOlXRZwTfM-kR4J7xH19uzLTZ4sw3JXCIvRicgfLrpn7PDXSZBMPM_Hhy8vr7uz8xg4o7Jm2WT_aE7PZjhyWkvZI_OT-0hqYM2_Hf42DmejF6d2zH41Je389Mvnamuzc-_mq530wufJ99D3xFOHrsXarc7_fL15PrHF8M963pfvc7J9aX_1jN1x5jeX4b2_Ln_4_z7jT11nnnt9OdPGXR978v5s6bdXt2__Zj5zos3UE4633_-MX9ug7L8PPo-Nieq8eOPr3dfeoZh9PuX3e53_6otXb50hg97s-5V5-TE2Pse_nkyvw-_th-OX574x8MnqXf651C9eew65uS2PTu9Pfl-efyn1J_5P3rW1Ov0pefn6Y_r0bMyfPhiGT1v9DLv2F_-9E711zvRa8t65-hl7-6rfye8XN7OutO3k-n9T9O9_O7JQvfsZPzVdmePP4_Gwfz-9enZmv3sfTWcqeGG93b_mzAdd4Y_bgJ-8hQK3fnXb7fXzp7y8O2OuD9envmb4e3djaeO78a94Xz2fOne3Xl77Tb_Y3A-P7fI3eHztN_3vs4k-_TqXpq0n-7vHVV7OuLvzpXLL5Pg-eTuhwj1M8xX_65z1__Od6V7qMeDPA5v2Uk3cY9HWzv86GyfaJoz3ZW1sDnkoAEc7gFJDtTJUP-EY65nwWgUEYmfuRGO0KFDHukClTvmIF6K7mlKCVNrggF0yBLX4EA8xr901uoMCv1YQf2DdgA6jyOmf4Bk6boXxDgIJaj7M-cxvqGBGfUZDsdZmjdntMg_OHNOzSk5-IaH7jwSSuwoItZjzA5PKT3Wot8gusidqDLHKeir8ZjDq4vZvVJ-_mIphtf0dikKfG5N8RYo3DoqcCViYwI-iCUc9UauA6BzIHagUQaKCn_Qu8o4eB9EJ22CUPB8r8HEfY3urLqGsC69LcOczcBf5m43u3QDRh8JRw-fDnrgS67GNE4C2f19538AznUmEA==

Before screenshot:

pre-fix1reschange1

After screenshot:

imagereschange1

@cupkax

Copy link
Copy Markdown
ContributorAuthor

This works but setting to zero doesn't show up in calc tab as enemy modifier (I am guessing just because of the way the tab is setup).

It'd be great if someone experienced could take a look at that, ta.

@LocalIdentityLocalIdentity changed the title Fixed zero values treated as nilFix being unable to set Enemy Resistance to 0 in config tabAug 3, 2026
@LocalIdentityLocalIdentity added the bug: behaviour Behavioral differences label Aug 3, 2026
@LocalIdentity
LocalIdentity merged commit 86d51bf into PathOfBuildingCommunity:devAug 3, 2026
3 checks passed
@cupkax
cupkax deleted the fix-zero-treated-as-nil branch August 12, 2026 03:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviourBehavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manual enemy fire resistance input of specific value zero is treated as the default value of 50% during damage calculation

2 participants

@cupkax@LocalIdentity