Uh oh!
There was an error while loading. Please reload this page.
Fix Shield block chance calcs - #10098
Merged
LocalIdentity merged 1 commit intoAug 3, 2026
Merged
Conversation
LocalIdentity
approved these changes
Aug 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#10097 partially
Description of the problem being solved:
Block chance on shields were scaling by increased on the item first, followed by base block chance. Instead it should add the base block chance to the shields armour block chance, and then scale by increased local mods.
Aegis Aurora should be
26 base +6 local base mod = 32
32 x 1.2 = 38.4
26 x 1.2 = 31.2
31.2 + 6 = 37.1
After screenshot: