Skip to content

Fix crash caused by offhand granted skills - #10128

Closed
cupkax wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
cupkax:fix-granted-attacks-force-offhand
Closed

Fix crash caused by offhand granted skills#10128
cupkax wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
cupkax:fix-granted-attacks-force-offhand

Conversation

@cupkax

@cupkaxcupkax commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fixes#10127 .

Description of the problem being solved:

Fixes a regression caused by #10114 which caused item-granted attack to use the weapon in said slot. However, it caused skills granted by offhand (quiver, shield) to break.

Steps taken to verify a working solution:

  • Tested with voidfletcher

Link to a build that showcases this PR:

eNrtXFlz4zYSfh79CpSqspXUjm2ROnysvVuyfNbaM4rlmWyeUjAJScxAhEKClpXU_PftBnhbByjqaWudh1Bg94fuBtAXmJz_623GySsLQk_4F03rsNUkzHeE6_mTi-aX55uDk-a__tk4H1I5_Ty-jDyOb_7Z-HCunomkwYTJrwl_-zfgf6G-68mL5ifhsyaZU19OmfAfPV8Et8JNxp0pDagjWfDAXhnvR1I8CpddNGUQwVuOgyBPk8yo54-E843J20BEczVGQ4f57oDTMPxEZyyFzAZGDsjTJK8eW2jY-8fh56fnnDj097w4oNGH8yGnSxaMJJXklfIIuECbEH5eNPtgIjphd55sHhnSXkZBKK_oDB7X8vQOe7m_4wRhNGfMXctkHXYTwkHgyceIS2_OPRas52ilwoEGgyn1HbZdj2chKb8ajkwphYFtfvHk9JKDdka4SH0_8T3JjMmHwguFX0lqI-JBxDnsfCPaJxay4JVKz1CQgZi9eP5mm1iHp53jjEFwVyz8tdR2iv1IfToQocHSIOWQBXCy5EYGq90-bGd_JfYRcwQczaozVuR88MbMnNJEqzJDVWl20-N6ZEpXGXg3gZ7AW5lRjkTEN1Jme3AkAwOqK_a2nsqys8P1x0bKFO_eN9Diir0KPKdrKdsnh7Z9atnHreNju1twHdd3w_WOPZV3OF2GnkP5I33zZtEM_O8z_cY2THicbavJVPrgdKqz3ngBq841AK9izHWSck2pCE3ZeoVDY7DL5sw5Q9J73zEE_eIHyv9uiKBFhic4HxiyXzgziaDFOeJjZuYkntiE-fF0SzOWB8ac6S3kQE9UrhevW_CphmZF0k1mLYIamDVnpCLHViMdnuYZK5oJWczMlLlHnwWT5WjqMe5Wo07EGtC5oZnz3JvMvWa6SqbIs1Y0yS80cM3iQ1WZXmm4ycOWrKWpjQz1yCCTBAaXmaa0w0D8zhzpcSM2K_X3_WAmosBQBU1spEESHHSZ8MTcyJFGtroej1GPV3bJoTYyVT_lAjk5r8Tal5I6366EOzE2tpqkEkdRvlE0n4MHwe2wBeAgc-gY-SD_9kxSmIz2M2zlTSc6NwEGSdMJMtoKE6Rh33SWEkMVXTB0GyuTEW-bwnq3oI_gLGYQAlRlCxW5weJAwWVUPSlCwypuKBYg-RSbFuH61GYVNSQ4BqIEzP9zaYxfIDea4Np3owCPgvEcZY5smmdvBv4zDK-opMSN8-CvNPCoL229howGzvQBFvyimf91Qzl_AW-AoyVGCxkR__xINYjw6TlgjNDkXDtIoQTAH2RGQwlhRG-UEBElkOcaSjakBr5wGbzrnpyoelPVMzRY9rM20L170fQ9XmgN4VgLu0IRTnFHw-mNCGY061bZcctIE6JMH86_PD2ohw9TKefh2dHRYrE4nFM5FWP2BnHj0BGzozkwgTYH4TeP8wMU-KgPf5eTvvpTQEcJ0rnuXoVH-heencADffQqHKEVlL3QTPgwQtAQDDumEZe3bPZzRLknl0qZbPRBd8h8VCkpLsA2U7F4YBPqLIEETDamPGR6GN2pCJD1eTlHc_YfHuCNHgovl3CAku5bYfAGk4likyJZTZR0xGS2ovEA8dxkLB4kIReYZDA6Fz6BveX5sC4upPXxOY-XL4TI6WC7TrLZmQWh9EUE3ttH0g9DtLlPLsUCO5SYrLtps5C-oCl0r7CfiZb2D3NjA8qdMBXuwzmoSRwR-TIWIG48tlvJLLdcvFBuJXPlB-1EaATGTXQFe6xJ_sitl09n8abX74qSx1viSEm21lq2mbXss6_Cc8ecSWfKgo_kc-BD4kd-jkD1oILNFPJqq-GrzXazd7IbCj6aCrnOdvieaIItBowfYQ-qM6XPEj7ez3DzE_aG_xrSAOfQh0N5q4Hwx94k3tf6R35jpyOFnQ1u12FTiPEsUMJeNOdpfnkFflLlLMSPZi8suGh2Wom47_mYz2bLNI7HTeOU07Y71nreWdr_xf4nC5g7wlRtgIszYnyc4UA-a4ByB95dLECMG44LgFgQ9mcQwN3LZZ_zZQ5wi0YqZShrc3La22YI3Es5ho6p4YbMz9ja24SDkUoMmC5WYoirhpS-Z52enG7hSaqlzMYtq7Ntorh8EJw_UT9v6-MNey70Jh7_PFZJDqwyZhPGC4umqLZLU5PvwKavQ3JKbdAKc5oVh2_T1ldzFCsxU_FGjoCcSJ8RI-uBE3O-VaBPrR1n6SlPd5s3wauhsjLtlsEC7TRTXKBlTKZHtspsjvbCEBJkQPmzN4HsHL2c-bT5gsfIKplbvEb-om9csYIDyDXFDAocbww8qsIuR17pSc6w86wyuTie6jC2glsHtTT-qKimfyWp9VePLcifQiQZIWTI-Os_Kobi06-6gFDp-0gGKpfHfBDqgysP8m6oQhzMB9OIeq7iI6HzOaTSaQ4JKav0fHWrBbkjBwcNm3nRd19x5Z-F4GExomLKoKS_9-eRTJwOBuTftNnema9AOfNC57eXaDzG-1usZgJ1JX19c3M9eL7_eh2zjJjqmKi4HId-DkPAEL2E-h3kD2Ai9fKKSepxOHoO-Eo6D5mbl7mIdpednzyWwsm9M0D6BSwfeOhf80DXbywAg06ytwZQQ8hQyjiQ2SxU2MemiRkM3tW-10qrhG09rA2NgGLXnIfSnaIB1HWq8WiCgh6kCIIjZqpAYkd5aY2SMRMFUHEsiPA4hCuMIrFYApcDR9KJacw2T-ISC7ZxHKjGnaURhronL_LHQyYbRd2DF7mTMROrqlv3klXjMZP9xRy6LHLHQwbMaeO6CJAOCx8_wzBBuuas73HsO5VW9pPw1WaH45cRGAA-glOKWxVFwM-YeadvDJDglATeSyTLXiE_bmIrvEUrmkmNmOiCN0UFVj1iYtf89UnRGRXemPnGEoQeMWBN4nieWY8ZLkGcnhfMH4-ZGCHJ1Av6J4Mmh0S52_4rFLfvPcW7l3UBVTaxB7mwn18fptzgN0KEpCv8VjovydiO7F-gVvfkcgVK1l_YCoJHrh4Cnrx6CM-e78goYEYAT--ymqdyLrOGM-k7F4N1Mrgjf9qj3hlBd9J3Zlc1sAk3-n9I3FXCvCIAZK8MY8lqrBsBiSGkGyrXrok1kpF_BdbdA5RScbVH2s1ccehdabU1iNqp6G9MVvjL-IWxd1oHBHnBnWkCuhYpvfy6Y5Tjl4mC1wMsf2RTCwwv8KM59d0E7vOqvL_yMggZAqa6-7nC7wTq2lC1t94DZbXqUVJonmMXPCRRyPQHb7p7rrq4utu8tuaN277In2_64u-430te9fUWdhhUwf4Ev-XyjHz5dP_zl-tGfE_RyF9TNOIrsTMyDBhpH3YPW-Wh0_dDlrVi7Dg_NogCkF42dKHLXJK-6Tbiq6IzYrca8bXTGbk9SP9pqB7BE_vjjPTsBpRJ3HM8pLEaf8UqnrW__xVgF_Gsddj9_vcfre6B3f3pByIF0d17grUZtsrICFLVb4xkHyBnIJ2P3e-3ACNDoqYk7RbBGxCiaqqMzspP1nfdkPzYax0ct37C-X60TloHtgU_ku4c0Rsl47c_tj923mOcdg8sq6tB7A6A9LobQLrvAWBiqxVLYbcAwN4EYH0EOfIgCf8PeHMTMAp7lsSpIYGqGNxLmRk2DNGVc0jGHiy7TajrengKYMJ-EIhFWDSvCQfxxmQpIjKlr8z_G5yH8B-SYGmuFyNg-FkWXxaB83rYrYN2UQ09JVGFf214sNGB1dtkp3gKDf7KagqffIZQEN8Y-zmguJXjC1qBIYxIqPI1D4UluPJC1esr8t0HqA4bc_bGwvLCX-NXVMTqxdfaoTLoBMpcUmAjYxGQk4SoDNJu_UBmAgVQO5MsPDnVW4BgHCMUloWLkBF1P0AWU4-zdOXIRvkQurz6H7WpwNGXLZohu4L4QhpM8Gsixg0N1CWfEQj2Sx-Fq_WJnbRaevyaMG0DFyjsrRTtrRSdrRTdrRS9rRTHWylOtlKcbqWwWttJtlvV2m5Wa7tdre2GtbZb1tpuWmuFbc-PMNQXY76di_mdlTE_f9veKFy2N0ZTOgffgGCNa3WboB63JwTFSK_H7FOz6N8pHKzvQ-YzGWgfqj1BLFzmmr4Xpc5lAMPAmyVBJFWqkE_kMolON59J2EUx4jg09PATYPAY-Rj1rP7jsTWZxwrvfc2Vq0kDcOzm4oCkvHJeuzsaEotoscvjdjweNgbCD6MZOFhK1GcGukDEwP8ceJMJrJ1OYOwWST9DAA_FfOWgVOCNdVTSUPJJ-AcxK8gc5zvl_KLdOujE6UWSauDdW6IYjMehvVFIxpDW1nwzXQwQ3XEjuuVWpE4sCNQKXDfHsHjbkLpghxVzHiUf9iUIbmWVh5N_gy754LYqQmSf2OqQkKfufO-SuIjJGzss5HNbaRBHSVlcMaYCqQ6QRcC1xKBvGlH_H1D-5wNKyc9nn_OsLRrjb7K4SG4lVeuNwJJ4ABB_YIiPw5cvTw8XzUSUHEfyyRsZLeic9F-WUCLy2PuQ9r6AOvsC2ptqvV2AShjWHjDsChh6da3KHNXnaFfm2GGF7ZULY-0LqIrWd4zPmNzXzHuzRXdfQL1dgGoszBOmddYeJm3vAaOzB4zuHjB6lTdknSVYjWDXRmjXRujURujWRqiyFpfCXRJ981pnQTbA2PuBae8HprMfmO5-YKqs1C0Xr1Aq1Vik1Qh2bYR2bYRObYRubYRqp0bIsN55WQFg1wVo1wXo1AXo1gWotAqM14oiq_jtmvztmvydmvzdmvy9fdUg1r6A7F2Bds0vq3iSgI53SB7blaewq05RdR9XPbeV3e1uAXOHNcxY7FplRZVF6s8ivkuJlds51q5F9j6K_e4eMDp7wNhHRbRl5-tGVPI5v_puAZ8-CcnUJ_M4Gv84Pyr_r9f-CzWzuIU=

Before screenshot:

After screenshot:

@cupkaxcupkax changed the title Fix offhands granted attacksFix crash caused by offhand granted skillsAug 5, 2026
@LocalIdentity

Copy link
Copy Markdown
Contributor

Superceded by #10144 as this PRs logic causes regressions wiht the trigger handling logic

@cupkax
cupkax deleted the fix-granted-attacks-force-offhand branch August 12, 2026 03:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Equiping Voidfletcher quiver errors out

2 participants

@cupkax@LocalIdentity