Skip to content

Fix crash when double clicking and dragging an item on small window sizes - #10134

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
vaisest:weird-drag
Aug 6, 2026
Merged

Fix crash when double clicking and dragging an item on small window sizes#10134
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
vaisest:weird-drag

Conversation

@vaisest

Copy link
Copy Markdown
Contributor

Fixes#10129

Description of the problem being solved:

This fixes the possibility of a crash with a nil check on the method that is used for (I think) getting the drag text. But this also fixes the stuck drag issue by disallowing it on double click. With double clicks it was possible to start an invalid drag if the second click was outside the item. This happened when the window scrolls a lot to the right, or just naturally if you have low fps (debugger)

Steps taken to verify a working solution:

  • Issue seems to be fixed
  • Drag still works (it doesn't even do anything in the item DB)

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

@LocalIdentityLocalIdentity added the crash Causes PoB to crash and is High Priority label Aug 6, 2026
@LocalIdentityLocalIdentity changed the title Fix crash and weird drag behaviour in item DBFix crash when double clicking and dragging an item on small window sizesAug 6, 2026
@LocalIdentity
LocalIdentity merged commit ffbb8b1 into PathOfBuildingCommunity:devAug 6, 2026
2 of 3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crashCauses PoB to crash and is High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search window error

2 participants

@vaisest@LocalIdentity