Uh oh!
There was an error while loading. Please reload this page.
Fix Scornful Herald not counting buffs as affecting you - #10158
Merged
Conversation
LocalIdentity
approved these changes
Aug 7, 2026
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I changed it to be a less buff effect mod instead of using the flag so it's more generic
… buffs as affecting you
Made it use less buff effect instead so it would show up in a breakdown if we made one in the future
Uh oh!
There was an error while loading. Please reload this page.
vaisest pushed a commit
to vaisest/PathOfBuilding
that referenced
this pull request
Aug 11, 2026
…ngCommunity#10158) * FixesPathOfBuildingCommunity#10157: Fix Scornful Herald not counting buffs as affecting you * Simpler fix of making it have 100% less buff effect Made it use less buff effect instead so it would show up in a breakdown if we made one in the future --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#10157
I wasn't able to test this in PoB itself on my Mac, but this test passes. I can test again later if needed.