Uh oh!
There was an error while loading. Please reload this page.
Add breakdowns to the build side bar on mouseover - #10196
Open
vaisest wants to merge 2 commits into
Open
Conversation
cupkax
commented
Aug 10, 2026
Contributor
The underlines do make it look a tad busy. Would making the calc specific numbers/terms bolder work here? Other option could be to keep the underline just for the keywords? |
Blitz54
commented
Aug 10, 2026
Contributor
vaisest
commented
Aug 11, 2026
ContributorAuthor
cupkax
commented
Aug 11, 2026
Contributor
vaisest
commented
Aug 11, 2026
ContributorAuthor
We came to sort of a conclusion on Discord (if you're not there as a contributor, ask local) that it's probably best to keep the underlining for a short period and then we can remove it completely once users are more familiar with it |
cupkax
commented
Aug 11, 2026
Contributor
Ah, gotcha. No worries. @LocalIdentity can I get an invite to the discord if possible? |
LocalIdentity
commented
Aug 11, 2026
Contributor
@cupkax send me a friend req or message on discord (Localidentity) and I’ll inv you |
vaisest
marked this pull request as ready for review
August 13, 2026 08:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of the problem being solved:
This adds the calc tab breakdowns to the build side bar. This is sort of inspired by poe.ninja.
The breakdowns seem to work quite well, but I think this looks quite busy, and I'll welcome opinions on whether or not this needs visual changes or not.Feedback received. I toned down the underlining a bit. Optimally I think we should remove this later, but it's good to have now to teach users that this actually exists. TPlant also mentioned a small diamond icon. It doesn't seem like something PoB or PoE has used before, but that could work too.I also don't have perfect knowledge on what all the calcs stuff means. For example I have no clue what omniscience is, or why the off-hand breakdowns would be relevant.
The breakdowns are indexed based on their names from
CalcSections, and in most cases theBuildDisplayStatsstat names are used to look up the breakdown. This is not always possible and thus I added abreakdown string?field to the display stats to force a breakdown if e.g. the name is different. There's also amodNames string[]?field for defining mod lists if, for example, the breakdown doesn't have any mod lists in the cell (e.g. Life). These exceptions have to be manually fixed.One problem with this approach is that if multiple cells have the same breakdown, we might get a bad match, like what happens with armour/ev/es. For these it's better to just ignore the breakdown and to add modnames manually.
I have fixed most stat displays, and made sure that minions work. One issue was that the main env doesn't contain breakdowns. This was fixed by generating them for the main env, and I'm not sure how bad that is. I'd assume the breakdowns were restricted to "CALCS" for a reason.
Pinning is supported (not the popup but like left clicking a cell).
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Minions: https://poe.ninja/poe1/pob/96cb6
Totems: https://poe.ninja/poe1/pob/96cb7
Mamba: https://poe.ninja/poe1/pob/96cb9
Worb: https://poe.ninja/poe1/pob/96cba
Before screenshot:
After screenshot:
Path.space.of.space.Building_2026-08-11_19-12-42.mp4