Skip to content

PR: Triggers & FullDPS - #2294

Merged
Wires77 merged 178 commits into
PathOfBuildingCommunity:devfrom
Nostrademous:Generals
Apr 1, 2021
Merged

PR: Triggers & FullDPS#2294
Wires77 merged 178 commits into
PathOfBuildingCommunity:devfrom
Nostrademous:Generals

Conversation

@Nostrademous

@NostrademousNostrademous commented Mar 2, 2021

Copy link
Copy Markdown
Contributor
  • Cospri's Malice
  • Mjolner
  • Cast on Critical Strike
  • Cast while Channelling (update to new form)
  • Cast on Melee Kill
  • General's Cry
  • The Saviour
  • Poet's Pen
  • Fix Vaal Skill Full DPS roll-up checkboxes
  • Add support for Crafted Mod "Trigger Spell On Skill Use" trigger
  • Add support for Crafted Helmet Mod "Trigger Spell When You Focus" trigger
  • Maloney's Mechanism
  • Kitava's Thirst
  • Asenath's Chant
  • Mirage Archer
  • Fixed Trigger Level X ... Mark when you Hit a Rare or Unique Enemy having a Mana Cost
  • Fixed Trigger Level X ... Mark when you Hit a Rare or Unique Enemy gaining +1 levels from other Items that grant +levels to specific gems globally
  • Support for various Raise Spectre combinations (future work)

Nostrademousand others added 30 commits February 13, 2021 21:37
Co-authored-by: Trevor Lund <Wires77@users.noreply.github.com>
Nostrademousand others added 11 commits March 27, 2021 09:10
Co-authored-by: Trevor Lund <Wires77@users.noreply.github.com>
Co-authored-by: Trevor Lund <Wires77@users.noreply.github.com>
Co-authored-by: Trevor Lund <Wires77@users.noreply.github.com>
Co-authored-by: Trevor Lund <Wires77@users.noreply.github.com>
Co-authored-by: Trevor Lund <Wires77@users.noreply.github.com>
Co-authored-by: Trevor Lund <Wires77@users.noreply.github.com>
@Wires77

Copy link
Copy Markdown
Member

Thanks for making all those changes. The only other thing is the count box gets cut off at lower resolutions. If we can add a horizontal scrollbar to the Skills tab that would be good enough, though.

@Nostrademous

Copy link
Copy Markdown
ContributorAuthor

Thanks for making all those changes. The only other thing is the count box gets cut off at lower resolutions. If we can add a horizontal scrollbar to the Skills tab that would be good enough, though.

I'm not sure how to do that honestly. I could add something like:

	if self.contentWidth > viewPort.width then
-- Content won't fit the screen height, so set the scrollbar
width = viewPort.width
height = self.contentHeight + horizonalScrollBar.height
horizonalScrollBar.width = width - 4
horizonalScrollBar:SetContentDimension(self.contentWidth - 4, viewPort.width - 4)
else
horizonalScrollBar:SetContentDimension(0, 0)
end```
But not sure if that would work.

@Wires77Wires77 added the enhancement New feature, calculation, or mod label Apr 1, 2021
@Wires77
Wires77 merged commit d7fadfd into PathOfBuildingCommunity:devApr 1, 2021
@Nostrademous
Nostrademous deleted the Generals branch January 21, 2022 13:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Nostrademous@yuzi-co@onefuncman@Wires77