Uh oh!
There was an error while loading. Please reload this page.
Add search field below principal buttons - #2546
Conversation
Wires77
left a comment
There was a problem hiding this comment.
Thank you for opening this PR, it seems like a nice addition to PoB.
I left some in-line comments for general improvements, but overall I think this should be done in a different way. Most other search boxes in PoB do not need a button to search, they're simply a filter that automatically filters the list as you type. It looks like doing the same here would require some modifications to the BuildListControl, as the naive solution would be to run NewFileSearch each time the search parameters changed, which would get pretty expensive. I'd take a look at ItemDBControl for an example of loading the entire list and filtering those contents instead.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Accepted suggestion Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
jabaruben
commented
Apr 16, 2021
Now i'm checking EditControl.lua in order to learn how to do this. You have an 'enterFunc' that will be triggered when you push enter button and no lineHeight is assigned (editControls with only one row). I implemented it.... could you check it? I don't know very well how to proceed in order to update this PR with new changes... i'm a little newby with GitHub :( |
Uh oh!
There was an error while loading. Please reload this page.
Added a Search Field just down principal buttons and a "Search" button and a "Clear" button.