Uh oh!
There was an error while loading. Please reload this page.
Add scripts to automatically sync unique mods with their text - #2662
Add scripts to automatically sync unique mods with their text#2662Wires77 wants to merge 19 commits into
Conversation
- Running uniqueMods.lua translates unique text into an actual mod (Run when adding new uniques) - Running uniqueText.lua translates those mods back into text (Run when the GGPK is updated, updating mod text on uniques) - This updates a lot of small text changes, and updates all catalyst tags where a matching mod was found
PJacek
left a comment
There was a problem hiding this comment.
I glanced over the changes and there seem to be a few typos in the original data. Some of them get fixed by the export but some seem to cause issues.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| local out = io.open("../Data/Uniques/"..name..".lua", "w") | ||
| for line in io.lines("../Data/Uniques/Special/"..name..".lua") do | ||
| local specName, specVal = line:match("^([%a ]+): (.+)$") | ||
| if not specName and line ~= "]],[[" then |
There was a problem hiding this comment.
It would be cleaner to read in the whole file as a Lua table, so you don't have to split by text anymore. This would also allow for simpler surrounding code.
There was a problem hiding this comment.
I actually don't know if this saves anything, after looking at it. I have to parse each line of each item anyway, and the items would be all out of order if I parsed it as a table, meaning the diffs would be impossible to double-check for errors.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Created another branch for this next change: Wires77/PathOfBuilding@unique_autoupdater...Wires77:unique_autoupdater_improvements
|
Increase accuracy of unique mods
…fBuilding into unique_autoupdater
QuickStick123
commented
Jul 4, 2022
The tags it generates seem to be inaccurate in several instances like it doesn't correctly fix x mod on low life applying from fertile catalyst and physical and chaos damage tags will need to be added to properly handle noxious catalyst. |
Wires77
commented
Jul 10, 2022
Can you point out some that you noticed so I can investigate them further? The new tags should be fixed by running the scripts again. I'll try to do that again soon since so much has changed since I last updated this PR |
physical -> physical damage remove tag: https://www.pathofexile.com/trade/search/Standard/a2GOkw7ue add physical damage chaos -> chaos damage Socketed Golem Skills is unscalable so remove all |
Wires77
commented
Jul 10, 2022
These differences fall into several categories:
|
QuickStick123
commented
Jul 10, 2022
You are correct I incorrectly assumed since attack life work physical damage scaling would also work on the leech mod but It doesn't work from my testing. |
Superceded by #9480 |
Future plans are to fix typos we have currently that are out-of-sync with the GGPK, add entries to
ModParser.luato support those differences where necessary, and improve performance.