Skip to content

Update uniques for 3.19.0 Kalandra - #4745

Merged
Wires77 merged 11 commits into
PathOfBuildingCommunity:devfrom
Paliak:uniquesupdate
Aug 14, 2022
Merged

Update uniques for 3.19.0 Kalandra#4745
Wires77 merged 11 commits into
PathOfBuildingCommunity:devfrom
Paliak:uniquesupdate

Conversation

@Paliak

@PaliakPaliak commented Aug 12, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Current changes only include 3.19 variants for unique helmets and belts. Will try adding more.

Overrides Wurm's molt level requirement to the level requirement as of 3.19.0 due to lack of support for variant level requirements

Unsure about the ordering on some mods.

@QuickStick123QuickStick123 added the bug: accuracy Wording differences label Aug 12, 2022
@Paliak
Paliak marked this pull request as ready for review August 12, 2022 21:12
@Wires77Wires77 self-assigned this Aug 14, 2022
@Wires77
Wires77 self-requested a review August 14, 2022 03:33
Wires77
Wires77 requested changes Aug 14, 2022
View reviewed changes

@Wires77Wires77 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things need to be fixed on these uniques still. Also LevelReq: should be used and should work if it's above the implicit section

Comment threadsrc/Data/Uniques/belt.lua Outdated
Comment threadsrc/Data/Uniques/belt.lua Outdated
Comment threadsrc/Data/Uniques/belt.lua Outdated
Comment threadsrc/Data/Uniques/belt.lua
Comment threadsrc/Data/Uniques/helmet.lua Outdated
Comment threadsrc/Data/Uniques/helmet.lua Outdated
Comment threadsrc/Data/Uniques/helmet.lua Outdated
@Paliak

Paliak commented Aug 14, 2022

Copy link
Copy Markdown
ContributorAuthor

I'm not 100% on the usage of LevelReq but i've made the requested changes.

@Paliak
Paliak requested a review from Wires77August 14, 2022 05:22
@Wires77
Wires77 merged commit b6ca150 into PathOfBuildingCommunity:devAug 14, 2022
@Paliak
Paliak deleted the uniquesupdate branch August 14, 2022 06:24
@Wires77Wires77 mentioned this pull request Dec 7, 2022
Merged
@Wires77Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wires77Wires77Wires77 approved these changes

Assignees

@Wires77Wires77

Labels

bug: accuracyWording differences

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Paliak@Wires77@QuickStick123