Skip to content

PoB Trader: Fix issues caused by sorting mode change - #5552

Merged
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
Dullson:pobtrader_fix_jewel_sort
Feb 18, 2023
Merged

PoB Trader: Fix issues caused by sorting mode change#5552
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
Dullson:pobtrader_fix_jewel_sort

Conversation

@Dullson

@DullsonDullson commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

Fixes#5542, #5544

Description of the problems being solved:

  • Fixed a crash caused by sort mode change when jewels are present
  • Fixed error message not clearing after successful sort
  • Fixed Import Item button tooltip not displaying selected dropdown item after sorting

@QuickStick123

QuickStick123 commented Jan 5, 2023

Copy link
Copy Markdown
Contributor

I also included a fix fir the import button in #5375 but this seems to fix it differently.

@QuickStick123QuickStick123 added bug Something isn't working crash Causes PoB to crash and is High Priority labels Jan 5, 2023
Dullson
Dullson commented Jan 5, 2023
View reviewed changes
Comment threadsrc/Classes/TradeQuery.lua
end

self.sortedResultTbl[index] = sortedItems
self.itemIndexTbl[index] = 1

@DullsonDullsonJan 5, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also included a fix fir the import button in #5375 but this seems to fix it differently.

Didn't check that PR yet but this line was wrong and had to be fixed. Looks like the intention was to reset the item index to 1 after sorting because dropdowns reset but the sorted item indexes are a little more convoluted. This is the correct way to reference the item on the first slot of dropdown containing sorted items.

@QuickStick123

QuickStick123 commented Jan 9, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Doesn't fix #5544 afaik as it seems to be caused by using certain trade urls in the price item thing. Such as
https://www.pathofexile.com/trade/search/Sanctum/3vWZdmJh5

@Dullson

Dullson commented Jan 9, 2023

Copy link
Copy Markdown
ContributorAuthor

Now it should fix #5544

@LocalIdentity
LocalIdentity merged commit f93e99e into PathOfBuildingCommunity:devFeb 18, 2023
Dullson added a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
@Dullson
PoB Trader: Fix issues caused by sorting mode change (PathOfBuildingC…
127d953
…ommunity#5552)
* fix(pobtrader): error message not clearing after successful sorting
* fix(pobtrader): sort dropdown throwing error for jewels
* fix(pobtrader): import button item tooltip not updating on sort
* fix(pobtrader): check pseudoMods before indexing
@Wires77Wires77 mentioned this pull request Dec 11, 2023
Merged
@mcagnionmcagnion mentioned this pull request Apr 9, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LocalIdentityLocalIdentityLocalIdentity approved these changes

Assignees

No one assigned

Labels

bugSomething isn't workingcrashCauses PoB to crash and is High Priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash upon changing search method after searching for best jewel

3 participants

@Dullson@QuickStick123@LocalIdentity