Uh oh!
There was an error while loading. Please reload this page.
Fix Unicode input for PoeCharm - #6669
Merged
Merged
Conversation
Wires77
approved these changes
Sep 13, 2023
Wires77
left a comment
Member
There was a problem hiding this comment.
This is pretty hard for any of the core developers to test, but it's clean enough I'm fine putting it in for those who need it. Just need to make a note to remove it if we ever get around to supporting Unicode ourselves.
CryAngel1970
commented
Sep 13, 2023
I tested the newly added function by applying it to the source code on my computer. Korean input is working well. thank you. |
ZdDroid
commented
Sep 13, 2023
PoeCharm input text use the UTF8 codec,The ASCII encoding range is 21-122(ANSIC WIKI), anything beyond this encoding range can be regarded as UTF-8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#6634.
Description of the problem being solved:
Allow Unicode input in EditControls when running under PoeCharm. Added a DetectUnicodeSupport function that uses DrawStringWidth to detect if running under PoeCharm and if so changes the default input filter on EditControl.
I couldn't figure out how to test Unicode input in PoeCharm, even the file boxes it should already work in didn't work for me when I switched Windows languages to try it. Maybe someone that knows more about PoeCharm can test.
Steps taken to verify a working solution: