Skip to content

Fix ES from Tricksters Escape Artist when using Oath of the Maji - #7018

Merged
LocalIdentity merged 1 commit into
devfrom
fix_maji+escape-artist
Dec 12, 2023
Merged

Fix ES from Tricksters Escape Artist when using Oath of the Maji#7018
LocalIdentity merged 1 commit into
devfrom
fix_maji+escape-artist

Conversation

@LocalIdentity

Copy link
Copy Markdown
Contributor

The calculation for Escape Artist use the final doubled value after Maji has affected the armour
Fixes#7009

The calculation for Escape Artist use the final doubled value after Maji has affected the armour
@LocalIdentityLocalIdentity added the bug: calculation Numerical differences label Dec 12, 2023

@Wires77Wires77 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not even realize this section was here. Would it make sense to just combine this with some of the logic around line 544?

@LocalIdentity
LocalIdentity merged commit e75a632 into devDec 12, 2023
@LocalIdentity
LocalIdentity deleted the fix_maji+escape-artist branch December 12, 2023 20:34
deathbeam added a commit to deathbeam/PathOfBuilding-1 that referenced this pull request Dec 12, 2023
* upstream-dev: (31 commits)
Release 2.37.0 (PathOfBuildingCommunity#7019)
Add support for new Uniques + fix parsing for changed mod names (PathOfBuildingCommunity#7016)
Fix ES from Tricksters Escape Artist when using Oath of the Maji (PathOfBuildingCommunity#7018)
Fix Necromancer Offering charm not working (PathOfBuildingCommunity#7014)
Update Query mods (PathOfBuildingCommunity#7011)
Fix projectile count being 1 higher on all skills (PathOfBuildingCommunity#7006)
Fix Herald of Agony quality not working (PathOfBuildingCommunity#7017)
Fix Pyroclast Mine Aura Effect scaling Maximum Added Flat Damage (PathOfBuildingCommunity#7005)
Fix Ascendant nodes counting towards allocated passive skill total (PathOfBuildingCommunity#7002)
Change Manastorm config option to not overrun options box (PathOfBuildingCommunity#7008)
Release 2.36.1
Release 2.36.1 (PathOfBuildingCommunity#6996)
Fix pathing and mastery nodes (PathOfBuildingCommunity#6989)
Export from game files
Fix Crash when opening Timeless Jewel search (PathOfBuildingCommunity#6995)
Fix negative bypass being ignored (PathOfBuildingCommunity#6992)
Release 2.36.0
Release 2.36.0 (PathOfBuildingCommunity#6988)
Add support for Tincture Implicits
Fix ES Bypass not overriding sources of negative bypass (PathOfBuildingCommunity#6965)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculationNumerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PoB does not account for Oath of the Maji defense doubling from body armour when calculating Trickster's Escape Artist EV to ES bonus

2 participants

@LocalIdentity@Wires77