Uh oh!
There was an error while loading. Please reload this page.
Port Unique updater script from PoB2 - #8700
Closed
Wires77 wants to merge 6 commits into
Closed
Conversation
Comment on lines
449
to
456
| -- Jewel radius is variable and must be read from it's mods instead after they are parsed | ||
| deferJewelRadiusIndexAssignment = true | ||
| else | ||
| for index, data in pairs(data.jewelRadius) do | ||
| if specVal:match("^%a+") == data.label then | ||
| if specVal:match("^%[a ]+") == data.label then | ||
| self.jewelRadiusIndex = index | ||
| break | ||
| end |
Nightblade
commented
Jan 17, 2026
Contributor
I noticed these too but couldn't work out how to review-comment on unchanged lines in vscode:
 |
EtherealCarnivore added a commit
to EtherealCarnivore/PathOfBuilding
that referenced
this pull request
Feb 21, 2026
- Fix jewel radius regex: ^%[a ]+ is invalid Lua pattern syntax,
corrected to ^[%a ]+ (character class of letters and spaces).
This was breaking ALL jewel radius parsing, not just "Very Large".
Also fixed inconsistency where line 448 used a different pattern.
- Fix mod selection in uTextToMods.lua: split into two-pass approach
(type match first, unused fallback second) with break statements
to prevent non-type-matching mods from overwriting type matches.
- Fix greedy gsub {.+} to non-greedy {.-} in both export scripts
to prevent consuming too much text on lines with multiple brace
groups.
- Fix statOrder bounds in uModsToText.lua: guard against nil mod
or mismatched line counts between legacy and current descriptions.
Falls back to high order number to append at end.
- Make usedMods local and hoist ModTextMap load outside the item
type loop in uTextToMods.lua.EtherealCarnivore added a commit
to EtherealCarnivore/PathOfBuilding
that referenced
this pull request
Feb 21, 2026
- Fix two blocks (lines ~103-116, ~130-143) where variable was declared as 'local excluded' but then set/checked as 'exclude' (without 'd'). This created an accidental global that persisted across iterations. - Convert space indentation to tabs in jewel radius block (lines 449-457) to match codebase convention. Addresses review feedback from Nightblade on PR PathOfBuildingCommunity#8700.
5 tasks
Wires77
commented
Mar 2, 2026
MemberAuthor
Closing in favor of #9480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of PathOfBuildingCommunity/PathOfBuilding-PoE2#54, PathOfBuildingCommunity/PathOfBuilding-PoE2#65, and PathOfBuildingCommunity/PathOfBuilding-PoE2#175 from the PoB2 repo.