Skip to content

Fix misc calculations based on spell suppression when evasion mastery is active - #9405

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
danielztolnai:fix/spell-suppression-from-evasion-mastery-for-conditionals
Feb 12, 2026
Merged

Fix misc calculations based on spell suppression when evasion mastery is active#9405
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
danielztolnai:fix/spell-suppression-from-evasion-mastery-for-conditionals

Conversation

@danielztolnai

Copy link
Copy Markdown
Contributor

Fixes#9385 .

Description of the problem being solved:

Spell suppression is used for ailment avoidance calculation in doActorMisc() when SpellSuppressionAppliesToAilmentAvoidance. However, spell suppression from the evasion mastery +15% chance to Suppress Spell Damage if Equipped Helmet, Body Armour, Gloves, and Boots all have Evasion Rating was only calculated in a later step, at the beginning of calcs.defence(). This lead to incorrect results.

To fix in the safest way possible, I moved the execution of as minimal code as possible as little as possible. I moved code from calcs.defence() to a separate function that is called right before the doActorMisc() step.

If this is not the correct way to address this, let me know and I will change my implementation.

Steps taken to verify a working solution:

  • With the same setup as in the issue, the ailment value is now correct while it was not before.
  • Checked the values while running the code via inspection: Now the spell suppression value in the modDB is correct right before the ailment avoidance calculation step, while it wasn't before.
  • I also checked whether the modified functions are called anywhere else to see if more changes are needed.

Link to a build that showcases this PR:

https://pobb.in/mLdCGe4ojsq-

Before and after screenshots:

You can see that the ailments are wrongly applied before the change, but not applied after.

imageimage

…culations
A few conditionals in the misc calculation use these, for example the ailment
calculation via spell suppression via the evasion mastery that grants
suppression based on evasion on items.
@danielztolnai

Copy link
Copy Markdown
ContributorAuthor

I fixed the spell checker typo, please run the actions again when you have the time.

@LocalIdentityLocalIdentity added the bug: calculation Numerical differences label Feb 12, 2026

@LocalIdentityLocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't think this should cause any issues

@LocalIdentity
LocalIdentity merged commit 2416cd4 into PathOfBuildingCommunity:devFeb 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculationNumerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arkhon's tools, Ancestral Vision and added spell suppression Evasion Mastery leads to incorrect ailment status

2 participants

@danielztolnai@LocalIdentity