Uh oh!
There was an error while loading. Please reload this page.
Add support for Cryogenesis Bloodline node - #9517
Merged
LocalIdentity merged 9 commits intoMar 6, 2026
Merged
Conversation
EtherealCarnivore
marked this pull request as draft
March 2, 2026 20:37
3.28 replaces the old graft damage reduction stats with: - Int single highest attribute: all added damage treated as Lightning - Dex single highest attribute: all added damage treated as Cold Updated tree data (all 4 variants), added ModParser entries, single-highest-attribute conditions in CalcPerform, and flat added damage redirection in CalcOffence.
EtherealCarnivoreforce-pushed
the
rename-cryogenesis
branch
from
March 2, 2026 21:29
4d0be8f to
04aa69aCompareEtherealCarnivore
marked this pull request as ready for review
March 2, 2026 21:30
EtherealCarnivore
commented
Mar 2, 2026
ContributorAuthor
Draft -> Ready to review |
Like ReplaceMod but matches by oldName instead of the new mod's name, so it can change a mod's identity (e.g. FireMin -> ColdMin) rather than just updating its value. ModDB moves the mod between name buckets.
ModParser entries now match the actual 3.28 tree text instead of guessed wording. Handles the "Lighting" typo with a pattern. CalcOffence uses ConvertMod to redirect added damage mods before the damage loop so breakdowns show the source properly. Base Elemental Hit is excluded per the node text. Added ConvertMod to ModStore/ModList/ModDB - like ReplaceMod but matches by oldName so it can change a mod's identity.
The old cache had these 3.28 tree lines stored as parse failures from before the ModParser entries existed. Since the cache uses exact-case text as the key, the tree's mixed-case text always hit the stale entry and returned "unsupported" without reaching the new specialModList patterns. Replaced 3 individual entries with correct parsed results and removed 3 concatenated multi-line entries that were never going to match anyway.
Replaced ConvertMod approach with sum-and-offset: for each non-target damage type, add a negative mod to cancel the original and a positive mod on the target type. Both labeled "Cryogenesis Conversion" so the breakdown popup shows where the redirected damage comes from. Removed ConvertMod/ConvertModInternal from ModStore/ModList/ModDB since nothing uses them anymore.
This reverts commit baee98d.
Only the base damage granted via ele hit is not meant to be converted. Mods from gear are meant to work still The breakdown now shows a note on the mods that are converted that the cryogenesis node is what is changing them
LocalIdentity
merged commit Mar 6, 2026
9855e1e
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Mar 6, 2026
LocalIdentity pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
May 23, 2026
* Apply changes from PathOfBuildingCommunity/PathOfBuilding#9517 * Remove unneeded files --------- Co-authored-by: EtherealCarnivore <EtherealCarnivore@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
bct8925 pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
* Apply changes from PathOfBuildingCommunity/PathOfBuilding#9517 * Remove unneeded files --------- Co-authored-by: EtherealCarnivore <EtherealCarnivore@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.28 renamed the Breachlord Bloodline notable from Otherworldly Appendages to Cryogenesis and replaced the old graft damage reduction stats with two new ones:
Changes:
Tested by running the full test suite (195/195 pass).