Uh oh!
There was an error while loading. Please reload this page.
Fix URL spoofing issue with imported URLs - #9754
Merged
Merged
Conversation
…appears at the beginning of a URL
2 tasks
Wires77
marked this pull request as ready for review
April 14, 2026 01:43
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Apr 14, 2026
LocalIdentity pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Apr 25, 2026
* Apply changes from PathOfBuildingCommunity/PathOfBuilding#9754 * Fix conflicts --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
bct8925 pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
* Apply changes from PathOfBuildingCommunity/PathOfBuilding#9754 * Fix conflicts --------- Co-authored-by: Wires77 <Wires77@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9753
Description of the problem being solved:
An import URL could be queried by PoB if an attacker got their URL to match one of the allowed website patterns. This would give an attacker access to a user's IP address when they hit the malicious server. I could also put in the same protection for
regexURL, but every instance where we use that it's being guarded bymatchURLin the first place.Before:
After: