Uh oh!
There was an error while loading. Please reload this page.
Port various PoB2 buy similar and comparison tab PRs - #9857
Conversation
68e4750 to
a3c464bComparevaisest
commented
May 19, 2026
Notably, crucible mods aren't matched. This probably doesn't matter much because standard, but regardless in the future it can be added once there's an easier way to match mods. The trade site specifically matches against crucible mods, and not just single stats |
0743852 to
8b22835Compare8b22835 to
520d030Compare127ba5f to
4d3ba04Comparevaisest
commented
Jun 30, 2026
This now has all (hopefully) of the PoB2 buy similar stuff. That is, the refactored mod matching, UI which auto generates the URL, and a button for the popup in the items tab |
586e73e to
4d3ba04CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
01a9108 to
dd5ed5dComparevaisest
commented
Jul 1, 2026
This also ports PathOfBuildingCommunity/PathOfBuilding-PoE2#2339 |
vaisest
commented
Jul 2, 2026
This now also ports PathOfBuildingCommunity/PathOfBuilding-PoE2#2194 |
0681b5d to
1d17fb2CompareLeague selections now use the realm Trade stat lookup is now cached as it wasn't using it before Use isValueInArray function in place of extra code Add some tests and fix others
LocalIdentity
left a comment
There was a problem hiding this comment.
fixed a few small issues but PR looks good to go now
Guessing some of the commented out code in crucible and cluister are for a later PR
Uh oh!
There was an error while loading. Please reload this page.
Description of the problem being solved:
This PR removes the need to manually generate the URL and reworks the mod matching. Both of these features are ported over from PoB2.
This also contains tradehash fixes for mods.lua. These aren't actually used here now, but they should still be ported over since it will be necessary for the trader, and in general should just be corrected
This ports the following PRs:
This also ports the updated mods.lua export script which exports trade hashes properly. This is no longer actually necessary for the buy similar popup, but I'd prefer to keep it here as it'll be useful later anyway.Things like the crucible hashes and cluster skill ids won't be used, but are still informative. These can be commented out if it's a problem.Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/mFd6odfh1yun (has many items and some that use dropdowns on the trade site.
Before screenshot:
After screenshot: