Skip to content

Port various PoB2 buy similar and comparison tab PRs - #9857

Merged
LocalIdentity merged 19 commits into
PathOfBuildingCommunity:devfrom
vaisest:comparison-tab-market-search-fixes
Jul 20, 2026
Merged

Port various PoB2 buy similar and comparison tab PRs#9857
LocalIdentity merged 19 commits into
PathOfBuildingCommunity:devfrom
vaisest:comparison-tab-market-search-fixes

Conversation

@vaisest

@vaisestvaisest commented May 17, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

This PR removes the need to manually generate the URL and reworks the mod matching. Both of these features are ported over from PoB2.

This also contains tradehash fixes for mods.lua. These aren't actually used here now, but they should still be ported over since it will be necessary for the trader, and in general should just be corrected

This ports the following PRs:

Steps taken to verify a working solution:

  • Lots of manual testing. As far as I can see, most stats should work fine, and the only issues are primarily caused by PoB splitting single stats into multiple mod lines. E.g. PoB parses "Passage" as its own mod line despite it actually being a part of other stats.
  • Automated tests ported

Link to a build that showcases this PR:

https://pobb.in/mFd6odfh1yun (has many items and some that use dropdowns on the trade site.

Before screenshot:

imageimage

After screenshot:

imageimageimage

@vaisest
vaisestforce-pushed the comparison-tab-market-search-fixes branch from 68e4750 to a3c464bCompareMay 18, 2026 10:13
@vaisest
vaisest changed the base branch from dev to fix_compare-visualsMay 18, 2026 10:13
@vaisestvaisest changed the title Port matching by tradehash in comparison buy similar menuBuy similar: fix mod matching and improve search workflowMay 19, 2026
@vaisest
vaisest marked this pull request as ready for review May 19, 2026 02:11
@vaisest

Copy link
Copy Markdown
ContributorAuthor

Notably, crucible mods aren't matched. This probably doesn't matter much because standard, but regardless in the future it can be added once there's an easier way to match mods. The trade site specifically matches against crucible mods, and not just single stats

@vaisest
vaisestforce-pushed the comparison-tab-market-search-fixes branch 3 times, most recently from 0743852 to 8b22835CompareMay 27, 2026 16:26
@vaisest
vaisest changed the base branch from fix_compare-visuals to devMay 27, 2026 16:26
@vaisest
vaisestforce-pushed the comparison-tab-market-search-fixes branch from 8b22835 to 520d030CompareMay 27, 2026 16:28
@vaisest
vaisest marked this pull request as draft June 29, 2026 15:34
@vaisest
vaisestforce-pushed the comparison-tab-market-search-fixes branch 2 times, most recently from 127ba5f to 4d3ba04CompareJune 30, 2026 15:59
@vaisest

Copy link
Copy Markdown
ContributorAuthor

This now has all (hopefully) of the PoB2 buy similar stuff. That is, the refactored mod matching, UI which auto generates the URL, and a button for the popup in the items tab

@vaisest
vaisestforce-pushed the comparison-tab-market-search-fixes branch from 586e73e to 4d3ba04CompareJune 30, 2026 16:21
@vaisest
vaisest marked this pull request as ready for review June 30, 2026 19:24
Comment threadsrc/Export/Scripts/mods.lua Outdated
Comment threadsrc/Export/Scripts/mods.lua Outdated
Comment threadsrc/Export/Scripts/mods.lua Outdated
@vaisest
vaisestforce-pushed the comparison-tab-market-search-fixes branch from 01a9108 to dd5ed5dCompareJuly 1, 2026 08:49
@vaisest

Copy link
Copy Markdown
ContributorAuthor

@vaisest

Copy link
Copy Markdown
ContributorAuthor

This now also ports PathOfBuildingCommunity/PathOfBuilding-PoE2#2194

@vaisestvaisest changed the title Buy similar: fix mod matching and improve search workflowPort various PoB2 buy similar and comparison tab PRsJul 2, 2026
@vaisestvaisest mentioned this pull request Jul 8, 2026
@vaisest
vaisestforce-pushed the comparison-tab-market-search-fixes branch from 0681b5d to 1d17fb2CompareJuly 12, 2026 10:39
LocalIdentity added 3 commits July 20, 2026 22:15
League selections now use the realm
Trade stat lookup is now cached as it wasn't using it before
Use isValueInArray function in place of extra code
Add some tests and fix others

@LocalIdentityLocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed a few small issues but PR looks good to go now
Guessing some of the commented out code in crucible and cluister are for a later PR

@LocalIdentity
LocalIdentity merged commit d07ef7c into PathOfBuildingCommunity:devJul 20, 2026
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vaisest@Nightblade@LocalIdentity