Skip to content

pat-inject modernization - #943

Closed
thet wants to merge 3 commits into
masterfrom
inject-autoload-visible-rework
Closed

pat-inject modernization#943
thet wants to merge 3 commits into
masterfrom
inject-autoload-visible-rework

Conversation

@thet

@thetthet commented Dec 22, 2021

Copy link
Copy Markdown
Member

A side outcome of the pat-inject autoload-visible fixes.

Eventually this will be revisited later to rework pat-inject for a more readable, simpler and clearer structure.

The branch name is misleading.

@thet
thet marked this pull request as draft December 22, 2021 11:42
@thet
thetforce-pushed the inject-autoload-visible-rework branch from 26c6175 to 0b2970cCompareJanuary 27, 2022 10:32
@thetthet changed the title Inject autoload visible reworkpat-inject modernizationJan 27, 2022
@thet
thetforce-pushed the inject-autoload-visible-rework branch from 0b2970c to 5550abdCompareFebruary 21, 2022 14:13
@thet
thetforce-pushed the master branch 2 times, most recently from e3b2897 to 5060fa4CompareMarch 14, 2022 07:50
@thetthet mentioned this pull request Jan 12, 2025
@thet

thet commented Jan 12, 2025

Copy link
Copy Markdown
MemberAuthor

This is replaced by: #1222
Except for the Base prototype rework, which is obsolete on it's own since I'd use the class based pattern approach now.
However, reworking into a class-based pattern is intended as it will give us encapsulation. Now we cannot bind any variables on this but need to bind everything on the node element itself. This will make the code simpler, more readable and more error-prone.

@thetthet closed this Jan 12, 2025
@thet
thet deleted the inject-autoload-visible-rework branch January 12, 2025 21:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@thet