Uh oh!
There was an error while loading. Please reload this page.
Fix send_file environment variables - #1067
Open
odyniec wants to merge 1 commit into
Open
Conversation
jwittkoski
commented
Mar 6, 2015
Contributor
In the existing code a minimal replacement Why doesn't it just take the original |
jwittkoski
commented
Mar 6, 2015
Contributor
This bug also shows up in the logs if you are using certain logging placeholders (like I didn't realize it at the time, but this bug is at least one reason #1029 was happening in some situations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some request environment variables, such as
psgi.*, are missing when a file is served usingsend_file. I'm not sure how to write a proper test for this, but the problem can be demonstrated with a simple app:A request for, say,
/images/perldancer.jpg, producesurl_scheme: http, while a request for/fileresults inurl_scheme:(undefined).This change fixes the problem by passing the
SharedData->requestenvironment to the new request object created in_send_file.