Uh oh!
There was an error while loading. Please reload this page.
Streamset filter to use dataframe - #44
Draft
jleifnf wants to merge 3 commits into
Draft
Conversation
jleifnf
marked this pull request as draft
August 23, 2023 16:35
andrewchambers
commented
Aug 30, 2023
Don't know if we want to add dask in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the StreamSet's filter to remove multiple for-loops by build a hidden metadata table and using DataFrame.
Tested on StreamSet of 6471 streams (originally took ~50 seconds) to filter down streamset.filter(unit=re.compile(r'FREQ|FLAG'), name=re.compile(r'FQ|FLAG')) to 294 streams.
With this code change, the stream filter took ~10seconds (5x)..