Fix compilation errors with modern ROOT and c++ - #3
Conversation
PlutoUser
commented
Jun 22, 2023
there are some conflicts with the version from GSI Gitlab, could you resolve this? |
rlalik
commented
Jun 22, 2023
Can you show me what conflicts are there? I added another improvements which detects root < 6.22 (version where the significant change happen) and perhaps this will fix the issue? |
rlalik
commented
Jun 22, 2023
Ok, I see that there was another fix by Jochen, which was not merged apparently when I made the fork. So now my fix conflicts with his. Perhaps this must be abandon then. |
PlutoUser
commented
Jun 22, 2023
We have several ROOT versions (and more to come), I think the solution to use an #if-#elif-#else consstuction is the best way |
PlutoUser
commented
Jun 27, 2023
what about this merge, is it still to be merged or should it be closed? |
rlalik
commented
Jul 11, 2023
The fix in other commit which fixed the issue is in conflict with this merge. Those are two different approaches, one could check which one would work better. One can keep this still open for future work but now please check the other PR because the are more urgent. |
fParamsofTF1Paramsis now ofstd::unique_ptrtype, not raw pointer. Thus I fixed that. Sincestd::make_uniqueis not available in c++11 I addedd a simle implementation in a pluto private header.While saving files some trailing whitespaces were removed.