Fix location area encounters lookup assuming contiguous ids by santichausis · Pull Request #1608 · PokeAPI/pokeapi

santichausis · 2026-07-17T15:59:23Z

Problem

Same root cause as #1567 (fixed in #1603): LocationAreaDetailSerializer.get_encounters looks up Version summaries by list position (id - 1), assuming the table forms a contiguous 1-indexed sequence.

Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned for an encounter, or raises an IndexError.

This was originally reported in #1313 and attempted in #1314, which was closed without merging.

Fix

Same approach as #1603: build a dict keyed by the actual id instead of relying on list position.

Test plan

Added test_location_area_encounters_with_non_contiguous_version_ids, which creates and deletes a Version to force a gap, then asserts the location-area endpoint still returns the correct version.
Verified this test reproduces the IndexError against the old code and passes with the fix.
manage.py test pokemon_v2 passes (56 tests).
black --check passes.

Same issue as PokeAPI#1567 / PR PokeAPI#1603 (previously fixed in get_pokemon_moves): LocationAreaDetailSerializer.get_encounters looked up Version summaries by list position (id - 1), assuming ids form a contiguous 1-indexed sequence. Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned, or an IndexError. This is the same root cause reported in PokeAPI#1313 and previously attempted in PR PokeAPI#1314 (closed, unmerged).

Naramsim · 2026-07-18T06:21:21Z

Thanks a lot!

pokeapi-machine-user · 2026-07-18T06:34:43Z

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user · 2026-07-18T07:08:51Z

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

santichausis · 2026-07-17T15:59:23Z

Problem

Same root cause as #1567 (fixed in #1603): LocationAreaDetailSerializer.get_encounters looks up Version summaries by list position (id - 1), assuming the table forms a contiguous 1-indexed sequence.

Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned for an encounter, or raises an IndexError.

This was originally reported in #1313 and attempted in #1314, which was closed without merging.

Fix

Same approach as #1603: build a dict keyed by the actual id instead of relying on list position.

Test plan

Added test_location_area_encounters_with_non_contiguous_version_ids, which creates and deletes a Version to force a gap, then asserts the location-area endpoint still returns the correct version.
Verified this test reproduces the IndexError against the old code and passes with the fix.
manage.py test pokemon_v2 passes (56 tests).
black --check passes.

Same issue as PokeAPI#1567 / PR PokeAPI#1603 (previously fixed in get_pokemon_moves): LocationAreaDetailSerializer.get_encounters looked up Version summaries by list position (id - 1), assuming ids form a contiguous 1-indexed sequence. Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned, or an IndexError. This is the same root cause reported in PokeAPI#1313 and previously attempted in PR PokeAPI#1314 (closed, unmerged).

Naramsim · 2026-07-18T06:21:21Z

Thanks a lot!

pokeapi-machine-user · 2026-07-18T06:34:43Z

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user · 2026-07-18T07:08:51Z

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

santichausis · 2026-07-17T15:59:23Z

Problem

Same root cause as #1567 (fixed in #1603): LocationAreaDetailSerializer.get_encounters looks up Version summaries by list position (id - 1), assuming the table forms a contiguous 1-indexed sequence.

Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned for an encounter, or raises an IndexError.

This was originally reported in #1313 and attempted in #1314, which was closed without merging.

Fix

Same approach as #1603: build a dict keyed by the actual id instead of relying on list position.

Test plan

Added test_location_area_encounters_with_non_contiguous_version_ids, which creates and deletes a Version to force a gap, then asserts the location-area endpoint still returns the correct version.
Verified this test reproduces the IndexError against the old code and passes with the fix.
manage.py test pokemon_v2 passes (56 tests).
black --check passes.

Same issue as PokeAPI#1567 / PR PokeAPI#1603 (previously fixed in get_pokemon_moves): LocationAreaDetailSerializer.get_encounters looked up Version summaries by list position (id - 1), assuming ids form a contiguous 1-indexed sequence. Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned, or an IndexError. This is the same root cause reported in PokeAPI#1313 and previously attempted in PR PokeAPI#1314 (closed, unmerged).

Naramsim · 2026-07-18T06:21:21Z

Thanks a lot!

pokeapi-machine-user · 2026-07-18T06:34:43Z

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user · 2026-07-18T07:08:51Z

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

santichausis · 2026-07-17T15:59:23Z

Problem

Same root cause as #1567 (fixed in #1603): LocationAreaDetailSerializer.get_encounters looks up Version summaries by list position (id - 1), assuming the table forms a contiguous 1-indexed sequence.

Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned for an encounter, or raises an IndexError.

This was originally reported in #1313 and attempted in #1314, which was closed without merging.

Fix

Same approach as #1603: build a dict keyed by the actual id instead of relying on list position.

Test plan

Added test_location_area_encounters_with_non_contiguous_version_ids, which creates and deletes a Version to force a gap, then asserts the location-area endpoint still returns the correct version.
Verified this test reproduces the IndexError against the old code and passes with the fix.
manage.py test pokemon_v2 passes (56 tests).
black --check passes.

Same issue as PokeAPI#1567 / PR PokeAPI#1603 (previously fixed in get_pokemon_moves): LocationAreaDetailSerializer.get_encounters looked up Version summaries by list position (id - 1), assuming ids form a contiguous 1-indexed sequence. Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned, or an IndexError. This is the same root cause reported in PokeAPI#1313 and previously attempted in PR PokeAPI#1314 (closed, unmerged).

Naramsim · 2026-07-18T06:21:21Z

Thanks a lot!

pokeapi-machine-user · 2026-07-18T06:34:43Z

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user · 2026-07-18T07:08:51Z

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

santichausis · 2026-07-17T15:59:23Z

Problem

Same root cause as #1567 (fixed in #1603): LocationAreaDetailSerializer.get_encounters looks up Version summaries by list position (id - 1), assuming the table forms a contiguous 1-indexed sequence.

Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned for an encounter, or raises an IndexError.

This was originally reported in #1313 and attempted in #1314, which was closed without merging.

Fix

Same approach as #1603: build a dict keyed by the actual id instead of relying on list position.

Test plan

Added test_location_area_encounters_with_non_contiguous_version_ids, which creates and deletes a Version to force a gap, then asserts the location-area endpoint still returns the correct version.
Verified this test reproduces the IndexError against the old code and passes with the fix.
manage.py test pokemon_v2 passes (56 tests).
black --check passes.

Same issue as PokeAPI#1567 / PR PokeAPI#1603 (previously fixed in get_pokemon_moves): LocationAreaDetailSerializer.get_encounters looked up Version summaries by list position (id - 1), assuming ids form a contiguous 1-indexed sequence. Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned, or an IndexError. This is the same root cause reported in PokeAPI#1313 and previously attempted in PR PokeAPI#1314 (closed, unmerged).

Naramsim · 2026-07-18T06:21:21Z

Thanks a lot!

pokeapi-machine-user · 2026-07-18T06:34:43Z

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user · 2026-07-18T07:08:51Z

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

santichausis · 2026-07-17T15:59:23Z

Problem

Same root cause as #1567 (fixed in #1603): LocationAreaDetailSerializer.get_encounters looks up Version summaries by list position (id - 1), assuming the table forms a contiguous 1-indexed sequence.

Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned for an encounter, or raises an IndexError.

This was originally reported in #1313 and attempted in #1314, which was closed without merging.

Fix

Same approach as #1603: build a dict keyed by the actual id instead of relying on list position.

Test plan

Added test_location_area_encounters_with_non_contiguous_version_ids, which creates and deletes a Version to force a gap, then asserts the location-area endpoint still returns the correct version.
Verified this test reproduces the IndexError against the old code and passes with the fix.
manage.py test pokemon_v2 passes (56 tests).
black --check passes.

Same issue as PokeAPI#1567 / PR PokeAPI#1603 (previously fixed in get_pokemon_moves): LocationAreaDetailSerializer.get_encounters looked up Version summaries by list position (id - 1), assuming ids form a contiguous 1-indexed sequence. Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned, or an IndexError. This is the same root cause reported in PokeAPI#1313 and previously attempted in PR PokeAPI#1314 (closed, unmerged).

Naramsim · 2026-07-18T06:21:21Z

Thanks a lot!

pokeapi-machine-user · 2026-07-18T06:34:43Z

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user · 2026-07-18T07:08:51Z

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

santichausis · 2026-07-17T15:59:23Z

Problem

Same root cause as #1567 (fixed in #1603): LocationAreaDetailSerializer.get_encounters looks up Version summaries by list position (id - 1), assuming the table forms a contiguous 1-indexed sequence.

Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned for an encounter, or raises an IndexError.

This was originally reported in #1313 and attempted in #1314, which was closed without merging.

Fix

Same approach as #1603: build a dict keyed by the actual id instead of relying on list position.

Test plan

Added test_location_area_encounters_with_non_contiguous_version_ids, which creates and deletes a Version to force a gap, then asserts the location-area endpoint still returns the correct version.
Verified this test reproduces the IndexError against the old code and passes with the fix.
manage.py test pokemon_v2 passes (56 tests).
black --check passes.

Same issue as PokeAPI#1567 / PR PokeAPI#1603 (previously fixed in get_pokemon_moves): LocationAreaDetailSerializer.get_encounters looked up Version summaries by list position (id - 1), assuming ids form a contiguous 1-indexed sequence. Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned, or an IndexError. This is the same root cause reported in PokeAPI#1313 and previously attempted in PR PokeAPI#1314 (closed, unmerged).

Naramsim · 2026-07-18T06:21:21Z

Thanks a lot!

pokeapi-machine-user · 2026-07-18T06:34:43Z

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user · 2026-07-18T07:08:51Z

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

santichausis · 2026-07-17T15:59:23Z

Problem

Same root cause as #1567 (fixed in #1603): LocationAreaDetailSerializer.get_encounters looks up Version summaries by list position (id - 1), assuming the table forms a contiguous 1-indexed sequence.

Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned for an encounter, or raises an IndexError.

This was originally reported in #1313 and attempted in #1314, which was closed without merging.

Fix

Same approach as #1603: build a dict keyed by the actual id instead of relying on list position.

Test plan

Added test_location_area_encounters_with_non_contiguous_version_ids, which creates and deletes a Version to force a gap, then asserts the location-area endpoint still returns the correct version.
Verified this test reproduces the IndexError against the old code and passes with the fix.
manage.py test pokemon_v2 passes (56 tests).
black --check passes.

Same issue as PokeAPI#1567 / PR PokeAPI#1603 (previously fixed in get_pokemon_moves): LocationAreaDetailSerializer.get_encounters looked up Version summaries by list position (id - 1), assuming ids form a contiguous 1-indexed sequence. Any gap in the Version table (e.g. a deleted row) causes the wrong version to be returned, or an IndexError. This is the same root cause reported in PokeAPI#1313 and previously attempted in PR PokeAPI#1314 (closed, unmerged).

Naramsim · 2026-07-18T06:21:21Z

Thanks a lot!

pokeapi-machine-user · 2026-07-18T06:34:43Z

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user · 2026-07-18T07:08:51Z

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim approved these changes Jul 18, 2026
View reviewed changes